Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Add support for on-demand key frames

2024-09-05 Thread Anton Khirnov
Quoting Lynne via ffmpeg-devel (2024-09-05 23:27:40) > On 05/09/2024 07:16, Cameron Gutman wrote: > > Signed-off-by: Cameron Gutman > > --- > > libavcodec/amfenc.c | 34 +- > > 1 file changed, 33 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/amfen

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Add support for on-demand key frames

2024-09-05 Thread Lynne via ffmpeg-devel
On 05/09/2024 07:16, Cameron Gutman wrote: Signed-off-by: Cameron Gutman --- libavcodec/amfenc.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 41eaef9758..6f2b211d14 100644 --- a/libavcode

Re: [FFmpeg-devel] [PATCH v4 06/17] avcodec/libvpxenc: switch to get_supported_config()

2024-09-05 Thread James Zern via ffmpeg-devel
On Wed, Sep 4, 2024 at 4:10 AM Niklas Haas wrote: > > From: Niklas Haas > > --- > libavcodec/libvpxenc.c | 26 +++--- > 1 file changed, 19 insertions(+), 7 deletions(-) > lgtm ___ ffmpeg-devel mailing list [email protected] h

Re: [FFmpeg-devel] [PATCH 06/42] lavc: add HEVC Multiview Main profile

2024-09-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-09-04 23:05:28) > On Tue, Aug 27, 2024 at 05:04:46PM +0200, Anton Khirnov wrote: > > --- > > doc/APIchanges| 3 +++ > > libavcodec/defs.h | 1 + > > libavcodec/hevc/ps.c | 21 + > > libavcodec/profiles.c | 1 + > > libavcodec/ve

Re: [FFmpeg-devel] [PATCH v4 12/17] fftools/ffmpeg_mux_init: switch to avcodec_get_supported_config()

2024-09-05 Thread Anton Khirnov
Quoting Niklas Haas (2024-09-04 13:02:41) > From: Niklas Haas > > --- > fftools/ffmpeg_mux_init.c | 22 +- > 1 file changed, 17 insertions(+), 5 deletions(-) LGTM -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH] doc/filters: update uspp availability status

2024-09-05 Thread Gyan Doshi
On 2024-09-05 01:29 am, Michael Niedermayer wrote: On Wed, Sep 04, 2024 at 01:33:50PM +0530, Gyan Doshi wrote: The filter was disabled in 95054bfa48 and re-enabled in 771c27119d --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM Thanks. Pushed as 3d0d0f68d5

[FFmpeg-devel] [PATCH 0/1] avfilter/framesync: fix forward EOF pts

2024-09-05 Thread Nicolas Gaullier
Rebased with no change. Pinging again ? Nicolas Gaullier (1): avfilter/framesync: fix forward EOF pts libavfilter/framesync.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) -- 2.30.2 ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/1] avfilter/framesync: fix forward EOF pts

2024-09-05 Thread Nicolas Gaullier
Note1: when the EOF pts is not accurate enough, the last frame can be dropped by vf_fps with default rounding. Note2: vf_scale use framesync since e82a3997cdd6c0894869b33ba42430ac3, so this is a very commonplace scenario. For example: ./ffprobe -f lavfi testsrc=d=1,scale,fps -of flat \ -count_f

[FFmpeg-devel] [PATCH 10/25] lavfi/af_hdcd: convert to query_func2()

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_hdcd.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 40d62c8793..5b408bb5af 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1601,8 +1601,15 @@ static int

[FFmpeg-devel] [PATCH 09/25] lavfi/af_haas: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop a redundant call that also happens implicitly in generic code. --- libavfilter/af_haas.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_haas.c b/libavfilter/af_haas.c index 6385b328e4..81643cfd9d 100644 --- a/libavfilter/

[FFmpeg-devel] [PATCH 06/25] lavfi/af_dialoguenhance: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_dialoguenhance.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/libavfilter/af_dialoguenhance.c b/libavfilter/af_dialoguenhance.c index b77e85198f..cae83

[FFmpeg-devel] [PATCH 12/25] lavfi/af_join: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop a redundant call that also happens implicitly in generic code. --- libavfilter/af_join.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index e1d8b0e00c..db0320aa70 100644 --- a/libavfilter/af_join.c +++

[FFmpeg-devel] [PATCH 05/25] lavfi/af_crossfeed: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_crossfeed.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_crossfeed.c b/libavfilter/af_crossfeed.c index 36f05cfd21..91f5a4772e 100644 --- a

[FFmpeg-devel] [PATCH 04/25] lavfi/af_channelsplit: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop a redundant call that also happens implicitly in generic code. --- libavfilter/af_channelsplit.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c index 527c197fa6..64b6c7a1e1 100644 --- a/lib

[FFmpeg-devel] [PATCH 14/25] lavfi/af_loudnorm: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_loudnorm.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c index d28c4556df..d63a713818 100644 --- a/libavfil

[FFmpeg-devel] [PATCH 24/25] lavfi/af_pan: stop modifying private data in query_formats()

2024-09-05 Thread Anton Khirnov
It is not supposed to have any side effects, and the modification in question can just as well be done in filter init. --- libavfilter/af_pan.c | 48 ++-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/libavfilter/af_pan.c b/libavfilter/af_p

[FFmpeg-devel] [PATCH 18/25] lavfi/af_stereowiden: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_stereowiden.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_stereowiden.c b/libavfilter/af_stereowiden.c index 6718bb39a5..b3a5cba7b2 10064

[FFmpeg-devel] [PATCH 19/25] lavfi/af_stereotools: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_stereotools.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_stereotools.c b/libavfilter/af_stereotools.c index 934c5d33aa..ed22f41637 1006

[FFmpeg-devel] [PATCH 21/25] lavfi/af_sidechaincompress: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_sidechaincompress.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/libavfilter/af_sidechaincompress.c b/libavfilter/af_sidechaincompress.c index 80c6e3cab1..d2

[FFmpeg-devel] [PATCH 22/25] lavfi/af_replaygain: convert to query_func2()

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_replaygain.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/libavfilter/af_replaygain.c b/libavfilter/af_replaygain.c index 072ffa2aea..ab3ca03ffd 100644 --- a/libavfilter/af_replaygain.c +++ b/libavfilter/af_replaygain.

[FFmpeg-devel] [PATCH 17/25] lavfi/af_surround: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_surround.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavfilter/af_surround.c b/libavfilter/af_surround.c index 111af03335..95efe4685a 100644 --- a/liba

[FFmpeg-devel] [PATCH 23/25] lavfi/af_lv2: convert to query_func2()

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_lv2.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/libavfilter/af_lv2.c b/libavfilter/af_lv2.c index 7e8ab4de03..db9b1e3639 100644 --- a/libavfilter/af_lv2.c +++ b/libavfilter/af_lv2.c @@ -474,25 +474,22 @@ static av_cold int

[FFmpeg-devel] [PATCH 16/25] lavfi/af_virtualbass: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_virtualbass.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/libavfilter/af_virtualbass.c b/libavfilter/af_virtualbass.c index 232e5fe48a..d2f28ab1a1 10064

[FFmpeg-devel] [PATCH 20/25] lavfi/af_sofalizer: convert to query_func2()

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_sofalizer.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_sofalizer.c b/libavfilter/af_sofalizer.c index e647d2fe4e..178b9c0b53 100644 --- a/libavfilter/af_sofalizer.c +++ b/libavfilter/af_sofalizer.c @@ -634,9 +634,11 @@ sta

[FFmpeg-devel] [PATCH 25/25] lavfi/af_pan: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_pan.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index f2f6daa658..0d20b0307b 100644 --- a/libavfilter/af_pan.c +++ b

[FFmpeg-devel] [PATCH 13/25] lavfi/af_ladspa: convert to query_func2()

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_ladspa.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/libavfilter/af_ladspa.c b/libavfilter/af_ladspa.c index 2f8c92cd14..35ff90b1a8 100644 --- a/libavfilter/af_ladspa.c +++ b/libavfilter/af_ladspa.c @@ -694,31 +694,29 @@

[FFmpeg-devel] [PATCH 15/25] lavfi/af_volume: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop redundant calls that also happen implicitly in generic code. --- libavfilter/af_volume.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index d2f8a1c1fa..ed924cf45f 100644 --- a/libavfilter/af_volu

[FFmpeg-devel] [PATCH 11/25] lavfi/af_headphone: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop a redundant call that also happens implicitly in generic code. --- libavfilter/af_headphone.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavfilter/af_headphone.c b/libavfilter/af_headphone.c index f97f329293..fccd8d3f12 100644

[FFmpeg-devel] [PATCH 07/25] lavfi/af_earwax: convert to query_func2()

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_earwax.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_earwax.c b/libavfilter/af_earwax.c index cd19ac421e..7d7e060a33 100644 --- a/libavfilter/af_earwax.c +++ b/libavfilter/af_earwax.c @@ -79,19 +79,32 @@ typ

[FFmpeg-devel] [PATCH 02/25] lavfi/af_channelsplit: support arbitrary channel layouts

2024-09-05 Thread Anton Khirnov
Not just those containing channel values under 64. Also, remove an arbitrary limitation on channel count. --- libavfilter/af_channelsplit.c | 43 +++ 1 file changed, 29 insertions(+), 14 deletions(-) diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_chann

[FFmpeg-devel] [PATCH 08/25] lavfi/af_extrastereo: convert to query_func2()

2024-09-05 Thread Anton Khirnov
Also, drop a redundant call that also happens implicitly in generic code. --- libavfilter/af_extrastereo.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/libavfilter/af_extrastereo.c b/libavfilter/af_extrastereo.c index 6563b39402..dc5cc76fa4 100

[FFmpeg-devel] [PATCH 01/25] lavfi/af_channelmap: remove an arbitrary limit on channel count

2024-09-05 Thread Anton Khirnov
--- libavfilter/af_channelmap.c | 87 +++-- 1 file changed, 54 insertions(+), 33 deletions(-) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 3f02a7fd8f..f5209a10cd 100644 --- a/libavfilter/af_channelmap.c +++ b/libavfilter/af_channelma

[FFmpeg-devel] [PATCH 03/25] tests/fate/filter-audio: add a test for handling more than 64 channels

2024-09-05 Thread Anton Khirnov
The test constructs 66 sine waves of different frequencies and joins them into a 7th order ambisonic layout with extra non-diegetic stereo. The channels are then shifted circularly with channelmap and separated into individual streams for muxing with channelsplit. Note that the last step is necess

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/jpeg2000dec: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4.

2024-09-05 Thread WATANABE Osamu
Some typos and trailing white spaces are found. Those will be corrected in the upcoming v4. > On Sep 5, 2024, at 10:54, WATANABE Osamu > wrote: > > This commit fixes the problem described below on the integer version of the > inverse DWT processing (FF_DWT97_INT, https://trac.ffmpeg.org/ticke