Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-27 Thread Leo Izen
On 6/27/24 1:27 PM, Lynne via ffmpeg-devel wrote: On 21/06/2024 23:20, Leo Izen wrote: int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. Sorry, missed this patch, LGTM. Applied as 539d2e989d7ce3556a549d59ee9c5125ae7d7b6b - Leo

[FFmpeg-devel] [PATCH 2/2] avformat/file: guard fd_dup by FD_PROTOCOL or PIPE_PROTOCOL

2024-06-27 Thread Zhao Zhili
From: Zhao Zhili fd_dup is unused when fd and pipe have been disabled. This also fix build error with wasi since 'dup' isn't available. Signed-off-by: Zhao Zhili --- libavformat/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 3fc1e741f

[FFmpeg-devel] [PATCH 1/2] avutil/file_open: Fix build error with wasi

2024-06-27 Thread Zhao Zhili
From: Zhao Zhili Don't assume tempnam is available when !HAVE_MKSTEMP. Check tempnam explicitly in configure. Signed-off-by: Zhao Zhili --- configure | 2 ++ libavutil/file_open.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 7685

[FFmpeg-devel] [PATCH] configure: Fix Apple framework dependencies in .pc file

2024-06-27 Thread Zhao Zhili
From: Zhao Zhili configure use "-Wl,-framework,foo" and "-framework foo" to specify dependencies on Apple frameworks. These two styles essentially do the same thing when build ffmpeg. However, they do make difference when generate pkg-config files. Some tools interact with pkg-config cannot handl

[FFmpeg-devel] [PATCH 0/2] Add wasi(WebAssembly System Interface) support

2024-06-27 Thread Zhao Zhili
From: Zhao Zhili With wasi-sdk toolchain [1], now you can ./configure --cc=${wasi-sdk}/bin/clang \ --cxx=${wasi-sdk}/bin/clang++ \ --ar=${wasi-sdk}/bin/ar \ --strip=${wasi-sdk}/bin/strip \ --nm=${wasi-sdk}/bin/llvm-nm \ --ranlib=${wasi-sdk}/bin/ranlib \

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mpeg_er: Don't set block_index unnecessarily

2024-06-27 Thread Michael Niedermayer
On Thu, Jun 20, 2024 at 05:01:08PM +, Andreas Rheinhardt wrote: > ffmpeg | branch: master | Andreas Rheinhardt > | Wed Jun 12 08:37:53 2024 +0200| [65d5ccb808ec93de46a2458ea8cc082ce4460f34] > | committer: Andreas Rheinhardt > > avcodec/mpeg_er: Don't set block_index unnecessarily > > ff_in

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-27 Thread Ramiro Polla
Hi Stefan, On Thu, Jun 27, 2024 at 6:32 PM Stefan Westerfeld wrote: > This will send the audio stream to an external command as wav file and > read back the output of the subprocess which is also supposed to be a > wav file of the same format and length. Subprocesses are a pita to support and ma

Re: [FFmpeg-devel] [PATCH] avformat/nuv: return early if header id fails to read

2024-06-27 Thread Michael Niedermayer
On Tue, Jun 25, 2024 at 11:50:30PM +0200, Kacper Michajłow wrote: > Fixes use of uninitialized value in memcmp below, reported by MSAN. > > Found by OSS-Fuzz. > > Signed-off-by: Kacper Michajłow > --- > libavformat/nuv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) will apply th

Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: Simplify padding cell trim logic

2024-06-27 Thread Marth64
Please ignore this v2 patch also. There’s an issue with it. Apologies again. On Thu, Jun 27, 2024 at 01:06 Marth64 wrote: > When -trim option is used (by default), padding cells > at the beginning of the title are supposed to be ignored. > The current implementation does the ignoring when we > a

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-27 Thread Stefan Westerfeld
Hi! Am 27.06.24 um 19:19 schrieb Paul B Mahol: I do not want to comment code. No problem, so maybe we can discuss this without getting into the implementation details. But this concept/idea/whatever is plain nonsense. Why? It would be great if you could give me some idea what you thin

[FFmpeg-devel] [PATCH 2/3] lavc/vc1dsp: fix overflow in R-V V inv_trans_8

2024-06-27 Thread Rémi Denis-Courmont
The last set of additions/subtractions can break the 16-bit limit, and require 17 bits of precision. This uses widening adds accordingly to fix the MSS2 FATE tests. --- libavcodec/riscv/vc1dsp_rvv.S | 37 --- 1 file changed, 21 insertions(+), 16 deletions(-) diff -

[FFmpeg-devel] [PATCH 1/3] lavc/vc1dsp: factor R-V V inv_trans_8 code

2024-06-27 Thread Rémi Denis-Courmont
--- libavcodec/riscv/vc1dsp_rvv.S | 64 +-- 1 file changed, 23 insertions(+), 41 deletions(-) diff --git a/libavcodec/riscv/vc1dsp_rvv.S b/libavcodec/riscv/vc1dsp_rvv.S index 7e1fb84b0c..b3a1f55ab9 100644 --- a/libavcodec/riscv/vc1dsp_rvv.S +++ b/libavcodec/riscv/v

[FFmpeg-devel] [PATCH 3/3] lavc/vc1dsp: fix potential overflow in R-V V inv_trans_4

2024-06-27 Thread Rémi Denis-Courmont
Judging by the coefficients, the last round of add/sub can overflow to 17 bits with a very small probability just as with the 8-point transform. This is not observed under FATE, but better safe than sorry. --- libavcodec/riscv/vc1dsp_rvv.S | 15 --- 1 file changed, 8 insertions(+), 7 d

Re: [FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

2024-06-27 Thread Marton Balint
On Thu, 27 Jun 2024, Anton Khirnov wrote: Share the code between encoding and decoding. Instead of checking every stream's options dictionary (which is also used for other purposes), track all used options in a dedicated dictionary. --- fftools/cmdutils.c| 17 fftools/cmdu

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Always set flags for the current picture

2024-06-27 Thread Frank Plowman
On 27/06/2024 13:52, Nuo Mi wrote: > On Mon, Jun 24, 2024 at 11:30 PM Frank Plowman > wrote: > >> ff_vvc_frame_rpl uses the flags to detect whether a frame is in use. >> Therefore, in the case of a CVSS AU (RASL/GDR with >> NoOutputBeforeRecoveryFlag) with ph_non_ref_pic_flag = 1, the frame >> wo

[FFmpeg-devel] [PATCH v2] lavc/vvc: Always set flags for the current picture

2024-06-27 Thread Frank Plowman
ff_vvc_frame_rpl uses the flags to detect whether a frame is in use. Therefore, in the case of a CVSS AU (RASL/GDR with NoOutputBeforeRecoveryFlag) with ph_non_ref_pic_flag = 1, the frame would be freed before it is used. Fix this by always marking the current frame with VVC_FRAME_FLAG_SHORT_REF,

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-27 Thread Lynne via ffmpeg-devel
On 21/06/2024 23:20, Leo Izen wrote: int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. --- libavcodec/aac/aacdec_lpd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavco

Re: [FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-27 Thread Paul B Mahol
I do not want to comment code. But this concept/idea/whatever is plain nonsense. ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpe

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-27 Thread Leo Izen
On 6/21/24 5:20 PM, Leo Izen wrote: int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. --- libavcodec/aac/aacdec_lpd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcod

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

2024-06-27 Thread Leo Izen
On 6/26/24 8:40 PM, Kacper Michajłow wrote: Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index

[FFmpeg-devel] [PATCH] avfilter/asubprocess: add audio subprocess filter

2024-06-27 Thread Stefan Westerfeld
This will send the audio stream to an external command as wav file and read back the output of the subprocess which is also supposed to be a wav file of the same format and length. === Examples: # filter mp3 audio file using sox to decrease volume: ffmpeg -i in.mp3 -af "asubprocess=sox --ignore-l

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-27 Thread Anton Khirnov
Quoting Ramiro Polla (2024-06-27 16:13:24) > On Tue, Jun 25, 2024 at 1:56 PM Ramiro Polla wrote: > > On Tue, Jun 25, 2024 at 11:19 AM Anton Khirnov wrote: > > > Quoting Ramiro Polla (2024-06-20 17:40:39) > > > > This commit adds support for V4L2's multiplanar API, but only when the > > > > number

Re: [FFmpeg-devel] [PATCH] libavcodec/mjpeg: keep last_dc value unclipped

2024-06-27 Thread Ramiro Polla
On Fri, Jun 7, 2024 at 10:10 PM Ramiro Polla wrote: > On Fri, Jun 7, 2024 at 9:35 PM Andreas Rheinhardt > wrote: > > Ramiro Polla: > > > Do av_clip_int16(val) _after_ copying the value to last_dc. > > > > > > Related commits: c28f648b19d and dffae122d0f > > > Related ticket: 4683 > > > --- > > >

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: add limited support for multiplanar API

2024-06-27 Thread Ramiro Polla
On Tue, Jun 25, 2024 at 1:56 PM Ramiro Polla wrote: > On Tue, Jun 25, 2024 at 11:19 AM Anton Khirnov wrote: > > Quoting Ramiro Polla (2024-06-20 17:40:39) > > > This commit adds support for V4L2's multiplanar API, but only when the > > > number of planes is 1. > > > > > > Adding full support for

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-27 Thread Ramiro Polla
On Tue, Jun 25, 2024 at 11:19 PM Ramiro Polla wrote: > On Thu, Jun 20, 2024 at 4:59 PM Ramiro Polla wrote: > > checkasm gets a little spammy with this commit by printing "No > > accelerated colorspace conversion found from %s to %s.\n" from > > libswscale/yuv2rgb.c multiple times. Any suggestions

[FFmpeg-devel] [PATCH 3/3] avformat/mov: set Stereo3D type when parsing eyes box

2024-06-27 Thread James Almer
If view is defined in the child stri box, then the type must be set to unspecified, as these boxes don't carry packing information. Also, don't attach a useless Stereo 3D side data if the stream is monoscopic. Signed-off-by: James Almer --- libavformat/mov.c | 10 +- 1 file changed, 9 in

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-27 Thread Nuo Mi
On Tue, Jun 25, 2024 at 8:36 PM Nuo Mi wrote: > > > On Mon, Jun 24, 2024 at 12:48 PM Zhao Zhili > wrote: > >> From: Zhao Zhili >> >> Before the patch, disable threads support at configure/build time >> was the only method to force zero thread in executor. However, >> it's common practice for li

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Always set flags for the current picture

2024-06-27 Thread Nuo Mi
On Mon, Jun 24, 2024 at 11:30 PM Frank Plowman wrote: > ff_vvc_frame_rpl uses the flags to detect whether a frame is in use. > Therefore, in the case of a CVSS AU (RASL/GDR with > NoOutputBeforeRecoveryFlag) with ph_non_ref_pic_flag = 1, the frame > would be freed before it is used. Fix this by

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Don't discard return codes

2024-06-27 Thread Nuo Mi
Merged. On Wed, Jun 26, 2024 at 1:06 AM Frank Plowman wrote: > Signed-off-by: Frank Plowman > --- > libavcodec/vvc/thread.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/vvc/thread.c b/libavcodec/vvc/thread.c > index c90c316661..118d56b67e 100644

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Validate IBC block vector

2024-06-27 Thread Nuo Mi
On Wed, Jun 26, 2024 at 1:04 AM Frank Plowman wrote: > From H.266 (V3) (09/2023) p. 321: > > It is a requirement of bitstream conformance that the luma block > vector bvL shall obey the following constraints: > - CtbSizeY is greater than or equal to > ((yCb + (bvL[ 1 ] >> 4)) & (CtbSizeY − 1)) +

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

2024-06-27 Thread Kacper Michajlow
On Thu, 27 Jun 2024 at 02:55, Andreas Rheinhardt wrote: > > Kacper Michajłow: > > Fixes use of uninitialized value, reported by MSAN. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavcodec/jpegxl_parser.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff -

Re: [FFmpeg-devel] [PATCH 2/2] configure: align conditional library deps assignments

2024-06-27 Thread Gyan Doshi
On 2024-06-25 11:51 am, Gyan Doshi wrote: On 2024-06-21 04:18 pm, Gyan Doshi wrote: ---   configure | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) Plan to improve commit messages and push set in 24h. Pushed as 27284b780087f9217f628a440e977f207b8b2885 and 9a3bc59a383d10ba414ae

[FFmpeg-devel] vulkan vp9

2024-06-27 Thread Daniel Oberhoff via ffmpeg-devel
Hello, Over at ladybird (the browser that forked off of the serenity os project) they are beginning to implement video playback based on ffmpeg. They are wondering also about gpu acceleration and wondering wether vulkan decode would be an option. The one thing missing though would be vp9 suppor

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_mux_init: make encoder_opts local to ost_add()

2024-06-27 Thread Anton Khirnov
It is no longer needed after this function returns. --- fftools/ffmpeg.h | 2 -- fftools/ffmpeg_mux.c | 1 - fftools/ffmpeg_mux_init.c | 71 ++- 3 files changed, 40 insertions(+), 34 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_mux_init: apply encoder options manually

2024-06-27 Thread Anton Khirnov
Do not pass an options dictionary to the avcodec_open2() in enc_open(). This is cleaner and more robust, as previously various bits of code would try to interpret the contents of the options dictionary, with varying degrees of correctness. Now they can just access the encoder AVCodecContext direct

[FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

2024-06-27 Thread Anton Khirnov
Share the code between encoding and decoding. Instead of checking every stream's options dictionary (which is also used for other purposes), track all used options in a dedicated dictionary. --- fftools/cmdutils.c| 17 fftools/cmdutils.h| 4 ++- fftools/ffmpeg.c

Re: [FFmpeg-devel] [PATCH 3/4] avformat/img2dec: ensure input padding is zeroed

2024-06-27 Thread Andreas Rheinhardt
Paul B Mahol: > On Thu, Jun 27, 2024 at 3:57 AM Kacper Michajłow wrote: > >> Fixes use of uninitialized value, reported by MSAN. Specifically in >> jpegxl parser. >> >> Found by OSS-Fuzz. >> >> Signed-off-by: Kacper Michajłow >> --- >> libavformat/img2dec.c | 2 ++ >> 1 file changed, 2 insertio

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: Fix compiling with MSVC 2022 17.8 and older

2024-06-27 Thread Frank Plowman
On 26/06/2024 09:20, Martin Storsjö wrote: > Versions of MSVC older than 17.9 error out here with the following > error: > > src/libavcodec/vvc/filter.c(815): error C2059: syntax error: '}' > src/libavcodec/vvc/filter.c(832): error C2065: 'all_zero_bs': undeclared > identifier > src/l

Re: [FFmpeg-devel] [RFC] patch for LTS release

2024-06-27 Thread Jean-Baptiste Kempf
Hello, On Thu, 27 Jun 2024, at 09:11, jfrederich via ffmpeg-devel wrote: > we have found a minor bug in dshow.c that we would like to submit as a > patch. Is it possible to submit a patch for 5.1.x LTS? Do I have to > consider anything special for this? Is it fixed in master already? -- Jean-

[FFmpeg-devel] [RFC] patch for LTS release

2024-06-27 Thread jfrederich via ffmpeg-devel
Hello, we have found a minor bug in dshow.c that we would like to submit as a patch. Is it possible to submit a patch for 5.1.x LTS? Do I have to consider anything special for this? Best regards Jens ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.