Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault

2023-01-29 Thread Anton Khirnov
Quoting Xiang, Haihao (2023-01-30 06:23:21) > From: Haihao Xiang > > This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 > > input_image is freed in vaapi_encode_wait() however it is still used in > commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 > > $ ffmpeg -vaapi_devic

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault

2023-01-29 Thread Xiang, Haihao
From: Haihao Xiang This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 input_image is freed in vaapi_encode_wait() however it is still used in commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 $ ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i testsrc -vf "format=nv12,h

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add a separate list for those with push access

2023-01-29 Thread Gyan Doshi
On 2023-01-30 09:14 am, Leo Izen wrote: On 1/29/23 18:14, Lynne wrote: Dec 18, 2022, 07:31 by [email protected]: Pushing this in 3 days unless anyone objects. ___ I recently gained push access. I don't object to this commit as-is, although if you

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add a separate list for those with push access

2023-01-29 Thread Leo Izen
On 1/29/23 18:14, Lynne wrote: Dec 18, 2022, 07:31 by [email protected]: Pushing this in 3 days unless anyone objects. ___ I recently gained push access. I don't object to this commit as-is, although if you can change it to include my name as well th

[FFmpeg-devel] [PATCH 3/3] lavfi/deinterlace_qsv: re-use VPPContext for deinterlace_qsv filter

2023-01-29 Thread Xiang, Haihao
From: Haihao Xiang QSVDeintContext and VPPContext have the same base context, and all features in deinterlace_qsv are implemented in vpp_qsv filter, so deinterlace_qsv can be taken as a special case of vpp_qsv filter, and we may use VPPContext with a different option array, preinit callback and

[FFmpeg-devel] [PATCH 2/3] lavfi/deinterlace_qsv: simplify deinterlace_qsv filter

2023-01-29 Thread Xiang, Haihao
From: Haihao Xiang Like what we did for scale_qsv filter, we use QSVVPPContext as a base context to manage MFX session for deinterlace_qsv filter. Signed-off-by: Haihao Xiang --- configure| 1 + libavfilter/vf_deinterlace_qsv.c | 505 ++- 2

[FFmpeg-devel] [PATCH 1/3] lavfi/vpp_qsv: add rate option

2023-01-29 Thread Xiang, Haihao
From: Haihao Xiang This is used to control the output at frame rate or field rate when deinterlace is expected and framerate is not specified. Signed-off-by: Haihao Xiang --- libavfilter/vf_vpp_qsv.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libavfi

Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2023-01-29 Thread Lynne
Jan 29, 2023, 10:57 by [email protected]: > Hi > > On Fri, Jan 27, 2023 at 01:03:00PM +0100, Dawid Kozinski/Multimedia (PLT) > /SRPOL/Staff Engineer/Samsung Electronics wrote: > >> Hi, >> It's been almost a month since we submitted our latest changes to the FFmpeg >> patchwork. I know that

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add a separate list for those with push access

2023-01-29 Thread Lynne
Dec 18, 2022, 07:31 by [email protected]: > Dec 16, 2022, 23:05 by [email protected]: > >> On Fri, Dec 16, 2022 at 12:26:58AM +0100, Lynne wrote: >> >>> Dec 15, 2022, 20:34 by [email protected]: >>> >>> > On Thu, Dec 15, 2022 at 02:13:49AM +0100, Lynne wrote: >>> > >>> >> This list is incomp

Re: [FFmpeg-devel] [PATCH] lavc: add null codecs

2023-01-29 Thread Paul B Mahol
On 1/27/23, Anton Khirnov wrote: > They discard all input without ever returning any output. Useful for > development. > --- > libavcodec/Makefile | 4 ++ > libavcodec/allcodecs.c | 6 +++ > libavcodec/codec_desc.c | 12 ++ > libavcodec/codec_id.h | 10 + > libavcodec/null.c

Re: [FFmpeg-devel] [PATCH] lavf/matroska: add support for ARIB captions

2023-01-29 Thread Andreas Rheinhardt
rcombs: > Not yet ready for merge, pending finalization of the standard proposal for > this mapping: > https://github.com/ietf-wg-cellar/matroska-specification/pull/724 > --- > libavformat/matroska.c| 1 + > libavformat/matroskadec.c | 30 ++ > libavformat/matrosk

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg: support input frame params in encoding stats

2023-01-29 Thread Anton Khirnov
--- doc/ffmpeg.texi | 17 fftools/ffmpeg.c | 54 --- fftools/ffmpeg.h | 6 + fftools/ffmpeg_mux_init.c | 21 +-- 4 files changed, 92 insertions(+), 6 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpe

[FFmpeg-devel] [PATCH 1/3] lavu/opt: use AV_DICT_MULTIKEY in av_opt_set_dict2()

2023-01-29 Thread Anton Khirnov
If the dictionary provided on input contains multiple entries for an option (relevant for flags modifying the previous value with '+' or '-') and the option is not found in the target object, only the last entry would be returned to the caller. Pass AV_DICT_MULTIKEY to av_dict_set() to make sure a

[FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: use correct IO context for -enc_stats_post

2023-01-29 Thread Anton Khirnov
--- fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 9884e0c6c6..3ad432ff54 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -803,7 +803,7 @@ static void update_video_stats(OutputStream *ost, const AVPacket *pkt,

[FFmpeg-devel] [PATCH] fftools/ffmpeg: fix clearing previous output

2023-01-29 Thread Paul B Mahol
Patch attached. From 95efe0d6d7e6fe5e29e6372f2da38cfbc4453a83 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 29 Jan 2023 20:46:50 +0100 Subject: [PATCH] fftools/ffmpeg: fix clearing previous output Signed-off-by: Paul B Mahol --- fftools/ffmpeg.c | 6 +- 1 file changed, 5 insertions

Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-29 Thread Dave Rice
> On Jan 20, 2023, at 10:17 AM, Tomas Härdin wrote: > > ons 2023-01-18 klockan 15:15 +0100 skrev Jerome Martinez: >> On 18/01/2023 14:40, Tomas Härdin wrote: >>> Creating a new subthread because I just noticed something >> >> I am a bit lost there because the line of code below is not part of

Re: [FFmpeg-devel] [PATCH 2/3] lavu/fifo: uninline deprecated av_fifo_peek2()

2023-01-29 Thread Andreas Rheinhardt
Anton Khirnov: > Will allow to mark AVFifoBuffer fields as deprecated without triggering > spurious warnings. > --- > libavutil/fifo.c | 10 ++ > libavutil/fifo.h | 10 +- > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/libavutil/fifo.c b/libavutil/fifo.c > in

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc.c -- correctly re-emit extradata ahead of IDR pictures

2023-01-29 Thread Marton Balint
On Fri, 27 Jan 2023, John Coiner wrote: From: John Coiner This is the proposed fix for https://trac.ffmpeg.org/ticket/10148 Very sorry to send the same patch 3 times; this time with `git send-email' so it should be legal :) --- libavformat/mpegtsenc.c | 18 +++--- 1 file chang

[FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-01-29 Thread Paul B Mahol
Patches attached From 5516601630ae83098e2a3d27823f21e86bc0e60d Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sat, 21 Jan 2023 19:25:41 +0100 Subject: [PATCH 1/2] avcodec: add WavArc decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + lib

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

2023-01-29 Thread Marton Balint
On Sun, 22 Jan 2023, Marton Balint wrote: On Wed, 28 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Nied

Re: [FFmpeg-devel] [PATCH 32/32] avutil/{color_utils, csp}: merge color_utils into csp and expose API

2023-01-29 Thread Anton Khirnov
Quoting Leo Izen (2023-01-28 14:58:18) > diff --git a/libavutil/csp.h b/libavutil/csp.h > index 18ef208adf..73bce52bc0 100644 > --- a/libavutil/csp.h > +++ b/libavutil/csp.h New public identifiers should still get an entry in doc/APIchanges, so users can check when they were added. -- Anton Khir

[FFmpeg-devel] [PATCH 2/3] lavu/fifo: uninline deprecated av_fifo_peek2()

2023-01-29 Thread Anton Khirnov
Will allow to mark AVFifoBuffer fields as deprecated without triggering spurious warnings. --- libavutil/fifo.c | 10 ++ libavutil/fifo.h | 10 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/libavutil/fifo.c b/libavutil/fifo.c index 51a5af6f39..5b114fc808 100644

[FFmpeg-devel] [PATCH 3/3] lavu/fifo: mark all AVFifoBuffer members as deprecated

2023-01-29 Thread Anton Khirnov
--- libavutil/fifo.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/fifo.h b/libavutil/fifo.h index ed86800da4..2e0c600dd3 100644 --- a/libavutil/fifo.h +++ b/libavutil/fifo.h @@ -242,8 +242,11 @@ void av_fifo_freep2(AVFifo **f); #if FF_API_FIFO_OLD_API typedef struct AVFifoB

[FFmpeg-devel] [PATCH 1/3] lavu/fifo: remove FF_API_FIFO_PEEK2

2023-01-29 Thread Anton Khirnov
It is a part of the deprecated FIFO API which will be removed in its entirety, so there is little point in having a separate guard for this function. --- libavutil/fifo.h| 2 -- libavutil/version.h | 1 - 2 files changed, 3 deletions(-) diff --git a/libavutil/fifo.h b/libavutil/fifo.h index 7

Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2023-01-29 Thread Michael Niedermayer
Hi On Fri, Jan 27, 2023 at 01:03:00PM +0100, Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics wrote: > Hi, > It's been almost a month since we submitted our latest changes to the FFmpeg > patchwork. I know that EVC implementation isn't the only thing you are > working o