Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: Add session support
..
sdk: Add session support
This change adds support for session cookies sent by the server
and for the "Prefer: persistent
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4044
To unsubscribe, visit http://ger
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 5:
Swapped the debug and persistent_auth parameters of the constructor.
Also applied the modifications to the generated c
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 4:
Added the missing persistent_auth parameter.
--
To view, visit http://gerrit.ovirt.org/4044
To unsubscribe, visit http
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 3:
Juan,
i see you using /persistent_auth/ var, but can't see you actually adding it to
API constructor.
entrypoint.
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 3: Verified
Added a "persistent_auth" parameter to the API constructor. The default value
is True. If changed to False th
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 2:
> I think that this feature shouldn't be exposed to the user at all. I think
> that the SDK should automatically us
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 2:
I think that this feature shouldn't be exposed to the user at all. I think that
the SDK should automatically use the s
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/4044
To unsubscribe, visit http
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 2:
Hi Juan,
nice piece of work!, but i have an issue with
exposer of this feature to user:
end-user doesn't have di
Eoghan Glynn has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 2: Looks good to me, but someone else must approve
Thanks for the quick turnaround on the review feedback.
Cheers,
Eoghan
Juan Hernandez has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 1: (4 inline comments)
Thanks for your revie Eoghan! I addressed most of your comments.
.
Eoghan Glynn has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
Hi Juan,
A couple of typos and stylistic nits inline.
C
Juan Hernandez has uploaded a new change for review.
Change subject: sdk: Add session support
..
sdk: Add session support
This change adds support for session cookies sent by the server
and for the "Prefer: persistent-auth" head
14 matches
Mail list logo
