oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8387/
: SU
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: cleanup CommonModel
..
webadmin: cleanup CommonModel
No logic changes. Just reordered the CommonModel class according to conventions.
Change-
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 3: Verified+1 Code-Review+2
Merging based on previous acks.
--
To view, visit http://gerrit.ovirt.org/19391
To unsub
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 3:
Rebased and updated NOTE comment.
--
To view, visit http://gerrit.ovirt.org/19391
To unsubscribe, visit http://ge
Greg Sheremeta has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 2:
should be changed to:
// NOTE: when adding a new ListModel here, be sure to add it to the list in
initItems()
-
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 2: Code-Review+2
I guess the comment "NOTE: when adding a new ListModel here, be sure to add it
to the listModelColle
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/8381/
: SU
Greg Sheremeta has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 2: Verified+1
rebased.
--
To view, visit http://gerrit.ovirt.org/19391
To unsubscribe, visit http://gerrit.ovirt.or
Einav Cohen has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1:
@Greg - please take care of the needed rebase. thanks.
--
To view, visit http://gerrit.ovirt.org/19391
To unsubscri
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1:
Patch http://gerrit.ovirt.org/#/c/19379/ just got merged,
CommonModel.listModelCollection field wasn't introduced
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19391
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alexander Wels has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19391
To unsubscribe, visit http://gerrit.ovirt.org/setti
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1: -Verified
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests_gerrit/1584/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests_gerrit/1581/ : FAILURE
--
Greg Sheremeta has posted comments on this change.
Change subject: webadmin: cleanup CommonModel
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Greg Sheremeta has uploaded a new change for review.
Change subject: webadmin: cleanup CommonModel
..
webadmin: cleanup CommonModel
No logic changes. Just reordered the CommonModel class according to conventions.
Change-Id: I38
16 matches
Mail list logo
