Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Messages
..
webadmin: Gluster Messages
also fixed small typo
Signed-off-by: Gilad Chaplik
Change-Id: I25bedd1c78d9a3b2d2de5e2ac2a2d0
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 9: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe
Yaniv Kaul has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 7: (1 inline comment)
File
frontend/webadmin/modules/frontend/src/main
Raksha Rao has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 7:
rebased and verified
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe, visit http://gerrit.ovirt.org/settin
Raksha Rao has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 6: No score
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Raksha Rao has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 5:
uploading the patch is not enough, you need to verify it also (and mark it in
gerrit)
--
To view, visit http://gerri
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 3:
remove the changes in .properties
the patch should only contain the *.java file
--
To view, visit http://gerrit.ovirt
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2:
please fix all the issues that Daniel have mentioned, except for the user
portal (but you still need to check that th
Daniel Erez has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2:
Since the messages are irrelevant the UserPortal, the values can be the same as
the WebAdmin.
--
To view, visit http:/
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2:
Daniel, right, but still, can she add default value instead?
--
To view, visit http://gerrit.ovirt.org/3904
To unsubs
Daniel Erez has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2:
Gilad, she *must* add it to the UserPortal...
Let me explain, every new key that is added to AppErrors.java interface *m
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2:
Raksha, have you verified your patch before sending it? (i.e. checking that
each of the messages works OK in the UI?)
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2: No score
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Daniel Erez has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2:
- Messages keys should not contain dot characters
(e.g. VALIDATION.GLUSTER.VOLUME.ID.NOT_NULL should be replaced with
V
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2: Looks good to me, approved
please rebase and verify
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe, vi
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Gluster Messages
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3904
To unsubscribe, visit
Raksha Rao has uploaded a new change for review.
Change subject: webadmin: Gluster Messages
..
webadmin: Gluster Messages
Change-Id: I25bedd1c78d9a3b2d2de5e2ac2a2d02f543c0b8f
---
M
frontend/webadmin/modules/frontend/src/main/ja
18 matches
Mail list logo
