oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/8480/ :
SUCCES
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 5:
* Update tracker::#1110444::OK
* Check TR::#1110444::ERROR, 3.5.1 should not match .*
--
To view, visit ht
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: bookmarks first try
..
webadmin: bookmarks first try
- Bookmarks are not working the very first time you try, if
you hadn't selected anythin
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4:
Merging based on previous acks.
--
To view, visit http://gerrit.ovirt.org/32434
To unsubscribe, visit http://gerr
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4: Verified+1 Code-Review+2
Verified per Alex's comment above on local environment.
Giving +2 review.
--
To view, v
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4:
Anyone can we get a review?
--
To view, visit http://gerrit.ovirt.org/32434
To unsubscribe, visit http://gerrit.
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4:
Things to make sure work:
1. The bookmarks work (which is the point of the patch).
2. When selecting an item in t
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4: Code-Review+1
Special thanks to Daniel for his assistance on this issue.
Giving +1 but it's basically +2 from my s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16417/ :
SUCCESS
h
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4: Verified+1
I see what you mean, I moved the reset code into the event handler that shows
the system tree when swi
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4:
Another review would be appreciated as this is marked regression in 3.5 and
thus blocking the release.
--
To vi
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 4:
* Update tracker::#1110444::OK
* Check Bug-Url::OK
* Check Public Bug::#1110444::OK, public bug
* Check Prod
Daniel Erez has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 3:
broken.. the bookmark isn't selected as it should. I.e. yellow background
(keyboard-selection) instead of blue backg
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 3:
I tried both FF and Chrome. When you say behaves as before, you mean its
broken, or behaves as first patch?
--
Daniel Erez has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 3:
Tried to verify on my env, seems to behave as before. Which browser did you
use? Verified in web mode?
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16023/ :
SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16024/ :
SUCCESS
h
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 3: Verified+1
Good call Daniel, it was exactly what you said it was. So I modified the patch
to simply defer applyin
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 3:
* Update tracker::#1110444::OK
* Check Bug-Url::OK
* Check Public Bug::#1110444::OK, public bug
* Check Prod
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 2:
* Update tracker::#1110444::OK
* Check Bug-Url::OK
* Check Public Bug::#1110444::OK, public bug
* Check Prod
Daniel Erez has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 1:
I guess it is caused due to the invocation of SystemTree's ResetCommand on
'CommonModel->bookmarkListModel_Navigated
Einav Cohen has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 1:
@Derez - any chance that you can review this? we would like to have another
opinion on this patch. thanks.
--
To v
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32434
To unsubscribe, visit http://gerrit.ovirt.org/settin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32349/
: S
Alexander Wels has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 1: Verified+1
Verified that now the bookmarks work on the first try, but the approach feels
hacky. However the whole
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: bookmarks first try
..
webadmin: bookmarks first try
- Bookmarks are not working the very first time you try, if
you hadn't selected anything in th
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: bookmarks first try
..
Patch Set 1:
* Update tracker::#1110444::OK
* Check Bug-Url::OK
* Check Public Bug::#1110444::OK, public bug
* Check Prod
27 matches
Mail list logo
