[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-30 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: engine: Unify Guid and NGuid .. engine: Unify Guid and NGuid Guid and NGuid are essentially the same class, where the only difference is the value retu

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-30 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 3: Verified; Looks good to me, approved Rebased, handled merge conflicts -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: (1 inline comment) File backend/manager/modules/compat/src/ma

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-26 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15691 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-26 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: i see that you addressed my comment in a separate patch [1], so ignore it here. [1] http://gerrit.ovirt.org/#/c

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-26 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) one comment after that ack. ...

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-20 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15691 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-16 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1275/ : SUCCESS -- To view

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-16 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15691 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 2: Verified Made corrections as per Tal's review (see also previous patch in the series). -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-15 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 1: (5 inline comments) Both Guid.createGuidFromString and NGuid.createGuidFromString do null checks - the difference

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-15 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 1: Looks good to me, but someone else must approve (8 inline comments) Minor comments, aside for that there are cases in t

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-14 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1192/ : SUCCESS -- To view

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-13 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Unify Guid and NGuid .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15691 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: engine: Unify Guid and NGuid

2013-06-13 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: engine: Unify Guid and NGuid .. engine: Unify Guid and NGuid Guid and NGuid are essentially the same class, where the only difference is the value returned fro