Muli Salem has submitted this change and it was merged.
Change subject: engine: Release Mac from Pool
..
engine: Release Mac from Pool
This patch makes sure the Mac address is
released from pool in case the Update/Add
VmInterfa
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10697
To unsubscribe, visit http://ger
Alona Kaplan has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 9: Looks good to me, but someone else must approve
+1 for frontend
--
To view, visit http://gerrit.ovirt.org/10697
To
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10697
To unsubscribe, visit http://gerrit.ovirt.
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 8:
After reviewing the error issue, it seems that VdsmErrors is the right place to
put the error messages.
--
To view,
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 8:
I don't think the vdsm errors properties file is the correct place for the
errors. Please move them to AppErrors.pro
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 6: (3 inline comments)
File
backend/manager/modules/bll/src/main/ja
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 6: (3 inline comments)
Basically the changes address the main issue.
See few comments inside.
.
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules/bll/src/main/ja
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules/bll/src/main/j
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main/jav
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 4: (1 inline comment)
What about the mac address committed to the pool in the can-do-action? How
would it be released?
Muli Salem has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/jav
Moti Asayag has posted comments on this change.
Change subject: engine: Release Mac from Pool
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Muli Salem has uploaded a new change for review.
Change subject: engine: Release Mac from Pool
..
engine: Release Mac from Pool
This patch makes sure the Mac address is
released from pool in case the Update/Add
VmInterfaceComman
15 matches
Mail list logo
