Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 14: (4 inline comments)
responses to Michael's comments inline.
SS, since this patch is already merged, you should s
Michael Kublin has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 14: (4 inline comments)
File
backend/manager/modules/bll/src/ma
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Delete Gluster Volume
..
engine: Delete Gluster Volume
Includes following related to the commands for "Delete Gluster Volume"
- New B
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 15: Verified
rebased and verified.
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 14: Verified
rebased and verified.
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt
Raksha Rao has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 13:
rebased and verified
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt.org/se
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 12:
Rebased with master
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt.org/
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 11:
Fixed the unresolved conflicts in
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
--
Ori Liel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 9: Looks good to me, but someone else must approve
+1 for REST-API
--
To view, visit http://gerrit.ovirt.org/3744
To unsub
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 8:
Removed entries from user portal AppErrors.properties and VdsmErrors.properties
files.
--
To view, visit http://g
Gilad Chaplik has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 7:
Please avoid adding Strings to user portal AppErrors.properties - because you
don't use/check. refer to http://ger
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 7: Looks good to me, but someone else must approve
need ui and api ack as well
--
To view, visit http://gerrit.ovirt.o
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, vis
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 7:
Added the entires in AppError.java and VdsmErrors.java.
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscr
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 6:
Entries in AppErrors.java and VdsmErrors.java (frontend project) are still
missing.
--
To view, visit http://ger
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 6:
Added Entries in the user portal properties files.
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe,
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 5: No score
Entries in AppErrors.java and VdsmErrors.java (frontend project) missing.
Looks like my comment on patch
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, vis
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3: No score
No need to change sources in the "userportal" project, even though the wiki
page mentions it. The Gluste
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
well it looks good to me but since this patch include also rest and u
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
.
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3: (2 inline comments)
looks ok, some minor comments
File
backen
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3:
Reverted the "delete gluster volume" changes from insert_predefined_roles.sql,
Enums.java and Enums.properties.
I
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 2: (1 inline comment)
in addition to Shireesh comments,
missing also translation for can do action message (in apperror
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 2:
1. insert_predefined_roles.sql must not be modified. Move all gluster related
roles to a new upgrade script
2. L
Selvasundaram has uploaded a new change for review.
Change subject: engine: Delete Gluster Volume
..
engine: Delete Gluster Volume
Includes following related to the commands for "Delete Gluster Volume"
- New BLL Acti
29 matches
Mail list logo
