[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-19 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 5: Verified; Looks good to me, approved Merging based on previous acks. -- To view, visit http://gerrit.ovirt.org/15827

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-19 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: doc: developer: gwt fixups .. doc: developer: gwt fixups Change-Id: I4aae2c5866a226d86acfb83415a52ef4b380d222 Signed-off-by: Alon Bar-Lev --- M README.

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-19 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 4: OK, going to merge this. -- To view, visit http://gerrit.ovirt.org/15827 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-19 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 5: Rebased (no changes since last time). -- To view, visit http://gerrit.ovirt.org/15827 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 4: Vojtech you can merge this. -- To view, visit http://gerrit.ovirt.org/15827 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/15827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has restored this change. Change subject: doc: developer: gwt fixups .. Patch Set 1: Restored sorry... I was confused between workers and draft. -- To view, visit http://gerrit.ovirt.org/15827 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has abandoned this change. Change subject: doc: developer: gwt fixups .. Patch Set 1: Abandoned Obsolete by: http://gerrit.ovirt.org/#/c/15849/ http://gerrit.ovirt.org/#/c/15736/ -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 1: > Hm, maybe we should move "gwt.userAgent" property to root pom.xml for easier > reference? This will be great. --

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 1: Hm, maybe we should move "gwt.userAgent" property to root pom.xml for easier reference? -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 1: +2 looks good to me. Suggestion: make note for EXTRA_BUILD_FLAGS_DEV_GWT that all supported user agent values (targe

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: developer: gwt fixups .. Patch Set 1: I would prefer that you didn't submit this do not merge yet, will conflict with pending patch queue. -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: doc: developer: gwt fixups

2013-06-18 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: doc: developer: gwt fixups .. doc: developer: gwt fixups Change-Id: I4aae2c5866a226d86acfb83415a52ef4b380d222 Signed-off-by: Alon Bar-Lev --- M README.developer