[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-03 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 2: Verified; Looks good to me, approved Acked by ofrenkel -- To view, visit http://gerrit.ovirt.org/16274 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-03 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: remove auto suspend of VM. .. core: remove auto suspend of VM. Auto suspend is a feature which is no longer being used, therefore should be deleted

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-03 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: Looks good to me, approved please verify -- To view, visit http://gerrit.ovirt.org/16274 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-03 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16274 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-02 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: I think it is a matter of style. While each patch keeps the environment consistence there is no obligation to do

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: In my opinion when you remove a feature you should remove all the parts at once, there is not much sense in removin

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: @Tal other patch already handles it http://gerrit.ovirt.org/#/c/16275/ This part mainly remove it from the dal la

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/16274 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: Also in HibernateVmParameters remove the getter & setter of privateAutomaticSuspend -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: I would prefer that you didn't submit this You still have values in AuditLogType AUTO_SUSPEND_VM, AUTO_SUSPEND_VM_F

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16274 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: Looks good to me, but someone else must approve finally! thanks! please verify with dwh this change is ok -- To

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-07-01 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: remove auto suspend of VM. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/2876/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: core: remove auto suspend of VM.

2013-06-30 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: remove auto suspend of VM. .. core: remove auto suspend of VM. Auto suspend is a feature which is no longer being used, therefore should be deleted. Signe