Alissa Bonas has abandoned this change.
Change subject: core: remove unused methods in several bll classes
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/21944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 5:
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12844/
: SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/3599/
: SUCCES
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove unused methods
..
core: remove unused methods
Remove unused methods in RunVmCommand
Change-Id: Iabe99ebc6ce6cca069f9333ac3d0b4117f3dfd3b
Si
Omer Frenkel has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 5: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.or
Omer Frenkel has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12816/
: SUC
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 3: Code-Review+1
Omer/Roy, any reason not to merge this?
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12645/
: SUC
Arik Hadas has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove unused methods in several bll classes
..
Patch Set 1:
(1 comment)
File
backend/manager/modul
Ravi Nori has posted comments on this change.
Change subject: core: remove unused methods in several bll classes
..
Patch Set 1:
(2 comments)
File
backend/manager/modules/b
Arik Hadas has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/setting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/1006/ :
SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/993/ : SUCCESS
Arik Hadas has posted comments on this change.
Change subject: core: remove unused methods
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Arik Hadas has uploaded a new change for review.
Change subject: core: remove unused methods
..
core: remove unused methods
Remove unused methods in RunVmCommand
Change-Id: Iabe99ebc6ce6cca069f9333ac3d0b4117f3dfd3b
Signed-off-b
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused methods in several bll classes
..
Patch Set 1: Code-Review-1
(1 comment)
Seems Omer is correct. @Alissa - please verify.
Also, I'd conside
Itamar Heim has posted comments on this change.
Change subject: core: remove unused methods in several bll classes
..
Patch Set 1:
can you find where/how they are used?
--
To view, visit http://gerrit.ovirt.org/21944
To unsub
Omer Frenkel has posted comments on this change.
Change subject: core: remove unused methods in several bll classes
..
Patch Set 1:
(1 comment)
not sure about the commandBase methods, iirc, these are part of the async tasks
i
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods in several bll classes
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit
Alissa Bonas has uploaded a new change for review.
Change subject: core: remove unused methods in several bll classes
..
core: remove unused methods in several bll classes
Change-Id: Ied79a5d374b0834b335bfe6b5acfea984c7ee222
Sig
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/40
Moti Asayag has submitted this change and it was merged.
Change subject: core: remove unused methods in IPAddress
..
core: remove unused methods in IPAddress
Change-Id: I12ee6018dd651a396e884f79bfba9230119b4ac2
Signed-off-by: A
Moti Asayag has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21020
To unsubscribe, visit http://ger
Alissa Bonas has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21020
To unsubscribe, visit http://gerrit.ovirt.org
Moti Asayag has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21020
To unsubscribe, visit http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/
Alissa Bonas has posted comments on this change.
Change subject: core: remove unused methods in IPAddress
..
Patch Set 2:
addressed comments, instead of renaming, just removed the methods.
--
To view, visit http://gerrit.ovir
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused methods from UserCommandBase
..
core: Remove unused methods from UserCommandBase
Removed ProcessAdElementDefaultRole(Guid, String)
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused methods from UserCommandBase
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused methods from UserCommandBase
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/18870
Tal Nisan has posted comments on this change.
Change subject: core: Remove unused methods from UserCommandBase
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18870
To unsubscribe, visit http://gerrit.o
Omer Frenkel has posted comments on this change.
Change subject: core: Remove unused methods from UserCommandBase
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18870
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused methods from UserCommandBase
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18870
To unsubscribe, visit http://gerrit
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove unused methods from UserCommandBase
..
core: Remove unused methods from UserCommandBase
Removed ProcessAdElementDefaultRole(Guid, String) and
CanA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
core: Remove Unused methods from VdsFenceOptions
Removed the unused methods getFencingAgentInstance
Allon Mureinik has posted comments on this change.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/16818
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16818
To unsubscribe, vis
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16818
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
core: Remove Unused methods from VdsFenceOptions
Removed the unused methods getFencingAgentInstanceOptionsM
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle
Allon Mureinik has posted comments on this change.
Change subject: core: Remove Unused methods from VdsFenceOptions
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/16818
To unsubscribe, visit http://gerrit.o
47 matches
Mail list logo
