[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 9: (3 inline comments) File backend/manager/modules/bll/src/main/java/

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-22 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 9: (4 inline comments) Partial review File backend/manager/modules/bll/s

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-22 Thread gchaplik
Gilad Chaplik has abandoned this change. Change subject: core: refactoring quota .. Patch Set 8: Abandoned already merged in http://gerrit.ovirt.org/#/c/6315/ -- To view, visit http://gerrit.ovirt.org/6301 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-22 Thread gchaplik
Gilad Chaplik has abandoned this change. Change subject: core: refactoring quota CRUD commands .. Patch Set 8: Abandoned already merged in http://gerrit.ovirt.org/#/c/6315/ -- To view, visit http://gerrit.ovirt.org/6302 To uns

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-22 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: core: refactoring quota .. core: refactoring quota this patch is a combination of 8 patches, that are pushed together because there're dependent on each

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 9: Verified; Looks good to me, approved rebased & verified -- To view, visit http://gerrit.ovirt.org/6315 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: refactoring quota CRUD commands .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6302 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6301 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-21 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: refactoring quota CRUD commands .. Patch Set 3: (12 inline comments) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-21 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 3: (14 inline comments) File backend/manager/modules/bll/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: refactoring quota CRUD commands .. Patch Set 3: No score -- To view, visit http://gerrit.ovirt.org/6302 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 3: (1 inline comment) Added discussion we had over the phone - please rebase and fix it. .

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-19 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: refactoring quota CRUD commands .. Patch Set 3: (2 inline comments) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: refactoring quota CRUD commands .. Patch Set 3: I would prefer that you didn't submit this (10 inline comments) like the idea, have some queries/comments

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 3: Fails; I would prefer that you didn't submit this (16 inline comments) See comments inline. Also, this patch is incomp

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: refactoring quota .. Patch Set 1: I would prefer that you didn't submit this (5 inline comments) Fil

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota

2012-07-16 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: refactoring quota .. core: refactoring quota currently the quota is handled through static methods, involving db and cache. adding an inteface to handle q

[Engine-patches] Change in ovirt-engine[master]: core: refactoring quota CRUD commands

2012-07-16 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: refactoring quota CRUD commands .. core: refactoring quota CRUD commands add, remove & update quota commands should inherit abstract command class, withou