[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-22 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: Roles commands cleanup .. core: Roles commands cleanup 1. Replaced ArrayList declarations with List declarations where possible. 2. Replaced DbF

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-22 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 11: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 11: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 10: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 9: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 8: Looks good to me, but someone else must approve rebased, no changes since last +2 review. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 7: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-21 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 6: Verified; Looks good to me, but someone else must approve Fixed typo noted by emesika. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-20 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 5: Looks good to me, approved (1 inline comment) only fix typo in comment, see comment inside ..

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-20 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 4: Verified additional cleanup in the way daos are used. -- To view, visit http://gerrit.ovirt.org/4482 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 3: Verified rebased -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 2: Verified rebase,no changes since last patchset. -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-16 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Roles commands cleanup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4482 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: core: Roles commands cleanup

2012-05-16 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Roles commands cleanup .. core: Roles commands cleanup 1. Replaced ArrayList declarations with List declarations where possible. 2. Replaced DbFacade.