Juan Hernandez has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 5:
Rebased.
--
To view, visit http://gerrit.ovirt.org/4968
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Vojtech Szocs has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4968
To unsubscribe, visit http://ger
Vojtech Szocs has submitted this change and it was merged.
Change subject: core: Remove ovirtengine.war
..
core: Remove ovirtengine.war
Despite the apparently important name this is not used at all, so
it can be safely removed.
Vojtech Szocs has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4968
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 4:
I verified this again building the packages, installing, running engine-setup
and adding a host.
--
To view, visi
Juan Hernandez has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
Looks *very* good to me.
--
To view, visit http://gerrit
Einav Cohen has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
rebased, verified the bahavior on devel env.
--
To view, vi
Vojtech Szocs has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 3: Looks good to me, but someone else must approve
Juan, you can remove the legacy UserPortal reference in ear/pom.xml.
Juan Hernandez has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 3:
Vojtech, I remember that you didn't want to remove yet references from the
legacy user portal from the POMs. Is it
Itamar Heim has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 1:
just a btw - unless strictly related, additional cleanups can be done in
additional patches (submitters decree), but
Doron Fediuck has posted comments on this change.
Change subject: core: Remove ovirtengine.war
..
Patch Set 1: (1 inline comment)
Hey,
looks like there are a few more bits you can remove (while at it).
See inside.
...
Juan Hernandez has uploaded a new change for review.
Change subject: core: Remove ovirtengine.war
..
core: Remove ovirtengine.war
Despite the apparently important name this is not used at all, so
it can be safely removed.
Chang
12 matches
Mail list logo
