Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 4: Verified; Looks good to me, approved
Fixed commit message as per review, no code changed.
--
To view, visit http://g
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove DiskImageList
..
core: Remove DiskImageList
Removed DiskImageList - it is nothing more than a container for
DiskImage[], and there is no r
Michael Pasternak has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: (1 inline comment)
Pending Michael's review.
Will fix the typo when I rebase.
..
Tal Nisan has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
Commit Message
Line 6:
Daniel Erez has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit ht
Vered Volansky has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2:
@Liron - re DiskImageList in a params class - can't find any usage for it,
should be OK
--
To view, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Alissa Bonas has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit h
Liron Ar has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: No score
correction - bad wording, we need to make sure that it's not set somewhere to
parameters, as it would be serializ
Liron Ar has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Partially reviewed all of the classes - Wouldn't the images
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 2:
Renamed "list" to "images" in ImportVmTemplateCommand.canDoAction(), as per
Vered's review
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Vered Volansky has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove DiskImageList
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove DiskImageList
..
core: Remove DiskImageList
Removed DiskImageList - it is nothing more than a container to an array
of DiskImageList, and there is
19 matches
Mail list logo
