[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-07-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-07-15 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22283 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-07-15 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix potential NPE .. core: Fix potential NPE Fix a potential NPE around setting task status. This issue was reported by coverity Change-Id: I9f82f

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-07-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-07-14 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: it seems crazy to abandon this - why not followed through on? -- To view, visit http://gerrit.ovirt.org/22283 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-06-23 Thread iheim
Itamar Heim has abandoned this change. Change subject: core: Fix potential NPE .. Abandoned no activity, restore if relevant -- To view, visit http://gerrit.ovirt.org/22282 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-06-23 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/22282 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-05-19 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/22283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-04-28 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: ping -- To view, visit http://gerrit.ovirt.org/22282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2014-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix potential NPE at VmDeviceUtils .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/19515 To u

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2014-03-17 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: core: fix potential NPE at VmDeviceUtils .. Abandoned -- To view, visit http://gerrit.ovirt.org/19515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Mes

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2014-03-17 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: fix potential NPE at VmDeviceUtils .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/19515 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-03-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/3875/ : SUCCESS http://jenk

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-03-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Check

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-03-16 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Code-Review+1 right handling for setting taskResult value. it won't change anything currently, but will help to avoid N

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-03-11 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Yaniv, what do you think about this one, I would like to hear your opinion as well. -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-03-10 Thread iheim
Itamar Heim has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/22283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2014-01-07 Thread Gustavo Frederico Temple Pedrosa
Gustavo Frederico Temple Pedrosa has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22283 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/13054/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22282 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12724/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: core: Fix potential NPE .. Abandoned Already solved by Ramesh -- To view, visit http://gerrit.ovirt.org/22281 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12721/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12723/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12725/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/12722/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix potential NPE .. core: Fix potential NPE This defect was reported by coverity Change-Id: I5b49cf88d71217afd9c78e6a7103194b83915e7a Signed-off-by: Ya

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix potential NPE .. core: Fix potential NPE Thie defect was reported by Coverity Change-Id: I6fdb4c5991be781c05c05e92e74bac19c0382bb9 Signed-off-by: Ya

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE

2013-12-11 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix potential NPE .. core: Fix potential NPE Fix a potential NPE around setting task status. This issue was reported by coverity Change-Id: I9f82f6d4aeb

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2013-11-04 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: fix potential NPE at VmDeviceUtils .. Patch Set 1: A balloon device is relevant for templates as well, so this fix is probably not the right implementatio

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2013-10-31 Thread Gustavo Frederico Temple Pedrosa
Gustavo Frederico Temple Pedrosa has posted comments on this change. Change subject: core: fix potential NPE at VmDeviceUtils .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19515 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2013-09-24 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix potential NPE at VmDeviceUtils .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: core: fix potential NPE at VmDeviceUtils

2013-09-24 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: fix potential NPE at VmDeviceUtils .. core: fix potential NPE at VmDeviceUtils Change-Id: I6020055934913fc92829dd99dadbefd6fc3a0c05 Signed-off-by: Yair Z

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk (#850795)

2012-08-23 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix potential NPE when adding LUN disk (#850795) .. core: Fix potential NPE when adding LUN disk (#850795) https://bugzilla.redhat.com/show_bug.cgi

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk (#850795)

2012-08-23 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk (#850795) .. Patch Set 4: Verified; Looks good to me, approved Acked by derez -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-23 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 2: Looks good to me, approved Please remove redundant extra lines on rebase. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-23 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/7362 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-23 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7362 To u

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-23 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 1: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-21 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 1: (3 inline comments) File backend/manager/module

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_engine_gwt_admin/458/ : SUCCESS http:/

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 1: I would prefer that you didn't submit this (5 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-21 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Fix potential NPE when adding LUN disk .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/73

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk

2012-08-20 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Fix potential NPE when adding LUN disk .. core: Fix potential NPE when adding LUN disk Since LUN disk is not part of storage pool, validation of shareable

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in RemoveBondCommand

2012-03-22 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Fix potential NPE in RemoveBondCommand .. core: Fix potential NPE in RemoveBondCommand The patch fixes 2 findbugs errors about potentials NPE. Chan

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in RemoveBondCommand

2012-03-22 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Fix potential NPE in RemoveBondCommand .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2907 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in RemoveBondCommand

2012-03-22 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Fix potential NPE in RemoveBondCommand .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2907 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in RemoveBondCommand

2012-03-20 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Fix potential NPE in RemoveBondCommand .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2907 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in RemoveBondCommand

2012-03-18 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: core: Fix potential NPE in RemoveBondCommand .. core: Fix potential NPE in RemoveBondCommand The patch fixes 2 findbugs errors about potentials NPE. Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in ExportVmCommand

2012-03-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Fix potential NPE in ExportVmCommand .. Patch Set 3: (1 inline comment) File backend/manager/modules/bl

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in ExportVmCommand

2012-03-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Fix potential NPE in ExportVmCommand .. Patch Set 2: added some more 'cosmetics' -- To view, visit http://gerrit.ovirt.org/2436 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in ExportVmCommand

2012-02-29 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix potential NPE in ExportVmCommand .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2436 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Fix potential NPE in ExportVmCommand

2012-02-29 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: core: Fix potential NPE in ExportVmCommand .. core: Fix potential NPE in ExportVmCommand The vm.getInterfaces() is being referenced after it was verified to be nu