[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-10-10 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: Extracted VmValidator .. core: Extracted VmValidator Extracted several VM validation utils from CreateAllSnapshotsFromVmCommand to a VmValidator class

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-10-10 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 9: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8101 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-10-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/8101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerr

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-10-10 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8101 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-30 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 6: (1 inline comment) File backend/manager/modules/bll/src/main/j

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-30 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 6: (2 inline comments) File backend/manager/modules/bll/src/main/java

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 4: CDI patch - http://gerrit.ovirt.org/#/c/5575/ -- To view, visit http://gerrit.ovirt.org/8101 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 4: Verified The initial thought was to keep the same design as SnapshotValidator - then, when we introduce a better wa

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 4: I rather have that then static methods. the best solution is to have this validator injected to the command instance. be

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-25 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 4: can't we make this method static and have private ctor in order to avoid creating instances of VmValidator? this clas

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-24 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 4: Looks good to me, approved look ok - except that this ValidationResult is a useless wrapper to VdcBllMessage. we can act

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-20 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Extracted VmValidator .. core: Extracted VmValidator Extracted several VM validation utils from CreateAllSnapshotsFromVmCommand to a VmValidator class (s