Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 3:
Yaniv, I agree with your comment on the name VersionUtils.
I will fix that
Version will continue to exist, we need it
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 3:
Yair, I prefer seeing copies of whatever you need from Version class instead of
having two version utils. Now you ho
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 3:
Please correct if I am wrong but looks like it will return 1 for the same
hostOs and Iso and for cases w
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/6991/
: SUCCE
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
Yaniv, for example - look at Vds.getPartialVersion...
Look at VdsUpdadeRuntimeInfo -
if ((stat.getMemFree() < minAv
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
I dont think so, RpmVersion abuses the following methods from Version -
compareTo, the getters, etc..
Barak and I do
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
Just remove the Version inheritance. only setValue is relevant. it looks quite
simple
--
To view, visit http://ger
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
Move compat/RpmVersion.java to /common/utils/... and merge the two. I don't see
any complication in that
--
To vie
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
Yaniv, you are right, this is technical issue that we have.
For some reason (I don't mind asking on engine-devel) com
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
how does it depend on http://gerrit.ovirt.org/#/c/18369?
wouldn't it be more useful to share RpmVersion as a common
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/6930/
: SUCCE
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding Version utils
..
core: Adding Version utils
Adding a utility class to serve Version issues
both at backend and frontend
Change-Id: Ia82d09e755b76
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/6882/
: SUCCE
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding Version utils
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18370
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
14 matches
Mail list logo
