[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule: Use @ClassRule

2012-12-04 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core: MockEJBStrategyRule: Use @ClassRule .. core: MockEJBStrategyRule: Use @ClassRule Use @ClassRule instead of @Rule for MockEJBStrategyRule wherever

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule: Use @ClassRule

2012-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule: Use @ClassRule .. Patch Set 2: Verified; Looks good to me, approved Rebased. +2 by Laszlo. -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule JUnit 4.10 upgrade

2012-12-04 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core: MockEJBStrategyRule JUnit 4.10 upgrade .. core: MockEJBStrategyRule JUnit 4.10 upgrade Extended TestWatcher instead of the deprecated TestWatchma

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule JUnit 4.10 upgrade

2012-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule JUnit 4.10 upgrade .. Patch Set 2: Verified; Looks good to me, approved Rebased. +2 by Laszlo, +1 by Sharad. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule JUnit 4.10 upgrade

2012-12-04 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: MockEJBStrategyRule JUnit 4.10 upgrade .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9712 To un

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule: Use @ClassRule

2012-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule: Use @ClassRule .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9715 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule JUnit 4.10 upgrade

2012-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule JUnit 4.10 upgrade .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9712 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule: Use @ClassRule

2012-12-04 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: MockEJBStrategyRule: Use @ClassRule .. core: MockEJBStrategyRule: Use @ClassRule Use @ClassRule instead of @Rule for MockEJBStrategyRule wherever possibl

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule JUnit 4.10 upgrade

2012-12-04 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: MockEJBStrategyRule JUnit 4.10 upgrade .. core: MockEJBStrategyRule JUnit 4.10 upgrade Extended TestWatcher instead of the deprecated TestWatchman. Chan

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-25 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: core: MockEJBStrategyRule .. core: MockEJBStrategyRule Introducing MockEJBStrategyRule to provide an easy and straight forward way to mock EJBs and res

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 2: Looks good to me, approved Approval based on lhornyak's +2 in previous patch-set (rebased, no code changes). mkublin

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 2: Verified mkublin, thanks a lot for the input in previous revisions. The patch series was restructured so now this pat

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 1: Looks good to me, approved As new patch with clean is on the way, I remove a -1. At any case a patch was ok from the b

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 1: mkublin - the entire point of itsest is to run with embedded JBoss (instead of mocking stuff). IMHO - it's all dead

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 1: Now we have three overrides of EjbUtils , and two of them for tests? And we really need JBOSS embedded for itest? --

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 1: mkublin - JBossEmbeddedEJBUtilsStrategy is used for running itests against a real embedded JBoss intanse, which I di

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-21 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 1: I would prefer that you didn't submit this Missing patch, change that clean old implementation - JBossEmbeddedEJBUti

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: MockEJBStrategyRule .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/9401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: MockEJBStrategyRule

2012-11-21 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: MockEJBStrategyRule .. core: MockEJBStrategyRule Introducing MockEJBStrategyRule to provide an easy and straight forward way to mock EJBs and resources i