Yaniv Bronhaim has posted comments on this change.
Change subject: packaging: setup: centralized manualSetupDispatcher code
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/41399
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 14:
this code was tried and worked at least as I expect... if one of you can check
it as well it would be g
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 13: Verified+1
just fixed output print in last ps
--
To view, visit https://gerrit.ovirt.org/41399
To unsu
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/41399
To unsubscribe, visit https://gerrit.ovirt.
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/41399/10/src/ovirt_hosted_engine_setup/check_liveliness.py
Fi
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/41399
To unsubscribe, visit https://gerrit.ovirt.o
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 8:
what version of pep8 is it?! since when it shouts on 80 chars exactly?
--
To view, visit https://gerrit
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: add consoleAddress to migration command params
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41222
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: centralized manualSetupDispatcher code
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41399/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.p
Yaniv Bronhaim has uploaded a new change for review.
Change subject: centralized manualSetupDispatcher code
..
centralized manualSetupDispatcher code
The list of options to manipulate the engine vm is relevant in many parts of
t
Yaniv Bronhaim has posted comments on this change.
Change subject: monitor: implement NUMA aware KSM policy
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40130
To unsubscribe, visit https://gerrit.ov
Yaniv Bronhaim has abandoned this change.
Change subject: Allow changing ssh port in EditHost Form
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/35103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
Yaniv Bronhaim has posted comments on this change.
Change subject: monitor: implement NUMA aware KSM policy
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40130/5/mom/Collectors/HostKSM.py
File mom/Collectors/HostKSM
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Extends vds_dynamic with updates_available
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39862
To unsubscribe, visit https:/
Yaniv Bronhaim has posted comments on this change.
Change subject: monitor: implement NUMA aware KSM policy
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/40130/2/mom/Collectors/HostKSM.py
File mom/Collectors/HostKS
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove build over el6 for master branch
..
Patch Set 2: Workflow+1
--
To view, visit https://gerrit.ovirt.org/40071
To unsubscribe, visit https://gerrit.ovirt.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove build over el6 for master branch
..
Remove build over el6 for master branch
master is currently ovirt-3.6 code which is not supported over el6 anymore.
Yaniv Bronhaim has posted comments on this change.
Change subject: webadmin: "Advanced Parameters" panel disappear when choosing
to use hosts provider
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/3
Yaniv Bronhaim has posted comments on this change.
Change subject: Add PPC64 arch to ioprocess job
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39843/2/jobs/confs/yaml/jobs/ioprocess/ioprocess_create-rpms.yaml
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Add PPC64 arch to ioprocess job
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39843/2/jobs/confs/yaml/jobs/ioprocess/ioprocess_create-rpms.yaml
File
Yaniv Bronhaim has posted comments on this change.
Change subject: core: set cluster for host registration if null
..
Patch Set 4: Code-Review+1
just verify the output when the id in the config not exist
--
To view, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: core: set cluster for host registration if null
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/37842/3/backend/manager/modules/bll/src/main/java/org/
Yaniv Bronhaim has posted comments on this change.
Change subject: core: set cluster for host registration if null
..
Patch Set 3:
(1 comment)
need to add verification that the id in AutoRegistrationDefaultVdsGroupID is
valid
Yaniv Bronhaim has posted comments on this change.
Change subject: core: set cluster for host registration if null
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37842/3/backend/manager/modules/bll/src/
Yaniv Bronhaim has abandoned this change.
Change subject: Fix for HandleVdsVersionCommand - lowest pariority to cluster
version
..
Abandoned
keeping the old logic - and use http://gerrit.ovirt.org/#/c/37384/
--
To view, visi
Yaniv Bronhaim has posted comments on this change.
Change subject: core: set cluster for host registration if null
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/37842/2/backend/manager/modules/bll/src/
Yaniv Bronhaim has posted comments on this change.
Change subject: core: set cluster for host registration if null
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/37842/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9:
Yaniv Bronhaim has posted comments on this change.
Change subject: core: fix auto registration default cluster id
..
Patch Set 2: Code-Review+1
i assume default always exists when running the upgrade scripts
--
To view, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fix for HandleVdsVersionCommand - lowest pariority to cluster
version
..
Fix for HandleVdsVersionCommand - lowest pariority to cluster version
The meaning of
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Introduce UpdateHostValidator
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37469
To unsubscribe, visit http://gerrit.ovirt.o
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Introduce UpdateHostValidator
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/37469/3/backend/manager/modules/bll/src/main/java/org/ovirt/engi
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Extract repetitive method call into variable
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37468
To unsubscribe, visit http:/
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Replace endless method with early quit
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37467
To unsubscribe, visit http://gerri
Yaniv Bronhaim has posted comments on this change.
Change subject: Due to commit a276f142 foreman id is not provided in vds static
table
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37113
To unsubscrib
Yaniv Bronhaim has posted comments on this change.
Change subject: Due to commit a276f142 foreman id is not provided in vds static
table
..
Patch Set 1: -Verified
--
To view, visit http://gerrit.ovirt.org/37113
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: Due to commit a276f142 foreman id is not provided in vds static
table
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37113
To unsubscrib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Due to commit a276f142 foreman id is not provided in vds static
table
..
Due to commit a276f142 foreman id is not provided in vds static table
By Changing the
Yaniv Bronhaim has posted comments on this change.
Change subject: Due to commit a276f142 foreman id is not provided in vds static
table
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37108
To unsubscrib
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Due to commit a276f142 foreman id is not provided in vds static
table
..
Due to commit a276f142 foreman id is not provided in vds static table
By Changing the
Yaniv Bronhaim has posted comments on this change.
Change subject: restapi: Option to override firewall during install
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36856
To unsubscribe, visit http://
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Engine 3.6 should accept vdsm 4.17
..
Engine 3.6 should accept vdsm 4.17
Following changes in http://gerrit.ovirt.org/#/c/36518/
Change-Id: I53c0ddd4ee1db
Yaniv Bronhaim has posted comments on this change.
Change subject: Override firewall configurations on deploy for provisioned hosts
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/36632
To unsubscribe, vis
Yaniv Bronhaim has posted comments on this change.
Change subject: Override firewall configurations on deploy for provisioned hosts
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/36634
To unsubscribe, vis
Yaniv Bronhaim has posted comments on this change.
Change subject: Update only name and address fields when picking foreman
parameters
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/36631
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Update only name and address fields when picking foreman
parameters
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/36550
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Update only name and address fields when picking foreman
parameters
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/36550
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Update only name and address fields when picking foreman
parameters
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/36550/4/frontend/webadmin/modules/
Yaniv Bronhaim has posted comments on this change.
Change subject: Update only name and address fields when picking foreman
parameters
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/36550
To unsubscribe,
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Override firewall configurations on deploy for provisioned hosts
..
Override firewall configurations on deploy for provisioned hosts
Currently we don't have pa
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Override firewall configurations on deploy for provisioned hosts
..
Override firewall configurations on deploy for provisioned hosts
Currently we don't have pa
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Enable json rpc based on cluster level when deploying foreman's
hosts
..
Enable json rpc based on cluster level when deploying foreman's hosts
Reusing hostMod
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Enable json rpc based on cluster level when deploying foreman's
hosts
..
Enable json rpc based on cluster level when deploying foreman's hosts
Better to reuse
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoid updating fields when uneccessary
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/36159
To unsubscribe, visit http://gerrit.ovirt.org
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Avoid using constants in model
..
Avoid using constants in model
Change-Id: I17e9a9936de5912dcd8d37aab33bb4da5659d724
Signed-off-by: Yaniv Bronhaim
---
M
fro
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoid updating fields when uneccessary
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/36159/2/frontend/webadmin/modules/uicommonweb/src/main/java/org
Yaniv Bronhaim has posted comments on this change.
Change subject: Use empty string instead null for empty foreman parameters
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/35444
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoid updating fields when uneccessary
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36159
To unsubscribe, visit http://gerrit.ovirt.org
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Avoid updating fields when uneccessary
..
Avoid updating fields when uneccessary
When filling lists of hosts the change event is raised. To avoid
updating fiel
Yaniv Bronhaim has posted comments on this change.
Change subject: Use empty string instead null for empty foreman parameters
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/35444/3/frontend/webadmin/modules/uicommonwe
Yaniv Bronhaim has posted comments on this change.
Change subject: Use empty string instead null for empty foreman parameters
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35444
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35718
To uns
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/35450
To uns
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/35450
To uns
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35718
To uns
Yaniv Bronhaim has uploaded a new change for review.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
foreman-integration: Remove domain from hostname to allow rhevh registration
A
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow registerVds with same name and hostname if provisioned
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35343
To unsubscribe, visit h
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 2:
with that the registration works automatically. after provision is
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35450
To uns
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Allow simultaneous add of gluster host
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35635/1/backend/manager/modules/bll/src/main/java/org/ov
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Allow simultaneous add of gluster host
..
Patch Set 1: Code-Review+1
(1 comment)
got that wrong. ack from my side
http://gerrit.ovirt.org/#/c/35635/1/
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: Fix search button logic
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Allow simultaneous add of gluster host
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35635/1/backend/manager/modules/bll/src/main/java/org/ov
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Allow simultaneous add of gluster host
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35635/1/backend/manager/modules/bll/src/ma
Yaniv Bronhaim has posted comments on this change.
Change subject: engine: Allow simultaneous add of gluster host
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35635
To unsubscribe, visit http://gerri
Yaniv Bronhaim has posted comments on this change.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
Patch Set 1: Verified-1
(1 comment)
something goes wrong with the record updat
Yaniv Bronhaim has posted comments on this change.
Change subject: Use empty string instead null for empty foreman parameters
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35444/1/backend/manager/modules/common/src/m
Yaniv Bronhaim has posted comments on this change.
Change subject: fixup: Instantiate vdsManagers in a less convoluted manner
..
Patch Set 1: Code-Review-1
i assume its here for mocking purposes ..
--
To view, visit http://ge
Yaniv Bronhaim has uploaded a new change for review.
Change subject: foreman-integration: Remove domain from hostname to allow rhevh
registration
..
foreman-integration: Remove domain from hostname to allow rhevh registration
A
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: Fixing popupHostView css style
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35386
To unsubscribe, visit http://gerrit.ovirt.org/set
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: fixing addHost form issues when playing with using host
provider
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35385
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: fixing display of host fqdn in addHost form
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35442
To unsubscribe, visit http://gerrit.
Yaniv Bronhaim has posted comments on this change.
Change subject: Add discovered IP address to provision call
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35441
To unsubscribe, visit http://gerrit.ovir
Yaniv Bronhaim has posted comments on this change.
Change subject: Use empty string instead null for empty foreman parameters
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35444
To unsubscribe, visit htt
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove suffix from mgmt address taken from the ComputerResource
conf
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35383
To unsubscribe
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Use empty string instead null for empty foreman parameters
..
Use empty string instead null for empty foreman parameters
Change-Id: I5c95db55a56b7a81ae81876e57
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Add discovered IP address to provision call
..
Add discovered IP address to provision call
In later patch we add to the vds address field the fqdn of the
disco
Yaniv Bronhaim has uploaded a new change for review.
Change subject: ui: fixing display of host fqdn in addHost form
..
ui: fixing display of host fqdn in addHost form
In this patch we create the initial vds name record with the
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: fixing display of host fqdn in addHost form
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/35214
To unsubscribe, visit http://gerrit.
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: fixing display of host fqdn in addHost form
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/35214
To unsubscribe, visit http://gerrit.
Yaniv Bronhaim has posted comments on this change.
Change subject: Add discovered IP address to provision call
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35324
To unsubscribe, visit http://gerrit.ovir
Yaniv Bronhaim has uploaded a new change for review.
Change subject: ui: fixing addHost form issues when playing with using host
provider
..
ui: fixing addHost form issues when playing with using host provider
Apparently hiding
Yaniv Bronhaim has uploaded a new change for review.
Change subject: ui: Fixing popupHostView css style
..
ui: Fixing popupHostView css style
Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d
Bug-Url: https://bugzilla.redhat.
Yaniv Bronhaim has uploaded a new change for review.
Change subject: ui: Fix search button logic
..
ui: Fix search button logic
Commit 60331c40535c95950274984d89177643df5686db broke the search button
logic. This patch returns th
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove suffix from mgmt address taken from the ComputerResource
conf
..
Remove suffix from mgmt address taken from the ComputerResource conf
This parameter is
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow registerVds with same name and hostname if provisioned
..
Patch Set 3: -Verified
--
To view, visit http://gerrit.ovirt.org/35343
To unsubscribe, visit ht
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: fixing addHost form issues when playing with using host
provider
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/35239
To unsubscribe
Yaniv Bronhaim has posted comments on this change.
Change subject: ui: Fix search button logic
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow registerVds with same name and hostname if provisioned
..
Patch Set 3: Verified+1
the only different from master is the use in debugFormat instead of debu
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow registerVds with same name and hostname if provisioned
..
Patch Set 2: Verified+1
the only different from master is the use in debugFormat instead of debu
Yaniv Bronhaim has posted comments on this change.
Change subject: Allow registerVds with same name and hostname if provisioned
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35343
To unsubscribe, visit h
1 - 100 of 676 matches
Mail list logo
