[Engine-patches] Change in ovirt-engine[master]: engine-core: quota search

2012-04-03 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: quota search .. Patch Set 2: (1 inline comment) File backend/manager/modules/searchbackend/s

[Engine-patches] Change in ovirt-engine[master]: core: Refactor SchedulerUtilQuartz

2012-04-03 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: core: Refactor SchedulerUtilQuartz .. Patch Set 1: (1 inline comment) File backend/manager/modules/beans/

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmCommand

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: Fixing AddVmCommand .. Patch Set 2: Abandoned obsolete -- To view, visit http://gerrit.ovirt.org/2025 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: engine-core: refactoring VmManagementParametersBase

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: refactoring VmManagementParametersBase .. Patch Set 2: Abandoned obsolete -- To view, visit http://gerrit.ovirt.org/2023 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine-core: refactoring AddVmCommand

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: refactoring AddVmCommand .. Patch Set 2: Abandoned obsolete -- To view, visit http://gerrit.ovirt.org/2024 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: engine-core: cleaning up AddVmTemplateParameters

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: cleaning up AddVmTemplateParameters .. Patch Set 2: Abandoned obsolete -- To view, visit http://gerrit.ovirt.org/2026 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: engine-core: refactoring AddVmTemplateCommand

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: refactoring AddVmTemplateCommand .. Patch Set 2: Abandoned obsolete -- To view, visit http://gerrit.ovirt.org/2027 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmTemplateCommand for multiple storag...

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: Fixing AddVmTemplateCommand for multiple storage domains .. Patch Set 3: Abandoned obsolete -- To view, visit http://gerrit.ovirt.org/2028 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: Move disk command .. Patch Set 8: Abandoned replaced -- To view, visit http://gerrit.ovirt.org/1608 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-03-31 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: Copy Disk Command .. Patch Set 7: Abandoned replaced -- To view, visit http://gerrit.ovirt.org/1628 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmCommand

2012-02-21 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Fixing AddVmCommand .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/src/

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmCommand (Review Only)

2012-02-20 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Fixing AddVmCommand (Review Only) .. Patch Set 1: (3 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmTemplateCommand for multiple storag...

2012-02-20 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Fixing AddVmTemplateCommand for multiple storage domains .. Patch Set 2: (2 inline comments)

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmTemplateCommand for multiple storag...

2012-02-18 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: Fixing AddVmTemplateCommand for multiple storage domains .. engine-core: Fixing AddVmTemplateCommand for multiple storage domains There needed t

[Engine-patches] Change in ovirt-engine[master]: engine-core: refactoring AddVmTemplateCommand

2012-02-18 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: refactoring AddVmTemplateCommand .. engine-core: refactoring AddVmTemplateCommand Cleaning up the code, removing dead code, uneeded comments Cha

[Engine-patches] Change in ovirt-engine[master]: engine-core: cleaning up AddVmTemplateParameters

2012-02-18 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: cleaning up AddVmTemplateParameters .. engine-core: cleaning up AddVmTemplateParameters removing unneeded xml annotations, reordering class eleme

[Engine-patches] Change in ovirt-engine[master]: engine-core: Fixing AddVmCommand (Review Only)

2012-02-18 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: Fixing AddVmCommand (Review Only) .. engine-core: Fixing AddVmCommand (Review Only) AddVmCommand needed additional code to support multiple stora

[Engine-patches] Change in ovirt-engine[master]: engine-core: refactoring VmManagementParametersBase

2012-02-18 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: refactoring VmManagementParametersBase .. engine-core: refactoring VmManagementParametersBase general refactoring and cleanup Change-Id: I374d8d

[Engine-patches] Change in ovirt-engine[master]: engine-core: refactoring AddVmCommand

2012-02-18 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: refactoring AddVmCommand .. engine-core: refactoring AddVmCommand general refactoring and cleanup Change-Id: I3f45a2f58bbdee5a2a5cba23d4491cdb3b

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing disk device creation on vm import

2012-02-14 Thread jchoate
Jonathan Choate has submitted this change and it was merged. Change subject: engine-core: fixing disk device creation on vm import .. engine-core: fixing disk device creation on vm import When importing a vm we were not creatin

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing disk device creation on vm import

2012-02-14 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: fixing disk device creation on vm import .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1814 To un

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing disk device creation on vm import

2012-02-10 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: fixing disk device creation on vm import .. engine-core: fixing disk device creation on vm import When importing a vm we were not creating device

[Engine-patches] Change in ovirt-engine[master]: engine-core: adding ensureDomainMap to ImportVmTemplateComma...

2012-02-09 Thread jchoate
Jonathan Choate has submitted this change and it was merged. Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand .. engine-core: adding ensureDomainMap to ImportVmTemplateCommand Part of fixing the NP

[Engine-patches] Change in ovirt-engine[master]: engine-core: adding ensureDomainMap to ImportVmTemplateComma...

2012-02-09 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: engine-core: adding ensureDomainMap to ImportVmTemplateComma...

2012-02-09 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand .. Patch Set 1: I don't disagree but I'd like to get this fixed first. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine-core: adding ensureDomainMap to ImportVmTemplateComma...

2012-02-09 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand .. Patch Set 1: I can't think of a existing class that would be appropriate -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-02-08 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Copy Disk Command .. Patch Set 7: Changes were necessary due to NPE fix commit -- To view, visit http://gerrit.ovirt.org/1628 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-08 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command .. Patch Set 8: Changes were necessary due to NPE fix commit -- To view, visit http://gerrit.ovirt.org/1608 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: engine-core: adding ensureDomainMap to ImportVmTemplateComma...

2012-02-08 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand .. engine-core: adding ensureDomainMap to ImportVmTemplateCommand Part of fixing the NPE. Also

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-02-08 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Copy Disk Command .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1628 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-08 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command .. Patch Set 7: at the request of the UI, added storage domain name to DiskImage object and updated views and DAOs to populate

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-02-08 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Copy Disk Command .. Patch Set 4: (1 inline comment) File backend/manager/modules/common/src

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-08 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command .. Patch Set 4: (1 inline comment) File backend/manager/modules/common/src

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing NPE in import templagte command

2012-02-08 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: fixing NPE in import templagte command .. engine-core: fixing NPE in import templagte command Fixing the NPE when checking disk space on storage

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-02-07 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Copy Disk Command .. Patch Set 2: (1 inline comment) File backend/manager/modules/common/src

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-07 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command .. Patch Set 3: (1 inline comment) File backend/manager/modules/common/src

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing NPE in ImportVmTemplateCommand

2012-02-06 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: fixing NPE in ImportVmTemplateCommand .. engine-core: fixing NPE in ImportVmTemplateCommand This is not the ideal fix but until it is worked out

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-02-06 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Copy Disk Command .. Patch Set 1: (2 inline comments) File backend/manager/modules/bll/src/m

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-06 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command .. Patch Set 2: (12 inline comments) File backend/manager/modules/bll/src/

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-06 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command .. Patch Set 2: (2 inline comments) File backend/manager/modules/bll/src/m

[Engine-patches] Change in ovirt-engine[master]: engine-core: Copy Disk Command

2012-02-05 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: Copy Disk Command .. engine-core: Copy Disk Command Adding code to allow templates to copy individual disks to multiple storage domains. Change-

[Engine-patches] Change in ovirt-engine[master]: engine-core: Move disk command

2012-02-04 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: Move disk command .. engine-core: Move disk command Adding a new command MoveDisk which will allow disks to be moved across storage domains Chan

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing NPE in importVmTemplateCommand

2012-02-03 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: fixing NPE in importVmTemplateCommand .. Patch Set 1: Abandoned incomplete fix -- To view, visit http://gerrit.ovirt.org/1408 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine-core: removing windows line terminations from sql scr...

2012-02-03 Thread jchoate
Jonathan Choate has abandoned this change. Change subject: engine-core: removing windows line terminations from sql scripts .. Patch Set 1: Abandoned already fixed -- To view, visit http://gerrit.ovirt.org/1287 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: engine-core: fixing NPE in importVmTemplateCommand

2012-02-01 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: fixing NPE in importVmTemplateCommand .. engine-core: fixing NPE in importVmTemplateCommand The frontend provides a partially constructed vmTempl

[Engine-patches] Change in ovirt-engine[master]: engine-core: create a VM from a template

2012-01-31 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: create a VM from a template .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1068 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine-core: create a VM from a template

2012-01-31 Thread jchoate
Jonathan Choate has submitted this change and it was merged. Change subject: engine-core: create a VM from a template .. engine-core: create a VM from a template Made a change to AddVmFromTemplateCommand to ensure that VM disks

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-31 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1067 To

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-31 Thread jchoate
Jonathan Choate has submitted this change and it was merged. Change subject: engine-core: Multiple storage domains when importing VM .. engine-core: Multiple storage domains when importing VM Fixing ImportVmCommand and ImportVm

[Engine-patches] Change in ovirt-engine[master]: engine-core: removing windows line terminations from sql scr...

2012-01-26 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: removing windows line terminations from sql scripts .. engine-core: removing windows line terminations from sql scripts removed all of the window

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-26 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 2: (3 inline comments) File backend/

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-25 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 1: (10 inline comments) File backend

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-17 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 1: (2 inline comments) File backend/

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-17 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: Multiple storage domains when importing VM .. Patch Set 1: (9 inline comments) File backend/

[Engine-patches] Change in ovirt-engine[master]: engine-core: cleaning up paramter classes

2012-01-17 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: cleaning up paramter classes .. engine-core: cleaning up paramter classes 1) moving ctors to the top 2) moving members below ctors

[Engine-patches] Change in ovirt-engine[master]: engine : Hotplug - a new command added, main logic

2012-01-16 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine : Hotplug - a new command added, main logic .. Patch Set 2: (4 inline comments) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: engine-core: removing * import on MoveVmParameters

2012-01-16 Thread jchoate
Jonathan Choate has submitted this change and it was merged. Change subject: engine-core: removing * import on MoveVmParameters .. engine-core: removing * import on MoveVmParameters The title says it all. Change-Id: I76f691131

[Engine-patches] Change in ovirt-engine[master]: engine-core: removing * import on MoveVmParameters

2012-01-16 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: removing * import on MoveVmParameters .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1036 To unsub

[Engine-patches] Change in ovirt-engine[master]: engine-core: removing redundancy in ImportExportCommon

2012-01-16 Thread jchoate
Jonathan Choate has posted comments on this change. Change subject: engine-core: removing redundancy in ImportExportCommon .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1035 To u

[Engine-patches] Change in ovirt-engine[master]: engine-core: removing redundancy in ImportExportCommon

2012-01-16 Thread jchoate
Jonathan Choate has submitted this change and it was merged. Change subject: engine-core: removing redundancy in ImportExportCommon .. engine-core: removing redundancy in ImportExportCommon Removing initializtion of booleans th

[Engine-patches] Change in ovirt-engine[master]: engine-core: Multiple storage domains when importing VM

2012-01-16 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: Multiple storage domains when importing VM .. engine-core: Multiple storage domains when importing VM Fixing ImportVmCommand and ImportVmTemplate

[Engine-patches] Change in ovirt-engine[master]: engine-core: create a VM from a template

2012-01-16 Thread jchoate
Jonathan Choate has uploaded a new change for review. Change subject: engine-core: create a VM from a template .. engine-core: create a VM from a template Made a change to AddVmFromTemplateCommand to ensure that VM disks go the