Danny Rankevich has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3209
To uns
Danny Rankevich has posted comments on this change.
Change subject: webadmin: add MTU and Vm Network flags
..
Patch Set 2: Looks good to me, but someone else must approve
Looks Ok.
The NPE was caused by me (copy & paste :)
I t
Danny Rankevich has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 8: Looks good to me, but someone else must approve
Looks ok to me, but you removed the Display Network Ac
Danny Rankevich has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 7:
The "Required" flag should be set during the Attach/Detach Action on the
backend.
The flag should be
Danny Rankevich has posted comments on this change.
Change subject: webadmin: manage cluster networks dialog
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3209
To unsu
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: add MTU and Vm Network flags
..
webadmin: add MTU and Vm Network flags
on going...
Change-Id: I0f7faf12b298a23236f29727dc8beb35f008dd0a
---
M
fron
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: Add subnet mask validation
..
webadmin: Add subnet mask validation
Adding validation for subnet masks
Change-Id: I1020b4231a3ec72cd504a5969f2c52ce7
Danny Rankevich has submitted this change and it was merged.
Change subject: core: allow default gateway when validating setworks
..
core: allow default gateway when validating setworks
0.0.0.0 is considered as the default gate
Danny Rankevich has posted comments on this change.
Change subject: core: allow default gateway when validating setworks
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2918
To uns
Danny Rankevich has abandoned this change.
Change subject: core: allow synchronous multiple actions
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3210
To unsubscribe, visit http://gerrit.ovirt.org/settings
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: Setup Host Networks Feature
..
webadmin: Setup Host Networks Feature
This feature allows the editing of a Host Network Topology.
All topolog
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Setup Host Networks Feature
..
Patch Set 24: Verified; Looks good to me, approved
Already approved
--
To view, visit http://gerrit.ovirt.org/1874
To
Danny Rankevich has uploaded a new change for review.
Change subject: core: allow synchronous multiple actions
..
core: allow synchronous multiple actions
* Add a flag to Execute() indicating sync execution
* In case of a sync e
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: manage cluster networks dialog
..
webadmin: manage cluster networks dialog
on going...
Change-Id: I617a73105dcadd6733b4a854ebdece47b066d367
---
M
Danny Rankevich has posted comments on this change.
Change subject: core: allow default gateway when validating setworks
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2918
To uns
Danny Rankevich has abandoned this change.
Change subject: compat: notify of removed/added elements on Observable List
changes
..
Patch Set 1: Abandoned
not required any more
--
To view, visit http://gerrit.ovirt.org/1685
To
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: adjust location of sub menu open in mouseover
..
webadmin: adjust location of sub menu open in mouseover
no bz
In a previous commit I chang
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adjust location of sub menu open in mouseover
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2962
To
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: auto open sub menu
..
webadmin: auto open sub menu
no bz
Change-Id: Iffc52644cbd471618c43123e7785a1c8612990f1
---
M
frontend/webadmin/modu
Danny Rankevich has posted comments on this change.
Change subject: webadmin: auto open sub menu
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Danny Rankevich has posted comments on this change.
Change subject: webadmin: auto open sub menu
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2939
To unsubscribe, visit http://gerrit.ovir
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: adding power managment actions
..
webadmin: adding power managment actions
https://bugzilla.redhat.com/show_bug.cgi?id=782703
Adding power
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding power managment actions
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2937
To unsubscribe, vi
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: use management network config value
..
webadmin: use management network config value
- add management network name async getter to AsyncData
Danny Rankevich has posted comments on this change.
Change subject: webadmin: use management network config value
..
Patch Set 2: Verified; Looks good to me, approved
already reviewed
--
To view, visit http://gerrit.ovirt.org/
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: adding missing "}" to MainTabReportsView + ussing
relative link
..
webadmin: adding missing "}" to MainTabReportsView + ussing relative link
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding missing "}" to MainTabReportsView + ussing
relative link
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding missing "}" to MainTabReportsView + ussing
relative link
..
--
To view, visit http://gerrit.ovirt.org/2722
To unsubscribe, visit http://gerr
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding missing "}" to MainTabReportsView + ussing
relative link
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: adjust sub menu popup location to fit screen + RTL
popup support
..
webadmin: adjust sub menu popup location to fit screen + RTL popup suppo
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adjust sub menu popup location to fit screen + RTL
popup support
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerri
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding missing "}" to MainTabReportsView + ussing
relative link
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Danny Rankevich has submitted this change and it was merged.
Change subject: ovirt-engine: Use config value ManagementNetwork
..
ovirt-engine: Use config value ManagementNetwork
The config value ManagementNetwork already exists
Danny Rankevich has posted comments on this change.
Change subject: ovirt-engine: Use config value ManagementNetwork
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1412
To unsubsc
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: use management network config value
..
webadmin: use management network config value
- add management network name async getter to AsyncDataProvider
Danny Rankevich has submitted this change and it was merged.
Change subject: core: fix identifying network management
..
core: fix identifying network management
The management network name that is used to identify and mark a
m
Danny Rankevich has posted comments on this change.
Change subject: core: fix identifying network management
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2625
To unsubscribe, vi
Danny Rankevich has posted comments on this change.
Change subject: core: fix identifying network management
..
Patch Set 1: Verified; Looks good to me, approved
Verified on webadmin UI
--
To view, visit http://gerrit.ovirt.or
Danny Rankevich has posted comments on this change.
Change subject: userportal: Support for dialogs
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2651
To unsubscribe, visit http:
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: Cropped context (right-click) menu in some scenarios
..
webadmin: Cropped context (right-click) menu in some scenarios
https://bugzilla.redh
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: RunOnce dialog - Domain is always visible
..
webadmin: RunOnce dialog - Domain is always visible
https://bugzilla.redhat.com/show_bug.cgi?id
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: formatting error messsage
..
webadmin: formatting error messsage
no bz
Orginizing error messages code
Change-Id: Icca519266a05da5ba22f5e0e
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: adding support to downdstream dashboards
..
webadmin: adding support to downdstream dashboards
no bz
In downstream we have dashboard with i
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding support to downdstream dashboards
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2579
To unsub
Danny Rankevich has posted comments on this change.
Change subject: webadmin: formatting error messsage
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2574
To unsubscribe, visit
Danny Rankevich has posted comments on this change.
Change subject: webadmin: RunOnce dialog - Domain is always visible
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2490
To unsubscribe,
Danny Rankevich has posted comments on this change.
Change subject: webadmin: RunOnce dialog - Domain is always visible
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2490
To unsubscribe, visit http://gerri
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Cropped context (right-click) menu in some scenarios
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding support to downdstream dashboards
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2579
To unsub
Danny Rankevich has posted comments on this change.
Change subject: webadmin: formatting error messsage
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2574
To unsubscribe, visit h
Danny Rankevich has posted comments on this change.
Change subject: webadmin: RunOnce dialog - Domain is always visible
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2490
To uns
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Cropped context (right-click) menu in some scenarios
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding support to downdstream dashboards
..
--
To view, visit http://gerrit.ovirt.org/2349
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding support to downdstream dashboards
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/2349
To unsubscribe, visit http://gerrit
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding support to downdstream dashboards
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2349
To unsubscribe, v
Danny Rankevich has posted comments on this change.
Change subject: webadmin: adding support to downdstream dashboards
..
Patch Set 6: Verified; Looks good to me, approved
(1 inline comment)
...
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Cropped context (right-click) menu in some scenarios
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2
Danny Rankevich has posted comments on this change.
Change subject: webadmin: formatting error messsage
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2574
To unsubscribe, visit h
Danny Rankevich has posted comments on this change.
Change subject: webadmin: RunOnce dialog - Domain is always visible
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2490
To unsu
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Cropped context (right-click) menu in some scenarios
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2
Danny Rankevich has posted comments on this change.
Change subject: webadmin: setup networks UI
..
Patch Set 8: (2 inline comments)
File
frontend/webadmin/modules/webadmin/s
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: fix ok button in new interface dialog (#783165)
..
webadmin: fix ok button in new interface dialog (#783165)
https://bugzilla.redhat.com/sho
Danny Rankevich has posted comments on this change.
Change subject: webadmin: fix ok button in new interface dialog (#783165)
..
Patch Set 2: Verified; Looks good to me, approved
already reviewed
--
To view, visit http://gerri
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: fix ok button in new interface dialog (#783165)
..
webadmin: fix ok button in new interface dialog (#783165)
https://bugzilla.redhat.com/show_bug.cg
Danny Rankevich has submitted this change and it was merged.
Change subject: userportal: VM Event sub-tab
..
userportal: VM Event sub-tab
- Reused EventListModelTable widget already used in Template Event
sub-tab View
- In U
Danny Rankevich has submitted this change and it was merged.
Change subject: userportal: VM Permission sub-tab
..
userportal: VM Permission sub-tab
- Reused PermissionListModelTable widget already
used in Template Permission
Danny Rankevich has submitted this change and it was merged.
Change subject: userportal: VM Snapshot sub-tab
..
userportal: VM Snapshot sub-tab
- Extracted VM Snapshot sub-tab content from WebAdmin into GwtCommon
- Used VmSnap
Danny Rankevich has submitted this change and it was merged.
Change subject: userportal: Extended tab: First two VM sub-tabs
..
userportal: Extended tab: First two VM sub-tabs
Implemented first two sub-tabs of 'Virtual Machines
Danny Rankevich has submitted this change and it was merged.
Change subject: userportal: VM Virtual Disk sub-tab
..
userportal: VM Virtual Disk sub-tab
- Extracted VM Virtual Disk sub-tab content from WebAdmin
into GwtCommon,
Danny Rankevich has posted comments on this change.
Change subject: userportal: Extended tab: First two VM sub-tabs
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2225
To unsubscr
Danny Rankevich has posted comments on this change.
Change subject: userportal: VM Virtual Disk sub-tab
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2250
To unsubscribe, visit h
Danny Rankevich has posted comments on this change.
Change subject: userportal: VM Snapshot sub-tab
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2255
To unsubscribe, visit http:
Danny Rankevich has posted comments on this change.
Change subject: userportal: VM Permission sub-tab
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2274
To unsubscribe, visit htt
Danny Rankevich has posted comments on this change.
Change subject: userportal: VM Event sub-tab
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2352
To unsubscribe, visit http://g
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: gwt-common project maven configuration
..
webadmin: gwt-common project maven configuration
To make sure the generatedSourcesDirectory is configured
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Dialog UI reuse concept
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2139
To unsubscribe, visit htt
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Tab UI reuse concept
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2120
To unsubscribe, visit http:/
Danny Rankevich has abandoned this change.
Change subject: webadmin: maintain inheritance chain call for
ListModel.setItems()
..
Patch Set 1: Abandoned
decided changing this is too risky
--
To view, visit http://gerrit.ovirt.
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: add sorting for the bookmarks (#785731)
..
webadmin: add sorting for the bookmarks (#785731)
https://bugzilla.redhat.com/show_bug.cgi?id=785731
Sor
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: maintain inheritance chain call for
ListModel.setItems()
..
webadmin: maintain inheritance chain call for ListModel.setItems()
In SearchableListMod
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: integrating reports to webadmin (commnets fixes)
..
webadmin: integrating reports to webadmin (commnets fixes)
no bz
- Getting Reports.xml
Danny Rankevich has posted comments on this change.
Change subject: webadmin: integrating reports to webadmin (commnets fixes)
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1952
Danny Rankevich has posted comments on this change.
Change subject: webadmin: integrating reports to webadmin (commnets fixes)
..
Patch Set 3: (4 inline comments)
File
front
Danny Rankevich has submitted this change and it was merged.
Change subject: frontend: getId compilation errors
..
frontend: getId compilation errors
no bz
Change-Id: I94a5109671a1215ae418e7d3064e24c9cf295de4
---
M
backend/ma
Danny Rankevich has submitted this change and it was merged.
Change subject: core: add HasStoragePool interface
..
core: add HasStoragePool interface
no bz
add HasStoragePool interface and implement it in VDS, VDSGroup and VM
Danny Rankevich has submitted this change and it was merged.
Change subject: core: storage_domains implements BusinessEntity
..
core: storage_domains implements BusinessEntity
no bz
The business entities have common procedures
Danny Rankevich has submitted this change and it was merged.
Change subject: core: VDS implements BusinessEntity
..
core: VDS implements BusinessEntity
no bz
The business entities have common procedures- getId and setId.
But a
Danny Rankevich has posted comments on this change.
Change subject: core: VDS implements BusinessEntity
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1860
To unsubscribe, visit h
Danny Rankevich has posted comments on this change.
Change subject: core: storage_domains implements BusinessEntity
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1869
To unsubscr
Danny Rankevich has posted comments on this change.
Change subject: core: add HasStoragePool interface
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1873
To unsubscribe, visit ht
Danny Rankevich has posted comments on this change.
Change subject: frontend: getId compilation errors
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2012
To unsubscribe, visit ht
Danny Rankevich has submitted this change and it was merged.
Change subject: core: VDSGroup implements BusinessEntity
..
core: VDSGroup implements BusinessEntity
no bz
The business entities have common procedures- getId and se
Danny Rankevich has posted comments on this change.
Change subject: core: VDSGroup implements BusinessEntity
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1852
To unsubscribe, vi
Danny Rankevich has submitted this change and it was merged.
Change subject: core: VM implements BusinessEntity
..
core: VM implements BusinessEntity
no bz
The business entities have common procedures- getId and setId.
But as
Danny Rankevich has posted comments on this change.
Change subject: core: VM implements BusinessEntity
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1847
To unsubscribe, visit ht
Danny Rankevich has posted comments on this change.
Change subject: webadmin: Cannot bond with an iface that has a vlan (#787981)
..
Patch Set 2:
When trying to bond a nic with a nic that has one vlan network, you get the
foll
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: Cannot bond with an iface that has a vlan (#787981)
..
webadmin: Cannot bond with an iface that has a vlan (#787981)
https://bugzilla.redhat.com/sho
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: no refresh after removing a bookmark (#783922)
..
webadmin: no refresh after removing a bookmark (#783922)
https://bugzilla.redhat.com/show_
Danny Rankevich has posted comments on this change.
Change subject: webadmin: no refresh after removing a bookmark (#783922)
..
Patch Set 4: Verified; Looks good to me, approved
already approved
--
To view, visit http://gerrit
Danny Rankevich has posted comments on this change.
Change subject: core: add HasStoragePool interface
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1873
To unsubscrib
1 - 100 of 161 matches
Mail list logo
