Dan Kenigsberg has posted comments on this change.
Change subject: core: Support for noTSX and Broadwell processors
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41592/1//COMMIT_MSG
Commit Message:
Li
Dan Kenigsberg has uploaded a new change for review.
Change subject: mock_install.sh: use dnf-acceptable `yum install`
..
mock_install.sh: use dnf-acceptable `yum install`
As explained in https://bugzilla.redhat.com/show_bug.cgi
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: gluster: provide 3.7 nightly builds
..
Patch Set 1: Code-Review+1
(1 comment)
fwiw, +1
https://gerrit.ovirt.org/#/c/39139/1/jobs/packaging/repo_closure_
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: make use of the new onlyUUID parameter
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38709
To unsubscribe, visit https://gerri
Dan Kenigsberg has uploaded a new change for review.
Change subject: create vdsm rpms on f21, too.
..
create vdsm rpms on f21, too.
Change-Id: I68a1dfdd86d8dbef62ef131f6e60933ff32a56dc
Signed-off-by: Dan Kenigsberg
---
M jobs/c
Dan Kenigsberg has posted comments on this change.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35260
To unsubscribe, visit http://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: HostKSM: Gracefully handle ksmd pid lookup failure
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/34378/1/mom/Collectors/HostKSM.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Added extra gluster repos for vdsm
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34298
To unsubscribe, visit http://gerrit.ovirt.org/
Dan Kenigsberg has posted comments on this change.
Change subject: engine: Add validation that display network is required
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32906/2//COMMIT_MSG
Commit Messag
Dan Kenigsberg has uploaded a new change for review.
Change subject: sudoers: fix path to ovirt-shutdown-wrappers.sh
..
sudoers: fix path to ovirt-shutdown-wrappers.sh
Thanks to John Xue for reporting the issue.
Change-Id: I696
Dan Kenigsberg has posted comments on this change.
Change subject: use VDSM for creating volumes
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28237/5/ovirt_hosted_engine_ha/lib/storage_backends.py
File ovirt_hosted_
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: add required packages...
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26330
To unsubscribe, visit http://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: add required packages...
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/26330/6/ovirt-release.spec.in
File ovirt-release.spec.in:
Line 84:
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: add required packages...
..
Patch Set 4: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/26330/4/ovirt-release.spec.in
File ovirt-release.spe
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: add required packages...
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/26330/2/ovirt-el-deps.repo
File ovirt-el-deps.repo:
Line 1: [ovir
Dan Kenigsberg has abandoned this change.
Change subject: Expose setting the number of vNIC queues
..
Abandoned
Thanks for your review, Moti. But since we do not have the ability to limit
this property to hosts that actually h
Dan Kenigsberg has posted comments on this change.
Change subject: Keep everything in /var/log
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25878
To unsubscribe, visit http://gerrit.ovirt.org/setting
Dan Kenigsberg has posted comments on this change.
Change subject: Keep everything in /var/log
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25878/1/ovirt-node-plugin-vdsm.spec.in
File ovirt-node-plugin
Dan Kenigsberg has uploaded a new change for review.
Change subject: Expose setting the number of vNIC queues
..
Expose setting the number of vNIC queues
With properly-updated libvirt and qemu, clusterLevel 3.5 would let end
use
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: spec: update deps
..
Patch Set 1: Code-Review+1
ack for requiring vdsm-4.14.
--
To view, visit http://gerrit.ovirt.org/23388
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: el6: explicitly require epel
..
Patch Set 1: Verified+1
package built. `rpm -qpR` does require epel-release as intended.
--
To view, visit http://gerrit.ovirt
Dan Kenigsberg has posted comments on this change.
Change subject: [RFE] Use Management class to pass informations
..
Patch Set 2:
(1 comment)
File src/engine_page.py
Line 3
Dan Kenigsberg has uploaded a new change for review.
Change subject: el6: explicitly require epel
..
el6: explicitly require epel
Vdsm requires packages delivered via EPEL-6. This change makes the
dependency explicit on the prod
Dan Kenigsberg has posted comments on this change.
Change subject: change gluster to use LATEST
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21794
To unsubscribe, visit http://gerrit.ovirt.org/settin
Dan Kenigsberg has posted comments on this change.
Change subject: change gluster to use LATEST
..
Patch Set 2: Code-Review-1
I suppose that you are right Sandro. We must bump the release number, and it
would be better if copi
Dan Kenigsberg has posted comments on this change.
Change subject: change gluster to use LATEST
..
Patch Set 1: Code-Review-1
(1 comment)
File glusterfs-epel.repo
Line 15: g
Dan Kenigsberg has uploaded a new change for review.
Change subject: core: support the newly-tagged vdsm-4.13
..
core: support the newly-tagged vdsm-4.13
vdsm-4.13 would be part of oVirt-3.3.1.
Change-Id: I12dacd46973cde693105c
Dan Kenigsberg has posted comments on this change.
Change subject: KSM: Only tune when there are changes to make
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17711
To unsubscribe, visit http://gerrit
Dan Kenigsberg has posted comments on this change.
Change subject: engine: Allowed creation of bonds in SetupNetworksHelper
..
Patch Set 3:
Would you consider backporting this to the ovirt-3.3 branch? Without it, to use
a fanc
Dan Kenigsberg has posted comments on this change.
Change subject: stop supervdsmd before configuring libvirt
..
Patch Set 1:
Alon, I *suppose* you stopped vdsm since you did not want it running while you
configure libvirt. If
Dan Kenigsberg has posted comments on this change.
Change subject: stop supervdsmd before configuring libvirt
..
Patch Set 1:
Alon, why does ovirt-host-deploy stop vdsmd at the moment? Would not the same
reasoning apply to exp
Dan Kenigsberg has posted comments on this change.
Change subject: stop supervdsmd before configuring libvirt
..
Patch Set 1:
Meni, would you agree to test this patch, as I haven't done so?
--
To view, visit http://gerrit.ovi
Dan Kenigsberg has uploaded a new change for review.
Change subject: stop supervdsmd before configuring libvirt
..
stop supervdsmd before configuring libvirt
vdsmd is stopped, if existing, before upgrade and reconfiguration of
l
Dan Kenigsberg has posted comments on this change.
Change subject: spec: finer-grained libvirt requirement
..
Patch Set 1:
I forgot to mention that this patch is required for a useful solution of
https://bugzilla.redhat.com/sh
Dan Kenigsberg has posted comments on this change.
Change subject: webadmin: fix another tiny typo
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/17357
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: fix another tiny typo
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: AuthorDate: 2013-07-26 22:0
Dan Kenigsberg has uploaded a new change for review.
Change subject: fix another tiny typo
..
fix another tiny typo
Change-Id: I5b82520071f0d12318b1aafb9690b2429882083e
Bug-Url: https://bugzilla.redhat.com/982507
Signed-off-by:
Dan Kenigsberg has uploaded a new change for review.
Change subject: fix tiny typo
..
fix tiny typo
Change-Id: Ib1a6698279a6fe799be3ffee1f0c59fc1add9646
Bug-Url: https://bugzilla.redhat.com/988017
Signed-off-by: Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: core: support soon-to-be-released vdsm-4.12
..
core: support soon-to-be-released vdsm-4.12
vdsm-4.12 would be part of oVirt-3.3.
Change-Id: Icc7692bc6e8373cb8
Dan Kenigsberg has posted comments on this change.
Change subject: Add fedora-virt-preview yum config
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16125
To unsubscri
Dan Kenigsberg has uploaded a new change for review.
Change subject: spec: finer-grained libvirt requirement
..
spec: finer-grained libvirt requirement
We do not have to pull in all libvirt drivers.
Signed-off-by: Dan Kenigsber
Dan Kenigsberg has posted comments on this change.
Change subject: engine: Allow engine to configure management network
..
Patch Set 2:
I suppose that the management bridge should be created for clusterLevel=3.0,
where you can
Dan Kenigsberg has posted comments on this change.
Change subject: [wip] core: add the openstack dependency
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: [wip] core: add the openstack dependency
..
Patch Set 3:
Does this patch adds dependency to a new Fedora rpm?
--
To view, visit http://gerrit.ovirt.org/13434
T
Dan Kenigsberg has posted comments on this change.
Change subject: engine: send nic parameter in vmUpdateDevice [wip]
..
Patch Set 1: I would prefer that you didn't submit this
I do not see why this argument is needed (or what
Dan Kenigsberg has posted comments on this change.
Change subject: webadmin: Non-VM networks not being detached from cluster
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: adding support for ServiceD
..
Patch Set 6: (1 inline comment)
I haven't reviewed the code, but I have a comment about the comment...
..
Dan Kenigsberg has posted comments on this change.
Change subject: core: add support for tunnel migration
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscripts/u
Dan Kenigsberg has posted comments on this change.
Change subject: Report multiple IPv4 addresses per device if available
..
Patch Set 3: Verified
I've tested the function with and without the new ethtool api.
--
To view, visi
Dan Kenigsberg has uploaded a new change for review.
Change subject: Report multiple IPv4 addresses per device if available
..
Report multiple IPv4 addresses per device if available
A future version of python-ethtool is going to
Dan Kenigsberg has posted comments on this change.
Change subject: Remove unsupported vdsm version 4.5 (2.2)
..
Patch Set 1: Looks good to me, but someone else must approve
seems like a sane cleanup, as oVirt never had vdsm-4.5
Dan Kenigsberg has posted comments on this change.
Change subject: Fixed support for reporting devices with only ipv6.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10
Dan Kenigsberg has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 2: Looks good to me, but someone else must approve
I guess that 2 seconds are more than enough for connection
Dan Kenigsberg has abandoned this change.
Change subject: [UNTESTED] VdsInstaller: report persisted host uuid, if
available
..
Patch Set 1: Abandoned
done much more thoroughly by Alon
--
To view, visit http://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: engine: Send port mirroring when hot-plug NIC (#853709)
..
Patch Set 1: (1 inline comment)
Commit Message
L
Dan Kenigsberg has posted comments on this change.
Change subject: engine: Send port mirroring when hot-plug NIC (#853709)
..
Patch Set 1: Fails
(1 inline comment)
File
bac
Dan Kenigsberg has posted comments on this change.
Change subject: webadmin: Fix getFriendlyVersion
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
you can continue this translation nonsense
Dan Kenigsberg has posted comments on this change.
Change subject: core: version fix
..
Patch Set 25:
Laszlo, I am not approving this patch, nor disproving it. I do not know what is
the problem that it currently solves. due to
Dan Kenigsberg has posted comments on this change.
Change subject: core: version fix
..
Patch Set 25:
Pardon, but I do not see the motivation for this patch. If Engine would like to
support "native" vdsm version/release, it sh
Dan Kenigsberg has posted comments on this change.
Change subject: Rename VM channel device name
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Please notice that the vdsm commit is practically a
Dan Kenigsberg has uploaded a new change for review.
Change subject: [UNTESTED] VdsInstaller: report persisted host uuid, if
available
..
[UNTESTED] VdsInstaller: report persisted host uuid, if available
Host identity must not
Dan Kenigsberg has posted comments on this change.
Change subject: core: Use ping verb to check connectivity with host
..
Patch Set 1:
well, vdsm-4.5 of rhev-2.2 did not have it.
--
To view, visit http://gerrit.ovirt.org/4830
Dan Kenigsberg has posted comments on this change.
Change subject: core: HandleVdsVersion uses only compat level (#822158)
..
Patch Set 3:
well, if http://gerrit.ovirt.org/#change,4548 solves our issue (please verify!)
I do no
Dan Kenigsberg has posted comments on this change.
Change subject: core: HandleVdsVersion uses only compat level (#822158)
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
If you do decide to remov
Dan Kenigsberg has posted comments on this change.
Change subject: ui: fix naming to oVirt Engine
..
Patch Set 1: I would prefer that you didn't submit this
In Vdsm we try to have such strings depend on a single configurable, s
Dan Kenigsberg has uploaded a new change for review.
Change subject: VdsInstaller: drop dead usevdcrepo code
..
VdsInstaller: drop dead usevdcrepo code
Engine had "-u False" hard-coded, so vds_installer can drop this
antiquated
Dan Kenigsberg has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 3:
I'm just following orders.
--
To view, visit http://gerrit.ovirt.org/1689
To unsubscribe, visit http://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/common/
Dan Kenigsberg has uploaded a new change for review.
Change subject: VdsInstaller: drop netconsole code
..
VdsInstaller: drop netconsole code
netconsole has been disentangled from host installation long ago.
ovirt-engine does no
Dan Kenigsberg has posted comments on this change.
Change subject: agent: added a support for a guest hibernate command.
..
Patch Set 1: (2 inline comments)
File ovirt-guest-
70 matches
Mail list logo
