[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Hide irrelevant fields in configuration pr...

2013-11-11 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Hide irrelevant fields in configuration preview during setup .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20955 To

[Engine-patches] Change in ovirt-engine[master]: packaging: gluster:Hide irrelevant fields in configuration p...

2013-11-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: gluster:Hide irrelevant fields in configuration preview during setup .. Patch Set 6: Thanks Sandro. Alon, When Application mode is set as gluster onl

[Engine-patches] Change in ovirt-engine[master]: packaging: gluster:Hide irrelevant fields in configuration p...

2013-11-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: gluster:Hide irrelevant fields in configuration preview during setup .. Patch Set 4: Alon, Sandro, Preview code is checking attribute "summary" before

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Update Default DC compatibility level as 3...

2013-10-31 Thread avishwan
Aravinda VK has abandoned this change. Change subject: packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode .. Abandoned As per the discussion in comments, this change will be implemented in Applicat

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Update Default DC compatibility level as 3...

2013-09-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode .. Patch Set 1: -Verified (1 comment)

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Update Default DC compatibility level as 3...

2013-09-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19185 To unsu

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Update Default DC compatibility level as 3...

2013-09-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19185 To unsu

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Update Default DC compatibility level as 3...

2013-09-18 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode .. packaging: setup: Update Default DC compatibility level as 3.1 in gluster mode

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Fix issue while installing Gluster only mode

2013-09-02 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: packaging: setup: Fix issue while installing Gluster only mode .. packaging: setup: Fix issue while installing Gluster only mode When application mode is selected

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Fix issue while installing Gluster only mode

2013-09-02 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Fix issue while installing Gluster only mode .. Patch Set 1: "storage_pool_type" is not used in gluster only mode, so change in default value wi

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Fix issue while installing Gluster only mode

2013-08-29 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Fix issue while installing Gluster only mode .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18712 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Fix issue while installing Gluster only mode

2013-08-29 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: packaging: setup: Fix issue while installing Gluster only mode .. packaging: setup: Fix issue while installing Gluster only mode When application mode is selected

[Engine-patches] Change in ovirt-host-deploy[master]: tuned: Set tuned profile issue due to GlusterEnv.ENABLE env ...

2013-08-21 Thread avishwan
Aravinda VK has abandoned this change. Change subject: tuned: Set tuned profile issue due to GlusterEnv.ENABLE env var issue .. Abandoned Other patch is good and it is merged. http://gerrit.ovirt.org/#/c/17265/ -- To view, v

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/17736 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-06 Thread avishwan
Hello Alon Bar-Lev, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/17736 to review the following change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. packaging: set

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/17552 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: packaging: Second time setup without cleanup is made configu...

2013-08-06 Thread avishwan
Aravinda VK has abandoned this change. Change subject: packaging: Second time setup without cleanup is made configurable .. Abandoned New engine setup fixed this issue. -- To view, visit http://gerrit.ovirt.org/15380 To unsu

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. Patch Set 7: -Code-Review (1 comment) Sorry I didn't verified earlier. Db func to update config valu

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17552 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. Patch Set 6: Please check my comment in patchset 5. -- To view, visit http://gerrit.ovirt.org/17552

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not enable Gluster in Default cluster

2013-08-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: setup: Do not enable Gluster in Default cluster .. Patch Set 5: (1 comment) File packaging/setup/p

[Engine-patches] Change in ovirt-engine[master]: packaging: Do not enable Gluster in Default cluster

2013-08-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Do not enable Gluster in Default cluster .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17552 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: packaging: Do not enable Gluster in Default cluster

2013-08-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Do not enable Gluster in Default cluster .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/17552 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: packaging: Do not enable Gluster in Default cluster

2013-08-01 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Do not enable Gluster in Default cluster .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17552 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: packaging: Do not enable Gluster in Default cluster

2013-07-31 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: packaging: Do not enable Gluster in Default cluster .. packaging: Do not enable Gluster in Default cluster DEFAULT cluster is created during installation of engin

[Engine-patches] Change in ovirt-host-deploy[master]: tuned: Set tuned profile issue due to GlusterEnv.ENABLE env ...

2013-07-29 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: tuned: Set tuned profile issue due to GlusterEnv.ENABLE env var issue .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17416 To unsubscribe, vi

[Engine-patches] Change in ovirt-host-deploy[master]: tuned: Set tuned profile issue due to GlusterEnv.ENABLE env ...

2013-07-29 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: tuned: Set tuned profile issue due to GlusterEnv.ENABLE env var issue .. tuned: Set tuned profile issue due to GlusterEnv.ENABLE env var issue At the time of STA

[Engine-patches] Change in ovirt-engine[master]: packaging: Second time setup without cleanup is made configu...

2013-06-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Second time setup without cleanup is made configurable .. Patch Set 2: Alon, Sorry for incomplete information. Since you mentioned engine-setup2 is

[Engine-patches] Change in ovirt-engine[master]: packaging: Second time setup without cleanup is made configu...

2013-06-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Second time setup without cleanup is made configurable .. Patch Set 2: Thanks Sandro and Alon. That solves the issue then, when it(engine-setup2) wil

[Engine-patches] Change in ovirt-engine[master]: packaging: Second time setup without cleanup is made configu...

2013-06-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Second time setup without cleanup is made configurable .. Patch Set 2: Verified Alon, updated Bug-Url in commit message. -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: packaging: Second time setup without cleanup is made configu...

2013-06-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Second time setup without cleanup is made configurable .. Patch Set 1: Verified Hi Alon, A bug reported related to engine-setup. https://bugzilla.re

[Engine-patches] Change in ovirt-engine[master]: packaging: Second time setup without cleanup is made configu...

2013-06-05 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: packaging: Second time setup without cleanup is made configurable .. packaging: Second time setup without cleanup is made configurable Added new configuration in

[Engine-patches] Change in ovirt-host-deploy[master]: gluster: starting glusterd after install

2013-04-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: starting glusterd after install .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/14030 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-host-deploy[master]: gluster: starting glusterd after install

2013-04-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: starting glusterd after install .. Patch Set 1: (1 inline comment) File src/plugins/ovirt-host-deploy

[Engine-patches] Change in ovirt-host-deploy[master]: gluster: starting glusterd after install

2013-04-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: starting glusterd after install .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/14030 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-host-deploy[master]: gluster: starting glusterd after install

2013-04-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: starting glusterd after install .. Patch Set 1: No score (3 inline comments) File src/plugins/ovirt-

[Engine-patches] Change in ovirt-host-deploy[master]: gluster: starting glusterd after install

2013-04-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: gluster: starting glusterd after install .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/14030 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-host-deploy[master]: gluster: starting glusterd after install

2013-04-18 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: gluster: starting glusterd after install .. gluster: starting glusterd after install glusterd service was not started after installing. Added an event which will

[Engine-patches] Change in ovirt-engine-sdk-java[master]: sdk: do not append extra slash

2013-03-05 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: sdk: do not append extra slash .. Patch Set 1: (1 inline comment) File ovirt-engine-sdk-java/src/main/java/or

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer

2013-02-14 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 2: Verified Installed and tested 3.2 branch. Installer changes working fine. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer

2013-02-07 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 1: (1 inline comment) Updated cherry-pick message. ..

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer

2013-02-07 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 1: Yes, it is cherry-picked from master since merged in master. -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer

2013-02-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11801 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer

2013-02-06 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: packaging: Application Mode option in installer .. packaging: Application Mode option in installer Application Mode option added to engine-setup, Engine can be co

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-23 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 11: Verified Updated as per Juan Hernandez's comment. -- To view, visit http://gerrit.ovirt.org/9991

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-21 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 10: Updated as per Alex Lourie's suggestions: Changes: Main code(engine-setup.py) will not check V

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-20 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 9: Updated commit message. Now USE_DEFAULT option can be dynamic, so function name can be specified

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-18 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 8: Updated logic to hide the non gluster related questions from user when gluster APPLICATION_MODE is

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-16 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 7: Updated commit message. -- To view, visit http://gerrit.ovirt.org/9991 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-16 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 6: (1 inline comment) I tested in local machine and works as expected. ..

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-15 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 5: (3 inline comments) Will submit new patch set with the changes. ..

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2013-01-11 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 4: (6 inline comments) Updated the comments. Will submit new patch set with changes.

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2012-12-17 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 3: As discussed with Shireesh will submit new patch set with application mode setting as configurable

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2012-12-13 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 2: (1 inline comment) Option looks like Application Mode ['virt'| 'gluster'| 'both'] [both] :

[Engine-patches] Change in ovirt-engine[master]: packaging: Application Mode option in installer

2012-12-12 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: packaging: Application Mode option in installer .. Patch Set 1: Updated subject in commit message, submitted patch set 2 -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: engine: Application Mode option in installer

2012-12-12 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: engine: Application Mode option in installer .. engine: Application Mode option in installer Application Mode option added to engine-setup, Engine can be configur

[Engine-patches] Change in ovirt-log-collector[master]: tools: adding gluster logs

2012-12-09 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: tools: adding gluster logs .. Patch Set 2: (2 inline comments) Removed gluster_enabled set method and added the logic to set gluster_enabled flag in init method i

[Engine-patches] Change in ovirt-log-collector[master]: tools: adding gluster logs

2012-12-06 Thread avishwan
Aravinda VK has posted comments on this change. Change subject: tools: adding gluster logs .. Patch Set 1: (1 inline comment) Updated the code as per Shireesh's suggestion. Simplified logic to pass whole cluster object(name, i

[Engine-patches] Change in ovirt-log-collector[master]: tools: adding gluster logs

2012-12-06 Thread avishwan
Aravinda VK has uploaded a new change for review. Change subject: tools: adding gluster logs .. tools: adding gluster logs Gluster logs support added to hypervisors, collects gluster logs only if gluster is enabled in respective