Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: use vdscli instead of vdsClient
..
Patch Set 1:
The first few changes do not look like completely tied to the commit message
intention. Could you
Antoni Segura Puimedon has posted comments on this change.
Change subject: frontend: Fix disk creation NPE on diskprofile selection
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33802
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: frontend: Fix disk creation NPE on diskprofile selection
..
Patch Set 1:
Vojtech proposed the patch because it was failing on my hosted engine
deployme
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: frontend: Fix disk creation NPE on diskprofile selection
..
frontend: Fix disk creation NPE on diskprofile selection
I was getting a NullPointer Except
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: updated network configuration
..
Patch Set 1:
looks fine
--
To view, visit http://gerrit.ovirt.org/32861
To unsubscribe, visit http://gerrit.
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: updated network configuration
..
Patch Set 1:
the default dummy filter shows as nics those named dummy_x where x is a number,
did you change t
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: updated network configuration
..
Patch Set 1: Code-Review+1
these files look ok.
--
To view, visit http://gerrit.ovirt.org/32861
To unsubscri
Antoni Segura Puimedon has posted comments on this change.
Change subject: Update engine's mgmt net to have the correct vlan id
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/32269/7/src/plugins/ovirt-hosted-engine-se
Antoni Segura Puimedon has posted comments on this change.
Change subject: Update engine's mgmt net to have the correct vlan id
..
Patch Set 5:
Sorry about that, there is an extra DEFAULT
--
To view, visit http://gerrit.ovirt
Antoni Segura Puimedon has posted comments on this change.
Change subject: Update engine's mgmt net to have the correct vlan id
..
Patch Set 2:
Good to know. I'll have to refactor :(
--
To view, visit http://gerrit.ovirt.org/
Antoni Segura Puimedon has posted comments on this change.
Change subject: Update engine's mgmt net to have the correct vlan id
..
Patch Set 1:
Lior may want to confirm, but I think if you just do a deployment over a vlan
(tha
Antoni Segura Puimedon has posted comments on this change.
Change subject: Update engine's mgmt net to have the correct vlan id
..
Patch Set 1:
needs testing still :P
--
To view, visit http://gerrit.ovirt.org/32269
To unsubsc
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Update engine's mgmt net to have the correct vlan id
..
Update engine's mgmt net to have the correct vlan id
Up until now, when setting the management
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 8: Verified+1
I had made a mistake pushing 6 and 7, what was verified was version 5 that is
equal
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 6: Verified+1
I tested it with vlans and bonds. Sometimes I get a libvirt connection broken,
but
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 4:
I'm trying to verify it with just a bond and a vlan over a bond, but it is not
that easy to ge
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 4:
Verified with the selected device being a nic. Will try to get an environment
ready for testin
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 2:
It slipped my mind. I'll put it back on the todo.
--
To view, visit http://gerrit.ovirt.org/2
Antoni Segura Puimedon has posted comments on this change.
Change subject: Filter out duplicated network adapters on Windows
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30224
To unsubscribe, visit h
Antoni Segura Puimedon has posted comments on this change.
Change subject: Filter out duplicated network adapters on Windows
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30095
To unsubscribe, visit h
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28595/1/src/plugins/ovirt-hosted-engine-setup/network/
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_config: use vdscli and setupNetworks
..
Patch Set 1: Verified-1
I noticed that we do not currently report a 'gateway' field for networks and
devices
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: net_config: use vdscli and setupNetworks
..
net_config: use vdscli and setupNetworks
This patch replaces the usage of the vdsm command line interface
w
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine: Serialize null QoS to empty dictionary entry
..
Patch Set 1: Code-Review+1
Looks good to me ;-)
--
To view, visit http://gerrit.ovirt.org/2595
Antoni Segura Puimedon has posted comments on this change.
Change subject: packaging: setup: bridge: support tagged VLANs and bond
..
Patch Set 4:
@Sandro: I'd need to see the output of vdsClient -s 0 getVdsCaps to know
--
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: packaging: setup: bridge: support tagged VLANs
..
Patch Set 2: Code-Review-1
(3 comments)
Some small things
http://gerrit.ovirt.org/#/c/25894/2/src/pl
Antoni Segura Puimedon has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 4:
@Eyal: It is not executed by default. So it won't affect any test that does not
call it. In fact, it does not a
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine_page: use vdsm to detect mgmt interface
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24417
To unsubscribe, visit http
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine_page: use vdsm to detect mgmt interface
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24417/4/src/engine_page.py
File sr
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine_page: use vdsm to detect mgmt interface
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24417
To unsubscribe, visit http
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine_page: use vdsm to detect mgmt interface
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24417/2/src/engine_page.py
File src/engine_page.
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine_page: use vdsm to detect mgmt interface
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24417/2/src/engine_page.py
File sr
Antoni Segura Puimedon has posted comments on this change.
Change subject: engine_page: use vdsm to detect mgmt interface
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24417
To unsubscribe, visit http
Antoni Segura Puimedon has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 4: Verified+1
It ran on http://jenkins.ovirt.org/job/vdsm_network_functional_tests/711/console
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: network cleanup scripts
..
Patch Set 1:
(4 comments)
Thanks for the review!
File scripts/net_clea
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: network cleanup scripts
..
network cleanup scripts
This scripts help with cleaning up after failed network functional
tests.
Change-Id: Ib2d300af57d78
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: pacakges: stop network manager before starting network
..
Patch Set 1:
Yes, This is probably safer. I'm not sure though, what's going to happen wi
Antoni Segura Puimedon has posted comments on this change.
Change subject: ensure NetworkManager is disabled in F19
..
Patch Set 2: Looks good to me, but someone else must approve
Didn't realize it was an offline installation.
Antoni Segura Puimedon has posted comments on this change.
Change subject: ensure NetworkManager is disabled in F19
..
Patch Set 2: (1 inline comment)
File ovirt-node-plugin-
Antoni Segura Puimedon has posted comments on this change.
Change subject: ensure NetworkManager is disabled in F19
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
mask doesn't make it stop, it on
Antoni Segura Puimedon has posted comments on this change.
Change subject: packaging: spec: all-in-one: do not allow disabling
NetworkManager
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit h
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: packages: do not re-start network service
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: packages: do not re-start network service
..
Patch Set 1: Looks good to me, but someone else must approve
Yes. That should do it ;-)
--
To view,
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: packages: disable NetworkManager service by default
..
Patch Set 1: Looks good to me, but someone else must approve
I was confirming the state of
Antoni Segura Puimedon has posted comments on this change.
Change subject: host-deploy: fix typo
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17282
To unsubscribe, v
Antoni Segura Puimedon has posted comments on this change.
Change subject: Do not raise an Exception processing stdout/err
..
Patch Set 2: Verified
Verified for the wrong bytes returned by nmcli.
--
To view, visit http://gerri
Antoni Segura Puimedon has posted comments on this change.
Change subject: Do not raise an Exception processing stdout/err
..
Patch Set 1:
Good suggestion with the errors='replace'. I can confirm that it works for
python 2.7.3
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Do not raise an Exception processing stdout/err
..
Do not raise an Exception processing stdout/err
Some commands can output characters that are not dec
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10218
To unsubscribe, visit http://gerrit.o
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fixed support for reporting devices with only ipv6.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10223
To unsubscribe, visit http:
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 1:
Here are the differences in the code as found by pydiff:
antoni@nx01 ~/code/ovirt-guest-agent
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fix pep8 errors in the linux guest agent.
..
Fix pep8 errors in the linux guest agent.
Cleanup of the code to bring it up to standards of the rest of o
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fixed support for reporting devices with only ipv6.
..
Fixed support for reporting devices with only ipv6.
Change-Id: I92010740da24bb30c7316c268c704d90
53 matches
Mail list logo
