Asaf Shakarchi has uploaded a new change for review.
Change subject: build: Consolidate static plugins version into properties.
..
build: Consolidate static plugins version into properties.
Consolidation of all plugin versions
Asaf Shakarchi has submitted this change and it was merged.
Change subject: build: Explicit versions definitions for maven plugins.
..
build: Explicit versions definitions for maven plugins.
Maven 3.x deprecates definition of
Asaf Shakarchi has posted comments on this change.
Change subject: build: Explicit versions definitions for maven plugins.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14289
To
Asaf Shakarchi has posted comments on this change.
Change subject: build: Explicit versions definitions for maven plugins.
..
Patch Set 1:
I already done that in another patch.
@Eyal, it is still waiting for your verification
Asaf Shakarchi has uploaded a new change for review.
Change subject: build: Explicit versions definitions for maven plugins.
..
build: Explicit versions definitions for maven plugins.
Maven 3.x deprecates definition of plugins
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Change executed method name in frontend callbacks
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14254
To
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
engine: Propagate error message when quering for LDAP users/groups
Propagating
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 4: (5 inline comments
Asaf Shakarchi has posted comments on this change.
Change subject: userportal : User has insufficient permissions on url
/domain/domain_id/user
..
Patch Set 1: (3 inline comments
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/141
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/141
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/141
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/141
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/141
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
Patch Set 2: (3 inline comments
Asaf Shakarchi has abandoned this change.
Change subject: engine: putIfAbsent in EnumUtils.valueOf is ignored.
..
Patch Set 1: Abandoned
Irrelevant, fixed through other findbugs commits.
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: WIP: working CDI solution for backend
..
Patch Set 4:
Adding myself into this:
This is good stuff, I personally would love to see DI/IOC inside backend (btw
Asaf Shakarchi has posted comments on this change.
Change subject: core: Compatibility of db scripts with MacOS.
..
Patch Set 2: (2 inline comments)
File backend/manager
Asaf Shakarchi has posted comments on this change.
Change subject: core: Compatibility of dbfunctions.sh with MacOS.
..
Patch Set 1:
The locale param may be redundant, by default the collate / ctype are copied
from the
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: Compatibility of dbfunctions.sh with MacOS.
..
core: Compatibility of dbfunctions.sh with MacOS.
- New parameter (-c) to define the locale collate of
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin,userportal: No need for gwt-plugin.extraJvmArgs in
gwt-extension
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Removal of code related to importing SAN storage domains
..
engine: Removal of code related to importing SAN storage domains
This patch
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Asaf Shakarchi has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1: Looks good to me, approved
Just verified, its ok, regarding logging, it's always possible to d
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
..
engine: Corrections to Event.equal to avoid confusions and
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1:
I only see 'slf4j' in Fedora (no slf4j-log4j), I'd like to have the same
Asaf Shakarchi has posted comments on this change.
Change subject: core: AsyncTaskDAO proper newline logging
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12112
To unsubscribe, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin,userportal: gwt-maven-plugin POM cleanup
..
webadmin,userportal: gwt-maven-plugin POM cleanup
This patch eliminates some duplicities in
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin,userportal: gwt-maven-plugin POM cleanup
..
Patch Set 2: Verified; Looks good to me, approved
Thanks Vojtech.
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Changed DateFormatCompat class in uioverrides to
DateFormat
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
..
engine: Propagate error message when quering for LDAP users/groups
Propagating error
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Bypassing findbugs issue of incorrect lazy
initialization.
..
webadmin: Bypassing findbugs issue of incorrect lazy initialization.
Findbug
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Bypassing findbugs issue of incorrect lazy
initialization.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit
..
webadmin: A NPE check in SetupNetworksModel:onEdit
There's a possible branch of statement,
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11724
To
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: A NPE check in ImportVmModel:init method.
..
webadmin: A NPE check in ImportVmModel:init method.
There's a possible branch of stat
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A NPE check in ImportVmModel:init method.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11723
To
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Check for NPE in
AsyncDataProvider:GetInterfaceOptionsForEditNetwork
..
webadmin: Check for NPE in
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Check for NPE in
AsyncDataProvider:GetInterfaceOptionsForEditNetwork
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
..
webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
Fix for the static
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Renamed
EventListModel.forceRefresh->forceRefreshWithoutTimers.
..
webadmin: Renamed EventListModel.forceRefresh->forceRefreshWithout
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Renamed
EventListModel.forceRefresh->forceRefreshWithoutTimers.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit h
Asaf Shakarchi has submitted this change and it was merged.
Change subject: api: Current:currents needs to be static to avoid deadly
embrace.
..
api: Current:currents needs to be static to avoid deadly embrace.
Discovered by
Asaf Shakarchi has posted comments on this change.
Change subject: api: Current:currents needs to be static to avoid deadly
embrace.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Check fir NPE in
AsyncDataProvider:GetInterfaceOptionsForEditNetwork
..
webadmin: Check fir NPE in
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit
..
webadmin: A NPE check in SetupNetworksModel:onEdit
There's a possible branch of statement, th
Asaf Shakarchi has uploaded a new change for review.
Change subject: api: Current:currents needs to be static to avoid deadly
embrace.
..
api: Current:currents needs to be static to avoid deadly embrace.
Discovered by findbugs
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Bypassing findbugs issue of incorrect lazy
initialization.
..
webadmin: Bypassing findbugs issue of incorrect lazy initialization.
Findbug is
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
..
webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
Fix for the static invocation of
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: A NPE check in ImportVmModel:init method.
..
webadmin: A NPE check in ImportVmModel:init method.
There's a possible branch of statement, th
Asaf Shakarchi has uploaded a new change for review.
Change subject: webadmin: Renamed
EventListModel.forceRefrest->forceRefreshWithoutTimers.
..
webadmin: Renamed EventListModel.forceRefrest->forceRefreshWithout
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold
config var
..
engine: Fixed a spelling mistake in AuditLogAgingThreashold config var
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold
config var
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: build: GWT dependencies cleanups
..
build: GWT dependencies cleanups
- Defined GWT maven plugin in root POM plugin management section.
- Defined GWT
Asaf Shakarchi has posted comments on this change.
Change subject: build: GWT dependencies cleanups
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11227
To unsubscribe, visit
Asaf Shakarchi has submitted this change and it was merged.
Change subject: build: Removal of unsed gwt maven plugin repo.
..
build: Removal of unsed gwt maven plugin repo.
The removed repo is unused as the gwt maven plugin is
Asaf Shakarchi has posted comments on this change.
Change subject: build: Removal of unsed gwt maven plugin repo.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11226
To
Asaf Shakarchi has posted comments on this change.
Change subject: build: GWT dependencies cleanups
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11227
To unsubscribe, visit
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold
config var
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10970
To unsubscribe
Asaf Shakarchi has posted comments on this change.
Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2
..
Patch Set 2:
Doron: Forgot to mention that this plugin is not packed in fedora as it's a
r
Asaf Shakarchi has submitted this change and it was merged.
Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2
..
pom.xml: update findbugs mvn plugin version to latest 2.5.2
Change-Id
Asaf Shakarchi has posted comments on this change.
Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Ignore maven-ear-plugin in Eclipse
..
core: Ignore maven-ear-plugin in Eclipse
Eclipse doesn't have support for most of the parameters o
Asaf Shakarchi has posted comments on this change.
Change subject: core: Ignore maven-ear-plugin in Eclipse
..
Patch Set 6: Verified; Looks good to me, approved
Seems like this is the last plugin m2 complains during project
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 2:
Done, please note that according to the new translation workflow, based on
Asaf Shakarchi has posted comments on this change.
Change subject: core: Upgrade maven-checkstyle-plugin to 2.9.1
..
Patch Set 3:
Please forgive me, the message was intended for another maven change, you'r
good to go.
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin, userportal: Don't require path tweak in Eclipse
..
Patch Set 2: Looks good to me, approved
Thanks for clarifying this out. ack!
--
To view,
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin, userportal: Don't require path tweak in Eclipse
..
Patch Set 2:
Can you explain your last comment?
We'r talking about adding a very mini
Asaf Shakarchi has posted comments on this change.
Change subject: Removal of a deprecated Public API moudle references
..
Patch Set 1: (2 inline comments)
File frontend
Asaf Shakarchi has posted comments on this change.
Change subject: core: Upgrade maven-checkstyle-plugin to 2.9.1
..
Patch Set 3: Looks good to me, but someone else must approve
I don't really like the approach but I
Asaf Shakarchi has uploaded a new change for review.
Change subject: Removal of a deprecated Public API moudle references
..
Removal of a deprecated Public API moudle references
Removed references from all internal maven
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Removal of a deprecated Public API moudle.
..
engine: Removal of a deprecated Public API moudle.
This patch removes a deprecated Public API
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Removal of a deprecated Public API moudle.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10244
To
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
..
Patch Set 2: (4 inline comments)
Can't be moved to uicompat,
This cla
Asaf Shakarchi has uploaded a new change for review.
Change subject: build: Removal of unsed gwt maven plugin repo.
..
build: Removal of unsed gwt maven plugin repo.
The removed repo is unused as the gwt maven plugin is 2.3.0
Asaf Shakarchi has uploaded a new change for review.
Change subject: build: GWT dependencies cleanups
..
build: GWT dependencies cleanups
- Defined GWT maven plugin in root POM plugin management section.
- Defined GWT
Asaf Shakarchi has submitted this change and it was merged.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
restapi: A check for possible NPE BackendVmsResource:remove method
A check for
Asaf Shakarchi has posted comments on this change.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
webadmin: A check for possible NPE in NicActivateStatusColumn:getTooltip
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10957
To
Asaf Shakarchi has posted comments on this change.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10958
To unsubscribe
Asaf Shakarchi has posted comments on this change.
Change subject: restapi: A check for possible NPE BackendVmsResource:remove
method
..
Patch Set 1: (2 inline comments
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Replaced datastore checkConnection() impl.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10959
To unsubscribe, visit http
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Switched to the official GWT maven plugin
..
engine: Switched to the official GWT maven plugin
Switched maven GWT plugin to the official one
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Switched to the official GWT maven plugin
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10247
To
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Switched to the official GWT maven plugin
..
Patch Set 1:
Thanks, these changes will be pushed as apart of frontend modules versions
organization
Asaf Shakarchi has abandoned this change.
Change subject: engine: Define the right GWT version in root pom
..
Patch Set 1: Abandoned
This patch has been merged as a part of commit [32200ca6]
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Define the right GWT version in root pom
..
Patch Set 1:
Thanks for the review and the comment,
Regarding your comment, this will be done as a part of
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Fixed a spelling mistake in AuditLogAgingThreashold
config var
..
Patch Set 1: (1 inline comment
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: A check for possible NPE in
RemoveExternalEventCommand.canDoAction
..
engine: A check for possible NPE in
Asaf Shakarchi has posted comments on this change.
Change subject: engine: A check for possible NPE in
RemoveExternalEventCommand.canDoAction
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
..
Patch Set 1: (1 inline comment
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Changed Event.equal signature to override Object.equal
..
Patch Set 1:
Moty/Allon, great review, thanks.
The equality comparison you've mentione
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Assigned resultset to a local var in
StandaloneDataSource:checkConnection()
..
Patch Set 1: (1 inline comment
1 - 100 of 325 matches
Mail list logo
