Martin Mucha has uploaded a new change for review.
Change subject: core: MultipleActionsRunner refactor: extracted
initCommandsAndReturnValues method from execute()
..
core: MultipleActionsRunner refactor: extracted initCommands
Martin Mucha has uploaded a new change for review.
Change subject: core: MultipleActionsRunner refactor: extracted canRunActions
method from execute()
..
core: MultipleActionsRunner refactor: extracted canRunActions method from
Martin Mucha has uploaded a new change for review.
Change subject: core: MultipleActionsRunner refactor: extracted canRunActions
method from execute()
..
core: MultipleActionsRunner refactor: extracted canRunActions method from
automat...@ovirt.org has posted comments on this change.
Change subject: core: MultipleActionsRunner refactor: extracted canRunActions
method from execute()
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bu
automat...@ovirt.org has posted comments on this change.
Change subject: core: MultipleActionsRunner refactor: extracted
initCommandsAndReturnValues method from execute()
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url fo
automat...@ovirt.org has posted comments on this change.
Change subject: core: Added SerialMultipleActionsRunner
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Martin Mucha has uploaded a new change for review.
Change subject: core: Added SerialMultipleActionsRunner
..
core: Added SerialMultipleActionsRunner
There are Commands written in a way disallowing separating method
calls of 'ca
automat...@ovirt.org has posted comments on this change.
Change subject: core: MultipleActionsRunner refactor: extracted canRunActions
method from execute()
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tes
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 6:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-Url::OK
* Check P
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: filters: add Prefer new-auth option
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20715/ :
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 5: Verified+1
+ verified as dependent patch works
--
To view, visit http://gerrit.ovirt.org/35069
To
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: filters: add Prefer new-auth option
..
Patch Set 2: Verified+1
+ verified as dependent patch works
--
To view, visit http://gerrit.ovirt.org/35188
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 2: Code-Review+1
(1 comment)
+1 for logic
http://gerrit.ovirt.org/#/c/35185/2/fronte
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 2:
Initial HTTP request to create REST session that maps to existing Engine
session:
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 2:
Patch updated to take advantage of Prefer:new-auth option when acquiring new
REST
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 2:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-U
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 5:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-Url::OK
* Check P
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: filters: add Prefer new-auth option
..
Patch Set 2:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-Url::OK
* Check Public
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: filters: add Prefer new-auth option
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20714/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20
Vojtech Szocs has posted comments on this change.
Change subject: aaa: filters: add Prefer new-auth option
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35188
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has uploaded a new change for review.
Change subject: aaa: filters: add Prefer new-auth option
..
aaa: filters: add Prefer new-auth option
this enforces opening a new http session, this is useful when remote
wants t
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: filters: add Prefer new-auth option
..
Patch Set 1:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 4:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-Url::OK
* Check P
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 1:
As discussed with Alon, to avoid errors like 2nd login causing still-valid
(unclo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 1:
Forgot to mention in above comment that "Keep-alive HTTP request to maintain
exis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 1: Verified+1
Verified both login & auto-login use cases.
Initial HTTP request to cr
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: enable accept engine session using header
..
Patch Set 3:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-Url::OK
* Check P
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Use existing Engine session for REST API integration
..
Patch Set 1:
* Update tracker::#1161734::OK
* Update tracker::#1161730::OK
* Check Bug-U
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Use existing Engine session for REST API integration
..
webadmin: Use existing Engine session for REST API integration
Before this patch
=
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, frontend: removal of VdcRole
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, webamin: Renaming VdcBllMessages
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-te
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Renaming VdcBllErrors
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/
automat...@ovirt.org has posted comments on this change.
Change subject: core: Renaming VdcBllErrors
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
automat...@ovirt.org has posted comments on this change.
Change subject: core, frontend: removal of VdcRole
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
automat...@ovirt.org has posted comments on this change.
Change subject: core, webamin: Renaming VdcBllMessages
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Yair Zaslavsky has uploaded a new change for review.
Change subject: core, webamin: Renaming VdcBllMessages
..
core, webamin: Renaming VdcBllMessages
Renaming to EngineBllMessage -
a. Lets try and move to more "modern" terminolo
Yair Zaslavsky has uploaded a new change for review.
Change subject: core, frontend: removal of VdcRole
..
core, frontend: removal of VdcRole
This class is not in use any more
Change-Id: I0b3cac746c2cc7a5a594f4b401cbe9d7f40da2f
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Fix exception on VM status column
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20707
Alexander Wels has posted comments on this change.
Change subject: webadmin: Fix exception on VM status column
..
Patch Set 1: Verified+1
This would not break functionality but in the console there are tons of
exceptions.
--
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Fix exception on VM status column
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Fix exception on VM status column
..
webadmin: Fix exception on VM status column
- When hovering over or clicking on the status column in
the VM ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Store subtab in browser
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20706/ :
SUCCE
Alexander Wels has posted comments on this change.
Change subject: webadmin: Store subtab in browser
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35178
To unsubscribe, visit http://gerrit.ovirt.org/sett
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Store subtab in browser
..
Patch Set 1:
* Update tracker::#1140249::OK
* Check Bug-Url::OK
* Check Public Bug::#1140249::OK, public bug
* Check
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Store subtab in browser
..
webadmin: Store subtab in browser
- This patch adds the ability to store the subtab height in
the browser local storage.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Adding auth and principal records on session
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Adding auth and principal records on session
..
Patch Set 2: Code-Review+1
you understood... thanks!
--
To view, visit http://gerrit.ovirt.org/35169
To uns
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Adding auth and principal records on session
..
Patch Set 2:
* Update tracker::#1163147::OK
* Check Bug-Url::OK
* Check Public Bug::#1163147::OK, pub
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Adding auth and principal records on session
..
Patch Set 1:
Eventually all paths will drain to the method attachUserToSession,
The filters pass the requi
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding several CDA messages in single method
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/35164
To unsubscribe, visit http://gerr
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: remove legacy osinfo.py file
..
Patch Set 2: Code-Review+1
Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: remove legacy osinfo.py file
..
Patch Set 2: Code-Review+1
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-q
Martin Betak has posted comments on this change.
Change subject: userportal,webadmin: list models managed by GIN
..
Patch Set 17: Code-Review+1
Excellent patch, Alex! Thank you for making DI in uicommon a reality.
--
To view,
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 10: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/33770
To unsubscribe, visit http://gerrit.ovirt.org
Martin Betak has posted comments on this change.
Change subject: packaging: remove legacy osinfo.py file
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35142
To unsubscribe, visit http://gerrit.ovirt.org/
Martin Betak has posted comments on this change.
Change subject: packaging: remove legacy osinfo.py file
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35142/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/l
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: remove legacy osinfo.py file
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Martin Betak has posted comments on this change.
Change subject: frontend: Introduce GinUiBinder
..
Patch Set 2:
Hi Vojtech,
As for the @Inject of UiBinder and IdHandler a converse argument about
efficiency can be made that w
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20704/ :
S
Martin Betak has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 9:
(2 comments)
http://gerrit.ovirt.org/#/c/33770/9/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 10:
* Update tracker::#975730::OK
* Check Bug-Url::OK
* Check Public Bug::#975730::OK, public bug
* Chec
Martin Betak has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/33770
To unsubscribe, visit http://gerrit.ovirt.org/se
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core : Introduce engine_sessions table and DAO
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master
Alon Bar-Lev has posted comments on this change.
Change subject: core : Introduce engine_sessions table and DAO
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/35148/2/packaging/dbscripts/engine_sessions_sp.sql
File p
Ravi Nori has posted comments on this change.
Change subject: core : Introduce engine_sessions table and DAO
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/35148/1/backend/manager/modules/dal/src/main/java/org/ovirt/
Ravi Nori has posted comments on this change.
Change subject: core : Introduce engine_sessions table and DAO
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/35148
To unsubscribe, visit http://gerrit.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Add support for auto-convergence and XBZRLE
compression
..
Patch Set 15: -Code-Review -Verified
Build Successful
http://jenkins.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed
properties
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master
automat...@ovirt.org has posted comments on this change.
Change subject: core : Introduce engine_sessions table and DAO
..
Patch Set 2:
* Update tracker::#1092744::OK
* Check Bug-Url::OK
* Check Public Bug::#1092744::OK, public
Moti Asayag has posted comments on this change.
Change subject: core: adding several CDA messages in single method
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35164
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Add support for auto-convergence and XBZRLE
compression
..
Patch Set 14: -Code-Review -Verified
Build Failed
http://jenkins.ovirt.org/job/
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: list models managed by GIN
..
Patch Set 17: Verified+1
This patch passed Selenium tests for WebAdmin & UserPortal on FF 31 (both Linux
& Wi
Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: list models managed by GIN
..
Patch Set 17: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34193
To unsubscribe, visit http://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Add support for auto-convergence and XBZRLE
compression
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no b
Martin Betak has posted comments on this change.
Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed
properties
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/32133
To unsubscribe
Martin Betak has posted comments on this change.
Change subject: frontend: Add support for auto-convergence and XBZRLE
compression
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/32495
To unsubscribe, vi
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed
properties
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Fix NPE on Template creation
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20698/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed
properties
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 9: Code-Review-1
one day the session id will be restricted to origin, and will not work from
other sources, it
automat...@ovirt.org has posted comments on this change.
Change subject: frontend: Add support for auto-convergence and XBZRLE
compression
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no b
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed
properties
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
Martin Betak has posted comments on this change.
Change subject: core: Fix NPE on Template creation
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35174
To unsubscribe, visit http://gerrit.ovirt.org/setti
automat...@ovirt.org has posted comments on this change.
Change subject: core: Fix NPE on Template creation
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Martin Betak has uploaded a new change for review.
Change subject: core: Fix NPE on Template creation
..
core: Fix NPE on Template creation
Change-Id: I0d9ed1719db7129be1f560068f8b8c2c707f3efa
Signed-off-by: Martin Betak
---
M
Simone Tiraboschi has posted comments on this change.
Change subject: remove password leak from ovirt-engine setup answer file
..
Patch Set 3: Code-Review+1
Looks good to me, but someone else must approve
--
To view, visit ht
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding host to DB before calling provision
..
Patch Set 1:
the bug is targeted to 3.5.0. it does a regression and blocker to the feature
--
To view, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add/Edit VM disks from VM dialog
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20697/ :
Ravi Nori has posted comments on this change.
Change subject: core : Introduce engine_sessions table and DAO
..
Patch Set 1:
@Alon
I think you are right.
How do we handle the case where a user has two sessions (login from 2 m
Vojtech Szocs has posted comments on this change.
Change subject: fix handling of admin user while login
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34551
To unsubscribe, visit http://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Add/Edit VM disks from VM dialog
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: refresh button wrapping
..
Patch Set 1: Code-Review+1
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Add/Edit VM disks from VM dialog
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/20696/
Sandro Bonazzola has posted comments on this change.
Change subject: remove password leak from ovirt-engine setup answer file
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/35172
To unsubscribe, visit htt
1 - 100 of 294 matches
Mail list logo
