Piotr Kliczewski has posted comments on this change.
Change subject: core: protocol fall back for older vdsms
..
Patch Set 2:
(4 comments)
@Alon - Please be more constructive and give a bit more details. I am happy to
discuss
Moti Asayag has posted comments on this change.
Change subject: engine: Add management field to network_cluster table
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32781
To unsubscribe, visit http://g
Moti Asayag has posted comments on this change.
Change subject: engine: Add management member to NetworkCluster business entity
class
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32772/2/backend/manager/modules/com
Oved Ourfali has posted comments on this change.
Change subject: core: retry fencing operation in case of failure
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33486
To unsubscribe, visit http://gerri
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.5.0
..
build: ovirt-engine-3.5.0
Change-Id: Ib6ce1d7d5d1afb59e64bc81bd3128c8b2ccb555d
Bug-Url: https://bugzilla.redhat.com/1073
automat...@ovirt.org has posted comments on this change.
Change subject: build: ovirt-engine-3.5.0
..
Patch Set 2:
* Update tracker::#1073943::OK
* Check TR::#1073943::OK
* Set MODIFIED::bug 1073943#1073943OK
--
To vi
Sandro Bonazzola has posted comments on this change.
Change subject: build: ovirt-engine-3.5.0
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33652
To unsubscribe, visit http://gerrit.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_fi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add NetworkAttachment dao
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/4221/
:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Change modifier of parameter to be more generic
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Extend Bond entity to contain slaves
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17478/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Use more abstracted collection type
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17484/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introduce HostSetupNetworksParameters parameters
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introduce BusinessEntityMap
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17483/ :
SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: HostSetupNetorks command #DRAFT#
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17479/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Deprecate SetupNetworks VDS related classes
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Expose GetCapabilities command via vdsbroker api
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Deprecate SetupNetworks command
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17482/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add NetworkAttachmentValidator
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17481/ : The
p
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Network attachments parameters completer
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17480
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introduce NetworkAttachment entity
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17475/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Add support for Network Attachements
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Add NetworkAttachment dao
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Deprecate SetupNetworks command
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: engine: HostSetupNetorks command #DRAFT#
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: core: Introduce BusinessEntityMap
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: core: Extend Bond entity to contain slaves
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: Add support for Network Attachements
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Use more abstracted collection type
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Add NetworkAttachmentValidator
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: core: Introduce NetworkAttachment entity
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Re-define HostSetupNetworks based on network attachments
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Network attachments parameters completer
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: core: Introduce HostSetupNetworksParameters parameters
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Change modifier of parameter to be more generic
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Expose GetCapabilities command via vdsbroker api
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Deprecate SetupNetworks VDS related classes
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: add query for getting vms from external provider
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: import vms from external provider
..
Patch Set 8:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17465/ : The
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: monitor conversion from v2v
..
Patch Set 5:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17464/ : The
patc
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: add 'import' functionality in vms tab
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: allow to import from external provider
..
Patch Set 8: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_ma
Allon Mureinik has posted comments on this change.
Change subject: restapi: Fix use of "unregistered" parameter
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33759
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introduce ImportVmCommandBase
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17466/ :
SUCC
automat...@ovirt.org has posted comments on this change.
Change subject: core: add query for getting vms from external provider
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: allow to import from external provider
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: core: import vms from external provider
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: core: introduce ImportVmCommandBase
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
automat...@ovirt.org has posted comments on this change.
Change subject: core: monitor conversion from v2v
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: add 'import' functionality in vms tab
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Arik Hadas has posted comments on this change.
Change subject: core: cleanup - removed stale JavaDoc params
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33799/2/backend/manager/modules/bll/src/main/java/org/ovirt/en
Arik Hadas has posted comments on this change.
Change subject: core: RunVmValidator storage allocation
..
Patch Set 2:
why is the stateless validation redundant?
--
To view, visit http://gerrit.ovirt.org/33800
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: update NetworkValidator logic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17463/ :
SU
Yevgeny Zaspitsky has uploaded a new change for review.
Change subject: engine: update NetworkValidator logic
..
engine: update NetworkValidator logic
Update NetworkValidator and DetachNetworkValidator logic to use
ManagementNet
automat...@ovirt.org has posted comments on this change.
Change subject: engine: update NetworkValidator logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: fix compiler warnings (unit test)
..
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17462/
Moti Asayag has posted comments on this change.
Change subject: utils: fix compiler warnings (unit test)
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33739
To unsubscribe, visit http://gerrit.ovirt.o
Tim Speetjens has posted comments on this change.
Change subject: utils: fix compiler warnings (unit test)
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33739/2/backend/manager/modules/utils/src/test/java/org/ovirt/e
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: fix compiler warnings (unit test)
..
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17461/
automat...@ovirt.org has posted comments on this change.
Change subject: utils: fix compiler warnings (unit test)
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Suppress warnings for deprecation and add appropriate
TODO message
..
Patch Set 4:
No Builds Executed
http://jenkins.ovirt.org/job/ovirt-engi
Moti Asayag has posted comments on this change.
Change subject: utils: Suppress warnings for deprecation and add appropriate
TODO message
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33685
To unsubs
Tim Speetjens has posted comments on this change.
Change subject: utils: Suppress warnings for deprecation and add appropriate
TODO message
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33685/2/backend/manager/modul
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update AddBondCommand logic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17457/ :
SUCC
Tim Speetjens has posted comments on this change.
Change subject: utils: Suppress warnings for deprecation and add appropriate
TODO message
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/33685/3/backend/manager/modu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Suppress warnings for deprecation and add appropriate
TODO message
..
Patch Set 4:
No Builds Executed
http://jenkins.ovirt.org/job/ovirt-engi
automat...@ovirt.org has posted comments on this change.
Change subject: utils: Suppress warnings for deprecation and add appropriate
TODO message
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WAR
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update UpdateStoragePoolCommand logic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/1745
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Update UpdateStoragePoolCommand logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Yevgeny Zaspitsky has uploaded a new change for review.
Change subject: engine: Update UpdateStoragePoolCommand logic
..
engine: Update UpdateStoragePoolCommand logic
Replace the call to legacy NetworkUtils.isManagementNetwork b
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Update AddBondCommand logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Yevgeny Zaspitsky has uploaded a new change for review.
Change subject: engine: Update AddBondCommand logic
..
engine: Update AddBondCommand logic
Replace the call to legacy NetworkUtils.isManagementNetwork by the
call to Manage
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: update RemoveNetworkParametersBuilder logic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerri
automat...@ovirt.org has posted comments on this change.
Change subject: engine: update RemoveNetworkParametersBuilder logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Yevgeny Zaspitsky has uploaded a new change for review.
Change subject: engine: update RemoveNetworkParametersBuilder logic
..
engine: update RemoveNetworkParametersBuilder logic
Remove usage of legacy NetworkUtils.isManagementN
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fix typos in test.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17455/ :
SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Change duplicate action type values to unique ones
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Change duplicate audit log values to unique ones
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add uniqueness test to AuditLogValue
..
Patch Set 2: -Code-Review -Verified
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tes
mooli tayer has uploaded a new change for review.
Change subject: core: fix typos in test.
..
core: fix typos in test.
Change-Id: I15a9c82059d4c470dc8de6b6c69ae1a818dedf25
Signed-off-by: Mooli Tayer
---
M
backend/manager/modul
automat...@ovirt.org has posted comments on this change.
Change subject: core: fix typos in test.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Omer Frenkel has posted comments on this change.
Change subject: core: add graphics device to management classes
..
Patch Set 20:
(2 comments)
http://gerrit.ovirt.org/#/c/28567/20/backend/manager/modules/bll/src/main/java/org/
automat...@ovirt.org has posted comments on this change.
Change subject: core: Add VdcActionType tests
..
Patch Set 1:
* Update tracker::#1145977::OK
--
To view, visit http://gerrit.ovirt.org/33807
To unsubscribe, visit http:
mooli tayer has abandoned this change.
Change subject: core: Add VdcActionType tests
..
Abandoned
This involves too much to backport.
See bug
--
To view, visit http://gerrit.ovirt.org/33807
To unsubscribe, visit http://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: core: Change duplicate action type values to unique ones
..
Patch Set 1:
* Update tracker::#1145977::OK
* Check Bug-Url::OK
* Check Public Bug::#1145977::
automat...@ovirt.org has posted comments on this change.
Change subject: core: Add uniqueness test to AuditLogValue
..
Patch Set 2:
* Update tracker::#1145977::OK
* Check Bug-Url::OK
* Check Public Bug::#1145977::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: core: Change duplicate audit log values to unique ones
..
Patch Set 2:
* Update tracker::#1145977::OK
* Check Bug-Url::OK
* Check Public Bug::#1145977::OK
Hello Tal Nisan,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33818
to review the following change.
Change subject: core: Change duplicate action type values to unique ones
..
core: Change duplic
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Update SetupNetworks backend logic
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/17454/
Omer Frenkel has posted comments on this change.
Change subject: engine: GraphicsInfo in entities
..
Patch Set 18: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28569
To unsubscribe, visit http://gerrit.ovirt.org/set
Omer Frenkel has posted comments on this change.
Change subject: core: Graphics Device CRUD
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/25409/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll
Omer Frenkel has posted comments on this change.
Change subject: core: Graphics Device CRUD
..
Patch Set 14: Code-Review+1
looks ok, just check the can do action comment
--
To view, visit http://gerrit.ovirt.org/25409
To unsu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add isManagementNetwork(String, Guid) to
ManagementNetworkUtil
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_ma
Roy Golan has posted comments on this change.
Change subject: core: VM Monitoring abstract fetching/analyzing/monitoring
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/28662/11/backend/manager/modules/vdsbroker/src/m
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Update SetupNetworks backend logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Yevgeny Zaspitsky has uploaded a new change for review.
Change subject: engine: Update SetupNetworks backend logic
..
engine: Update SetupNetworks backend logic
Update SetupNetworks backend logic to use ManagementNetworkUtils.
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Add isManagementNetwork(String, Guid) to
ManagementNetworkUtil
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add isManagementNetwork(String, Guid) to
ManagementNetworkUtil
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.or
Yevgeny Zaspitsky has uploaded a new change for review.
Change subject: engine: Add isManagementNetwork(String, Guid) to
ManagementNetworkUtil
..
engine: Add isManagementNetwork(String, Guid) to ManagementNetworkUtil
Add isMana
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Add isManagementNetwork(String, Guid) to
ManagementNetworkUtil
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
1 - 100 of 276 matches
Mail list logo
