Yaniv Bronhaim has posted comments on this change.
Change subject: ui: Fixing tab index
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-
automat...@ovirt.org has posted comments on this change.
Change subject: ui: Fixing tab index
..
Patch Set 1:
* Update tracker::#1115045::OK
* Check Bug-Url::OK
* Check Public Bug::#1115045::OK, public bug
* Check Product::#111
Yaniv Bronhaim has uploaded a new change for review.
Change subject: ui: Fixing tab index
..
ui: Fixing tab index
Change-Id: Ie183a178c86cbdfc58e52baf75700d44e5a40934
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115045
Arik Hadas has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/29620
To unsubscribe, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: avoid findbug issues for encoding and bare exceptions
catch
..
Patch Set 7: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: VmLogonCommand - remove redundant annotation
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/8238/ :
Karnan t c has posted comments on this change.
Change subject: gluster-nagios-monitoring : Fix for showDashboard incorrect
comparison
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29443
To unsubscrib
automat...@ovirt.org has posted comments on this change.
Change subject: core: avoid findbug issues for encoding and bare exceptions
catch
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bu
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Missing hostId parameter on reconstructMaster
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29511
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: VmLogonCommand - remove redundant annotation
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29623
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Generate CommandContext on engine restart
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29565
To unsubscribe, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 6:
not sure, where di u asnwer my "package access modified" questions?
--
To view, visit http://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: core: VmLogonCommand - remove redundant annotation
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Daniel Erez has uploaded a new change for review.
Change subject: core: VmLogonCommand - remove redundant annotation
..
core: VmLogonCommand - remove redundant annotation
VmLogonCommand is invoked only from client (UserPortal/RE
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29477
To unsubscribe, visit http://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Daniel Erez has submitted this change and it was merged.
Change subject: core: VmLogonCommand - missing constructor
..
core: VmLogonCommand - missing constructor
VmLogonCommand is invoked only from client (UserPortal/REST),
hen
Oved Ourfali has posted comments on this change.
Change subject: core: avoid findbug issues for encoding and bare exceptions
catch
..
Patch Set 6:
you have an unused import...
--
To view, visit http://gerrit.ovirt.org/28824
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: avoid findbug issues for encoding and bare exceptions
catch
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job
automat...@ovirt.org has posted comments on this change.
Change subject: core: avoid findbug issues for encoding and bare exceptions
catch
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bu
Yaniv Bronhaim has posted comments on this change.
Change subject: core: avoid findbug issues for encoding and bare exceptions
catch
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28824/5/backend/manager/modules/bll/
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Missing hostId parameter on reconstructMaster
..
Patch Set 1:
@Nir, @Piotr - can we merge that?
--
To view, visit http://gerrit.ovirt.org/29511
To unsu
Oved Ourfali has posted comments on this change.
Change subject: aaa: changed location of engine context.
..
Patch Set 2:
Only question is whether you see any potential of issues due to this one. If
not, I'm okay to merge. If
Oved Ourfali has posted comments on this change.
Change subject: engine: Added AutoCloseableLock
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29617
To unsubscribe, visit http://gerrit.ovirt.org/setti
Oved Ourfali has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
I closed this bug.
It can be a regression, but it wasn't a good behavior to begin with, so that's
why I closed
Oved Ourfali has posted comments on this change.
Change subject: engine : NPE while using reflection for AsyncTask type
..
Patch Set 2:
Ravi - please verify and I'll merge this.
--
To view, visit http://gerrit.ovirt.org/29156
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Modify constructor to be compatible with caller method
..
Patch Set 4:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tes
Yair Zaslavsky has posted comments on this change.
Change subject: core: Modify constructor to be compatible with caller method
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29554
To unsubscribe, visi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Modify constructor to be compatible with caller method
..
core: Modify constructor to be compatible with caller method
ConnectDomainToStorageComm
automat...@ovirt.org has posted comments on this change.
Change subject: core: Modify constructor to be compatible with caller method
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Yair Zaslavsky has posted comments on this change.
Change subject: engine : NPE while using reflection for AsyncTask type
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29156
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
please discuss bug at bug. gerrit is not the place. the entire record should be
at one place.
thank you.
--
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
I disagree. imo using regression keyword here is great! there is a reason
'user@domain' is acceptable, people
Yair Zaslavsky has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 1: Code-Review+2
Then please do remove this annotation, if only clients invoke this command.
Thanks!
-
Yair Zaslavsky has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
IMHO keeping bad behavior along versions, and fixing it is not a regression,
and the "regression" term is so
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added AutoCloseableLock
..
Patch Set 1:
Nice,
Once again, I recommend you email devel about such changess.
You have selected a very short list of mainta
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added AutoCloseableLock
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29617
To unsubscribe, visit http://gerrit.ovirt.org/set
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: virt-sparsify integration in ovirt-engine
..
Patch Set 1:
No Builds Executed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ger
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: virt-sparsify integration in ovirt-engine
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Moti Asayag has posted comments on this change.
Change subject: engine: Validate network provider properties
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/29520
To unsubscribe, visit http://gerrit.ovirt.
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
@Alon, the bug is closed, you may reopen :)
--
To view, visit http://gerrit.ovirt.org/29613
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
> again... why do we need to use heuristics if we have two fields?
we had 2 fields in 3.4 also, and 'admin@in
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
please discuss bug at bug.
--
To view, visit http://gerrit.ovirt.org/29613
To unsubscribe, visit http://gerri
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
@Einav, @Vojtech,
Please see https://bugzilla.redhat.com/show_bug.cgi?id=1112252#c7 , the issue
raised in th
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-lates
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
> We should rename 'internal' to 'ovirt-internal', I believe that it's "safe"
> enough.
again... why do we ne
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
@Oved, I'd like to have a second opinion from Einav and Vojtech, before opening
it in the bug.
Thanks :-)
-
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
> no... user enters admin@internal... now re-try :)
We should rename 'internal' to 'ovirt-internal', I believ
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_t
Project:
http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3476/
Build Number: 3476
Build Status: Failure
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29620
---
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engi
automat...@ovirt.org has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 3:
* Update tracker::#1112359::OK
* Check Bug-Url::OK
* Check Public Bug::#1112359::O
automat...@ovirt.org has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 2:
* Update tracker::#1112359::OK
* Check Bug-Url::OK
* Check Public Bug::#1112359::O
automat...@ovirt.org has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 1:
* Update tracker::#1112359::OK
* Check Bug-Url::OK
* Check Public Bug::#1112359::O
Arik Hadas has uploaded a new change for review.
Change subject: core: clear migrating_to_vds after successful migration
..
core: clear migrating_to_vds after successful migration
We used to clear this field only upon failed mig
automat...@ovirt.org has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 3: Verified-1
* Update tracker::#1112359::OK
* Check Bug-Url::OK
* Check Public Bug::
Maor Lipchuk has posted comments on this change.
Change subject: core: Allow attach of Storage Domain when retrieve fails
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/29563/5/backend/manager/modules/bll/src/main/jav
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
> @Oved, imo, the bug should be reopened.
please discuss that on bug... explain exactly why it is needed. than
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
> admin@internal@directory1 is valid, but I won't split it because directory1
> should be in the domain list.
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
@Oved, imo, the bug should be reopened.
* it's a regression.
* you cannot have a cookie for user+domain, UX
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
>> Do you want admin@internal in user's input to work?
> no. how can you know if internal is part of the user
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Whitespace fixes in MacPoolManagerRanges
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/1
Oved Ourfali has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
As per Alon's comment on the bug I think we can abandon this patch. I've closed
the bug.
--
To view, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Added AutoCloseableLock
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11697/ :
SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
> Do you want admin@internal in user's input to work?
no. how can you know if internal is part of the user or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Use AutoCloseableLock in MacPoolManagerRanges
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-lates
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Added AutoCloseableLock
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Use AutoCloseableLock in MacPoolManagerRanges
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: engine: Whitespace fixes in MacPoolManagerRanges
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Use AutoCloseableLock in MacPoolManagerRanges
..
engine: Use AutoCloseableLock in MacPoolManagerRanges
Refactored MacPoolManagerRanges to use the AutoCl
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Added AutoCloseableLock
..
engine: Added AutoCloseableLock
This wrapper class will allow writing cleaner code, instead of:
lock.lock();
try {
// Thr
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Whitespace fixes in MacPoolManagerRanges
..
engine: Whitespace fixes in MacPoolManagerRanges
Removed unnecessary lines where not needed, and added where
Project:
http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms-quick_gerrit/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms-quick_gerrit/515/
Build Number: 515
Build Status: Failure
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29616
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-lates
Gilad Chaplik has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
Do you want admin@internal in user's input to work?
--
To view, visit http://gerrit.ovirt.org/29613
To unsub
Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_dao-unit-tests_gerrit/
Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_dao-unit-tests_gerrit/408/
Build Number: 408
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29616
---
Project:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/401/
Build Number: 401
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29616
---
Project:
http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms-quick_gerrit/label=fedora19/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms-quick_gerrit/label=fedora19/515/
Build Number: 515
Build Status: Failure
Triggered By: Started by upstream project
"ovirt-engine_3.4
Project:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/label=db_slave/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/label=db_slave/401/
Build Number: 401
Build Status: Fixed
Triggered By: Started by upstream project
"ovirt_engine_3
automat...@ovirt.org has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 2: Verified-1
* Update tracker::#1112359::OK
* Check Bug-Url::OK
* Check Public Bug::
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: login: split user@domain
..
Patch Set 2:
why it this needed?
--
To view, visit http://gerrit.ovirt.org/29613
To unsubscribe, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11696/
Project:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/label=db_slave/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/label=db_slave/400/
Build Number: 400
Build Status: Failure
Triggered By: Started by upstream project
"ovirt_engine
Project:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_3.4_update-db-to-latest_gerrit/400/
Build Number: 400
Build Status: Failure
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29616
-
automat...@ovirt.org has posted comments on this change.
Change subject: core: clear migrating_to_vds after successful migration
..
Patch Set 1: Verified-1
* Update tracker::#1112359::OK
* Check Bug-Url::OK
* Check Public Bug::
Arik Hadas has uploaded a new change for review.
Change subject: core: clear migrating_to_vds after successful migration
..
core: clear migrating_to_vds after successful migration
We used to clear this field only upon failed mig
Daniel Erez has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29614
To unsubscribe, visit http://gerrit.ovirt.or
Lior Vernia has posted comments on this change.
Change subject: restapi: add usages field to "add network to data-center"
action params
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/29447/2/backend/manager/modules/r
Lior Vernia has posted comments on this change.
Change subject: restapi: remove display field from add network to data-center
action parameters
..
Patch Set 1:
(1 comment)
Juan, please note inline comment, not sure what the r
Omer Frenkel has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29614
To unsubscribe, visit http://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: core: VmLogonCommand - missing constructor
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Daniel Erez has uploaded a new change for review.
Change subject: core: VmLogonCommand - missing constructor
..
core: VmLogonCommand - missing constructor
VmLogonCommand is invoked only from client (UserPortal/REST),
hence, a mi
Lior Vernia has posted comments on this change.
Change subject: webadmin: Network dialog- default/custom mtu as radio buttons
..
Patch Set 9:
(15 comments)
http://gerrit.ovirt.org/#/c/28099/9/frontend/webadmin/modules/uicommon
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: filter engine db password
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/8236/ :
Moti Asayag has posted comments on this change.
Change subject: restapi: remove display field from add network to data-center
action parameters
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29448
To
Moti Asayag has posted comments on this change.
Change subject: restapi: remove display field from add network to data-center
action parameters
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29448/1//COMMIT_MSG
Commi
Moti Asayag has posted comments on this change.
Change subject: restapi: add usages field to "add network to data-center"
action params
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29447/1/backend/manager/modules/r
1 - 100 of 261 matches
Mail list logo
