[Engine-patches] Change in ovirt-engine[master]: core: make constants class ctor private

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: make constants class ctor private .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5912/ :

[Engine-patches] Change in ovirt-engine[master]: core: make constants class ctor private

2014-04-20 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: make constants class ctor private .. core: make constants class ctor private Change-Id: Ifef9264b2bfb39150cbcdde2efe376bfde3861b5 Signed-off-by: Liron Aravot

[Engine-patches] Change in ovirt-engine[master]: core: make constants class ctor private

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: make constants class ctor private .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-eng

[Engine-patches] Change in ovirt-engine[master]: core: set volume description to reflect ovf store status

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: set volume description to reflect ovf store status .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests

[Engine-patches] Change in ovirt-engine[master]: core: set volume description to reflect ovf store status

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: set volume description to reflect ovf store status .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored

[Engine-patches] Change in ovirt-engine[master]: core: set volume description to reflect ovf store status

2014-04-20 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: set volume description to reflect ovf store status .. core: set volume description to reflect ovf store status Change-Id: I09fc7ab550cd86e7843656ba92a532216570

[Engine-patches] Change in ovirt-engine[master]: engine: Improve iSCSI Bond CDA validation

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5910/ :

[Engine-patches] Change in ovirt-engine[master]: restapi: Add REST API support for iSCSI multipathing

2014-04-20 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: restapi: Add REST API support for iSCSI multipathing .. Patch Set 3: Verified+1 I provided another patch to prevent managing iSCSI Bonds for datacenters < 3.4 -

[Engine-patches] Change in ovirt-engine[master]: engine: Improve iSCSI Bond CDA validation

2014-04-20 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation .. Patch Set 1: I still have to add unitests, but the general idea is - now, when iSCSI Bonds are supported via REST A

[Engine-patches] Change in ovirt-engine[master]: engine: Improve iSCSI Bond CDA validation

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-e

[Engine-patches] Change in ovirt-engine[master]: engine: Improve iSCSI Bond CDA validation

2014-04-20 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: engine: Improve iSCSI Bond CDA validation .. engine: Improve iSCSI Bond CDA validation Returns appropriate error message when trying to manage iSCSI Bonds via r

[Engine-patches] Change in ovirt-engine[master]: restapi: Add REST API support for iSCSI multipathing

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Add REST API support for iSCSI multipathing .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ger

[Engine-patches] Change in ovirt-engine[master]: restapi: Add REST API support for iSCSI multipathing

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: restapi: Add REST API support for iSCSI multipathing .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored bran

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: OK... while trying to move it to uutils, I saw that gwt also use this class in modified form... so

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: EnumUtils - why don't we sync names with vdsm... well this is too late... but why not hold enum val

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: ReflectionUtils - I do not see any reason to have this class, nor we should publish it anywhere...

[Engine-patches] Change in ovirt-engine[master]: aaa: removing dependency in DbUtils

2014-04-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: removing dependency in DbUtils .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26928/1/backend/manager/modules/builtin-extensions/src/main/java/org/

[Engine-patches] Change in ovirt-engine[master]: aaa: eliminate IPA package at utils

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: eliminate IPA package at utils .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/26929 To unsubs

[Engine-patches] Change in ovirt-engine[master]: aaa: eliminate IPA package at utils

2014-04-20 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: aaa: eliminate IPA package at utils .. Abandoned -- To view, visit http://gerrit.ovirt.org/26929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageT

[Engine-patches] Change in ovirt-engine[master]: aaa: preparing for using the extension api

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: preparing for using the extension api .. Patch Set 21: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_un

[Engine-patches] Change in ovirt-engine[master]: aaa: introducing the new extension api

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: introducing the new extension api .. Patch Set 33: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_t

[Engine-patches] Change in ovirt-engine[master]: aaa: eliminate IPA package at utils

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: eliminate IPA package at utils .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 25: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine

[Engine-patches] Change in ovirt-engine[master]: aaa: ExtensionsManager: use the new extension api

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: ExtensionsManager: use the new extension api .. Patch Set 36: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/59

[Engine-patches] Change in ovirt-engine[master]: aaa: introducing the new extension api

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: introducing the new extension api .. Patch Set 33: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-eng

[Engine-patches] Change in ovirt-engine[master]: aaa: eliminate IPA package at utils

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: eliminate IPA package at utils .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-

[Engine-patches] Change in ovirt-engine[master]: aaa: eliminate IPA package at utils

2014-04-20 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: aaa: eliminate IPA package at utils .. aaa: eliminate IPA package at utils Change-Id: I244cbcb824e555d3e3af504625589c0a55b908b3 Topic: AAA Signed-off-by: Yair

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored bra

[Engine-patches] Change in ovirt-engine[master]: aaa: preparing for using the extension api

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: preparing for using the extension api .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt

[Engine-patches] Change in ovirt-engine[master]: aaa: ExtensionsManager: use the new extension api

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: ExtensionsManager: use the new extension api .. Patch Set 36: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: (1 comment) More candidates to consider - a. ReflectionUtils b. DnsSrvLocator (and maybe its subc

[Engine-patches] Change in ovirt-engine[master]: aaa: removing dependency in DbUtils

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: removing dependency in DbUtils .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5903/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: aaa: introducing the new extension api

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: introducing the new extension api .. Patch Set 32: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5902/ :

[Engine-patches] Change in ovirt-engine[master]: aaa: preparing for using the extension api

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: preparing for using the extension api .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5901/

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: aaa: removing dependency in DbUtils

2014-04-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: removing dependency in DbUtils .. Patch Set 1: Regarding rest of suggested cleanups from engine.core - IMHO we should focus on functionality/stability. I a

[Engine-patches] Change in ovirt-engine[master]: aaa: ExtensionsManager: use the new extension api

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: ExtensionsManager: use the new extension api .. Patch Set 35: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/58

[Engine-patches] Change in ovirt-engine[master]: aaa: removing dependency in DbUtils

2014-04-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: removing dependency in DbUtils .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26928/1/backend/manager/modules/builtin-extensions/src/main/java/or

[Engine-patches] Change in ovirt-engine[master]: aaa: removing dependency in DbUtils

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: removing dependency in DbUtils .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-

[Engine-patches] Change in ovirt-engine[master]: aaa: introducing the new extension api

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: introducing the new extension api .. Patch Set 32: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt-eng

[Engine-patches] Change in ovirt-engine[master]: aaa: preparing for using the extension api

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: preparing for using the extension api .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch (ovirt

[Engine-patches] Change in ovirt-engine[master]: aaa: removing dependency in DbUtils

2014-04-20 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: aaa: removing dependency in DbUtils .. aaa: removing dependency in DbUtils Change-Id: I235566046ca4d0d81ebdc61f7da5f2a05c2ce6cd Topic: AAA Signed-off-by: Yair

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored bra

[Engine-patches] Change in ovirt-engine[master]: aaa: ExtensionsManager: use the new extension api

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: ExtensionsManager: use the new extension api .. Patch Set 35: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored branch

[Engine-patches] Change in ovirt-engine[master]: webadmin: Respect line break suggestion in CJK locales

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Respect line break suggestion in CJK locales .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_g

[Engine-patches] Change in ovirt-engine[master]: webadmin: Respect line break suggestion in CJK locales

2014-04-20 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: webadmin: Respect line break suggestion in CJK locales .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26927 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: Respect line break suggestion in CJK locales

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Respect line break suggestion in CJK locales .. Patch Set 1: * #1001473::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-

[Engine-patches] Change in ovirt-engine[master]: webadmin: Respect line break suggestion in CJK locales

2014-04-20 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: webadmin: Respect line break suggestion in CJK locales .. webadmin: Respect line break suggestion in CJK locales Apparently "normal" line break heuristics don't w

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 23: Fixed sync for active-directory. -- To view, visit http://gerrit.ovirt.org/26602 To unsu

[Engine-patches] Change in ovirt-engine[master]: utils: introduce universal utilities (uutils)

2014-04-20 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: utils: introduce universal utilities (uutils) .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26924/1/backend/manager/modules/utils/src/main/java/org/o

[Engine-patches] Change in ovirt-engine[master]: aaa: Using extensions API in built-in authz and auth

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monitored bra

[Engine-patches] Change in ovirt-engine[master]: engine: Consider removed bonds in CollectVdsNetworkData

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Consider removed bonds in CollectVdsNetworkData .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_

[Engine-patches] Change in ovirt-engine[master]: engine: Consider removed bonds in CollectVdsNetworkData

2014-04-20 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: engine: Consider removed bonds in CollectVdsNetworkData .. engine: Consider removed bonds in CollectVdsNetworkData Changes to removed bonds should also be conside

[Engine-patches] Change in ovirt-engine[master]: engine: Consider removed bonds in CollectVdsNetworkData

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Consider removed bonds in CollectVdsNetworkData .. Patch Set 1: * #1085819::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt

[Engine-patches] Change in ovirt-engine[master]: engine: Consider removed bonds in CollectVdsNetworkData

2014-04-20 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: engine: Consider removed bonds in CollectVdsNetworkData .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26926 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set default vNIC type according to OsInfo

2014-04-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Set default vNIC type according to OsInfo .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set default vNIC type according to OsInfo

2014-04-20 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: webadmin: Set default vNIC type according to OsInfo .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26925 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set default vNIC type according to OsInfo

2014-04-20 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: webadmin: Set default vNIC type according to OsInfo .. webadmin: Set default vNIC type according to OsInfo Only set the vNIC type to VirtIO by default if it exist

[Engine-patches] Change in ovirt-engine[master]: webadmin: Set default vNIC type according to OsInfo

2014-04-20 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Set default vNIC type according to OsInfo .. Patch Set 1: * #996044::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-engi