[Engine-patches] Change in ovirt-engine[master]: Revert "frontend: Add custom field serializer for RepoImage"

2013-07-27 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: Revert "frontend: Add custom field serializer for RepoImage" .. Patch Set 1: > Please don't merge before merging the patch that provides the definitive > solution

[Engine-patches] Change in ovirt-engine[master]: engine: Adding no-arg constructor to gluster parameters

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Adding no-arg constructor to gluster parameters .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: Adding no-arg constructor to gluster parameters

2013-07-27 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: engine: Adding no-arg constructor to gluster parameters .. engine: Adding no-arg constructor to gluster parameters Added a no-arg constructor to all gluster param

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1114 - Still Failing!

2013-07-27 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1114/ Build Number: 1114 Build Status: Still Failing Triggered By: Started by timer - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: HostGeneralModel: improve "node has upgrade" logic

2013-07-27 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: HostGeneralModel: improve "node has upgrade" logic .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/160

[Engine-patches] Change in ovirt-engine[master]: engine: Add vnic profile name to VmNetworkInterface

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add vnic profile name to VmNetworkInterface .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: engine: Add vnic profile name to VmNetworkInterface

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Add vnic profile name to VmNetworkInterface .. engine: Add vnic profile name to VmNetworkInterface The patch adds the vnic profile name to VmNetworkInterf

[Engine-patches] Change in ovirt-engine[master]: engine Use VmNic within ChangeVMClusterCommand

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine Use VmNic within ChangeVMClusterCommand .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Add more validations for vnic profiles

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add more validations for vnic profiles .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Use VmNic within VmPoolHandler

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use VmNic within VmPoolHandler .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/30

[Engine-patches] Change in ovirt-engine[master]: engine: Require VnicProfile permission for vnic template

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Require VnicProfile permission for vnic template .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: engine: Expose new parameters for template vnic actions

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Expose new parameters for template vnic actions .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: Add method for checking existence of network in clus...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add method for checking existence of network in cluster .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_com

[Engine-patches] Change in ovirt-engine[master]: webadmin: (wip) add profiles instead of networks to vnic and...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: (wip) add profiles instead of networks to vnic and vm dialogs .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_s

[Engine-patches] Change in ovirt-engine[master]: engine: Modify Vm Interface commands to work with VmNic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify Vm Interface commands to work with VmNic .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: webdmin: Use templace vnic plugged property

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webdmin: Use templace vnic plugged property .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Use Vnic parameters plug property

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Use Vnic parameters plug property .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Use VmNic within UpdateVmCommand

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use VmNic within UpdateVmCommand .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing port mirroring and custom props from vnic...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: removing port mirroring and custom props from vnic dialog .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanit

[Engine-patches] Change in ovirt-engine[master]: engine: Modify VM commands to work with VmNic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify VM commands to work with VmNic .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Use Vnic parameters plug property

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Use Vnic parameters plug property .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Add more validations for vnic profiles

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add more validations for vnic profiles .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Add update vnic profile command

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add update vnic profile command .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: Change pciAndIdeWithinLimit to accept VmNics

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Change pciAndIdeWithinLimit to accept VmNics .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Change uniqueInterfaceName to work with VmNic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Change uniqueInterfaceName to work with VmNic .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Remove network name from NetworkInterface

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine,webadmin: Remove network name from NetworkInterface .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileCommandBase class

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileCommandBase class .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: engine: Replace use of VmNetworkInterfaceDao with VmNicDao

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Replace use of VmNetworkInterfaceDao with VmNicDao .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Require VnicProfile permission for vnic template

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Require VnicProfile permission for vnic template .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: webadmin: network profiles

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: network profiles .. Patch Set 15: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/3044/ : FA

[Engine-patches] Change in ovirt-engine[master]: webdmin: Use templace vnic plugged property

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webdmin: Use templace vnic plugged property .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Expose new parameters for template vnic actions

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Expose new parameters for template vnic actions .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: Add AddVnicProfileCommand

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add AddVnicProfileCommand .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/3039/

[Engine-patches] Change in ovirt-engine[master]: engine: Add method for checking existence of network in clus...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add method for checking existence of network in cluster .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_com

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileValidator

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileValidator .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/3

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent adding vnic profiles to non vm network

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent adding vnic profiles to non vm network .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent modifying port mirroring if used by vms

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent modifying port mirroring if used by vms .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: Add audit log messages for vnic profile commands

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add audit log messages for vnic profile commands .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c

[Engine-patches] Change in ovirt-engine[master]: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDa...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Utilize VmNicRowMapper base for VmNetworkInterfaceDao .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compi

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor VnicProfile row mapper

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Refactor VnicProfile row mapper .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: Create a vnic profile implicitly when adding network

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Create a vnic profile implicitly when adding network .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compi

[Engine-patches] Change in ovirt-engine[master]: engine: Modify Vm Interface commands to work with VmNic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify Vm Interface commands to work with VmNic .. Patch Set 6: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c

[Engine-patches] Change in ovirt-engine[master]: engine: Modify custom properties type to map

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify custom properties type to map .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VmNicDao

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VmNicDao .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/3028/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: webadmin: removing port mirroring and custom props from vnic...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: removing port mirroring and custom props from vnic dialog .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanit

[Engine-patches] Change in ovirt-engine[master]: engine: Replace use of VmNetworkInterface with VmNic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Replace use of VmNetworkInterface with VmNic .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Add query to retrieve all vnic profiles

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add query to retrieve all vnic profiles .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: engine: Add rename logging capability to UpdateVnic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add rename logging capability to UpdateVnic .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Add remove vnic profile command

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add remove vnic profile command .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine Use VmNic within ChangeVMClusterCommand

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine Use VmNic within ChangeVMClusterCommand .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: webadmin: (wip) add profiles instead of networks to vnic and...

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: (wip) add profiles instead of networks to vnic and vm dialogs .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_s

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByNetworkIdQuery

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByNetworkIdQuery .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: engine: Use VmNic within UpdateVmCommand

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use VmNic within UpdateVmCommand .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: engine: Add SP for retrieving vms by vnic profile

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add SP for retrieving vms by vnic profile .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVnicProfilesByDataCenterIdQuery

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVnicProfilesByDataCenterIdQuery .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VnicProfileView and its DAO

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VnicProfileView and its DAO .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: engine: Remove vnic profiles of a removed a data-center

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove vnic profiles of a removed a data-center .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: engine: Use VmNic within VmPoolHandler

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Use VmNic within VmPoolHandler .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/30

[Engine-patches] Change in ovirt-engine[master]: core: Add vnic profiles to DB and entities

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add vnic profiles to DB and entities .. Patch Set 37: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Extract removeVnicProfiles() to NetworkCommon

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Extract removeVnicProfiles() to NetworkCommon .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: engine: Remove publicUse from AddNetwork command

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove publicUse from AddNetwork command .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyl

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetVmsByVnicProfileIdQuery

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetVmsByVnicProfileIdQuery .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/3

[Engine-patches] Change in ovirt-engine[master]: engine: Remove vnic profiles for non-vm network

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Remove vnic profiles for non-vm network .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: core: Add parameter class for vnic profile commands

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add parameter class for vnic profile commands .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: engine: Add SP for retrieving templates by vnic profile

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add SP for retrieving templates by vnic profile .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: engine: cleanup static access

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: cleanup static access .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/3010/ : S

[Engine-patches] Change in ovirt-engine[master]: engine: Delete vnic profiles when removing a network

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Delete vnic profiles when removing a network .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_check

[Engine-patches] Change in ovirt-engine[master]: engine: Introduce VmNic, a base class for VmNetworkInterface

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Introduce VmNic, a base class for VmNetworkInterface .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil

[Engine-patches] Change in ovirt-engine[master]: webadmin: add VnicProfile as main tab

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add VnicProfile as main tab .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/30

[Engine-patches] Change in ovirt-engine[master]: engine: Add GetTemplatesByVnicProfileIdQuery

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add GetTemplatesByVnicProfileIdQuery .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Modify VM commands to work with VmNic

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify VM commands to work with VmNic .. Patch Set 5: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: core: adding vnic_profile_id to vm_interface

2013-07-27 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: adding vnic_profile_id to vm_interface .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: webdmin: Use templace vnic plugged property

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: webdmin: Use templace vnic plugged property .. webdmin: Use templace vnic plugged property The patch uses the tempalte vnic plugged indicator rather than relying

[Engine-patches] Change in ovirt-engine[master]: engine: Add more validations for vnic profiles

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Add more validations for vnic profiles .. engine: Add more validations for vnic profiles The patch adds validation for the custom properties value set for

[Engine-patches] Change in ovirt-engine[master]: engine: Require VnicProfile permission for vnic template

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Require VnicProfile permission for vnic template .. engine: Require VnicProfile permission for vnic template The patch requires permission on the vnic pro

[Engine-patches] Change in ovirt-engine[master]: engine: Expose new parameters for template vnic actions

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Expose new parameters for template vnic actions .. engine: Expose new parameters for template vnic actions The patch adds new parameters for the template'

[Engine-patches] Change in ovirt-engine[master]: engine: Add method for checking existence of network in clus...

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Add method for checking existence of network in cluster .. engine: Add method for checking existence of network in cluster The patch adds a method to chec

[Engine-patches] Change in ovirt-engine[master]: webadmin: Use Vnic parameters plug property

2013-07-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: webadmin: Use Vnic parameters plug property .. webadmin: Use Vnic parameters plug property The patch uses the explicit plug property as part of the command rather

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 1113 - Failure!

2013-07-27 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1113/ Build Number: 1113 Build Status: Failure Triggered By: Started by timer - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: fix pep8 issue

2013-07-27 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: fix pep8 issue .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17340 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: packaging: improve python check script

2013-07-27 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: improve python check script .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17341 To uns

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: legacy: ssl flags should be boolean

2013-07-27 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: legacy: ssl flags should be boolean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in otopi[master]: core: always dump environment at termination

2013-07-27 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: core: always dump environment at termination .. core: always dump environment at termination this had proven useful for problem determination. Change-Id

[Engine-patches] Change in otopi[master]: core: always dump environment at termination

2013-07-27 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: always dump environment at termination .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17360 To unsubscribe,

[Engine-patches] Change in otopi[master]: core: always dump environment at termination

2013-07-27 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: core: always dump environment at termination .. core: always dump environment at termination this had proven useful for problem determination. Change-Id: I5eec9

[Engine-patches] Change in ovirt-engine[master]: restapi: add storage domain with existing conn id

2013-07-27 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: add storage domain with existing conn id .. Patch Set 1: I would prefer that you didn't submit this (6 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: restapi: add storage server connections resource

2013-07-27 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: add storage server connections resource .. Patch Set 25: I would prefer that you didn't submit this (10 inline comments) few comments inline, but o