Vered Volansky has posted comments on this change.
Change subject: core: Check all attached VMs when updating shared disk boot flag
..
Patch Set 3:
Fix commit message as well please. The current one is unreadable.
--
To view,
Sahina Bose has posted comments on this change.
Change subject: gluster: Command to update gluster hook on servers
..
Patch Set 2: (2 inline comments)
File
backend/manager/m
Sahina Bose has posted comments on this change.
Change subject: engine: Add, remove gluster hooks VDS commands
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/14738
To unsubscribe, visit http://gerrit.ovirt.o
Kanagaraj M has posted comments on this change.
Change subject: engine: Add, remove gluster hooks VDS commands
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14738
To u
Sandro Bonazzola has posted comments on this change.
Change subject: [WIP] : [db] create application objects within own schema
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Vered Volansky has posted comments on this change.
Change subject: core: Re-ordering validations at create snapshot command.
..
Patch Set 2: (2 inline comments)
File
backend
Kanagaraj M has posted comments on this change.
Change subject: engine: only supported models should use search paging
..
Patch Set 3:
The approach looks good.
A guick scan revealed that there are some popup/dialogs uses Searc
Yair Zaslavsky has posted comments on this change.
Change subject: Validate installed host by requesting for vdsm uuid
..
Patch Set 3:
Actually, when looking at the code I see the warning print is at debug level.
I would prefer
Yair Zaslavsky has posted comments on this change.
Change subject: Validate installed host by requesting for vdsm uuid
..
Patch Set 3:
Also, regarding the engine-config.properties - I agree with Alon, this should
not be expose
Yair Zaslavsky has posted comments on this change.
Change subject: Validate installed host by requesting for vdsm uuid
..
Patch Set 3:
Some comments -
A. Not including the relevant entries at vdc_options will cause warnings at
Yair Zaslavsky has posted comments on this change.
Change subject: Validate installed host by requesting for vdsm uuid
..
Patch Set 3: I would prefer that you didn't submit this
All app errors files at frontend should be fixed
Moti Asayag has uploaded a new change for review.
Change subject: engine: Remove mgmt network setup from host activation
..
engine: Remove mgmt network setup from host activation
The management network setup will be removed from
Moti Asayag has uploaded a new change for review.
Change subject: engine: Add new parameter class for CollectNetworkData
..
engine: Add new parameter class for CollectNetworkData
The VDS command CollectVdsNetworkData will requir
Martin Peřina has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
..
Patch Set 5:
Gilad, definitely use it for anything you need. Let me know if you need some
Yaniv Bronhaim has posted comments on this change.
Change subject: Validate installed host by requesting for vdsm uuid
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14905
To unsubscribe, visit http://gerrit
Gilad Chaplik has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
..
Patch Set 5:
Moti 10x for the quick reply, you're fast :)
I'm working on an infra that w
Gilad Chaplik has posted comments on this change.
Change subject: engine: rename quota limit labels
..
Patch Set 2: (2 inline comments)
File
frontend/webadmin/modules/webadm
Moti Asayag has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
..
Patch Set 5:
In reply to:
"A small question, after your refactoring can I reuse custom pro
Gilad Chaplik has abandoned this change.
Change subject: core: move static util method to static util class (15/15)
..
Patch Set 2: Abandoned
not relevant
--
To view, visit http://gerrit.ovirt.org/13217
To unsubscribe, visit h
Gilad Chaplik has abandoned this change.
Change subject: core: vdsSelector: remove method used once (14/15)
..
Patch Set 2: Abandoned
addressed in another patch.
--
To view, visit http://gerrit.ovirt.org/13216
To unsubscribe,
Gilad Chaplik has uploaded a new change for review.
Change subject: core: refactoring VdsSelector API
..
core: refactoring VdsSelector API
Host selection should become stateless,
therefore moving failed host list out of this cla
Gilad Chaplik has posted comments on this change.
Change subject: core: Prepare custom device properties support in
VmPropertiesUtils
..
Patch Set 5:
A small question, after your refactoring can I reuse custom properties logic
Gilad Chaplik has posted comments on this change.
Change subject: engine: only supported models should use search paging
..
Patch Set 3:
ping :)
--
To view, visit http://gerrit.ovirt.org/11061
To unsubscribe, visit http://gerr
Gilad Chaplik has abandoned this change.
Change subject: core: removing destVds public setter (9/15)
..
Patch Set 3: Abandoned
not relevant
--
To view, visit http://gerrit.ovirt.org/13211
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: [WIP] : [db] create application objects within own schema
..
Patch Set 4:
Eli,
what about create two schemas... ovirt_engine and ovirt_engine_xxx in which you
Alon Bar-Lev has posted comments on this change.
Change subject: [WIP] : [db] create application objects within own schema
..
Patch Set 4:
Rebase + make use of this much simpler code without guessing!
Eli, if you can revi
Eli Mesika has posted comments on this change.
Change subject: engine: make QueryData immutable (7/N)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14620
To unsubscribe, visit http://gerri
Eli Mesika has posted comments on this change.
Change subject: engine: import java.util (6/N)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14619
To unsubscribe, visit http://gerrit.ovirt.
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: fixup pki usage of uninstall
..
packaging: setup: fixup pki usage of uninstall
Change-Id: Ia04b609d5f3a3c1434698d7949c641effecf6ef1
S
Ofer Schreiber has posted comments on this change.
Change subject: packaging: setup: fixup pki usage of uninstall
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14995
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: fixup pki usage of uninstall
..
Patch Set 1: Verified
Sandro, we should consider to split this into two groups as well.
--
To view, visit http:
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: setup: fixup pki usage of uninstall
..
packaging: setup: fixup pki usage of uninstall
Change-Id: Ia04b609d5f3a3c1434698d7949c641effecf6ef1
Signed-off-
Kanagaraj M has posted comments on this change.
Change subject: gluster: Command to update gluster hook on servers
..
Patch Set 2: (2 inline comments)
File
backend/manager/m
Ravi Nori has posted comments on this change.
Change subject: restapi : Update of power management via cli ignored(#959879)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14994
To unsubscribe, visit http://g
Ravi Nori has uploaded a new change for review.
Change subject: restapi : Update of power management via cli ignored(#959879)
..
restapi : Update of power management via cli ignored(#959879)
Unable update power management fields
Yair Zaslavsky has posted comments on this change.
Change subject: core: SPMAsyncTask -> change from associatedEntities + single
type to map
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing EntityInfo
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/14992
To unsubscribe, visit ht
Juan Hernandez has uploaded a new change for review.
Change subject: core: Generic make GUID from LDAP
..
core: Generic make GUID from LDAP
Currently we have the code to make GUIDs from LDAP ids inside the LDAP
mapper classes. T
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing EntityInfo
..
Patch Set 1:
Put it for review - still needs to be tested.
--
To view, visit http://gerrit.ovirt.org/14992
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: core: SPMAsyncTask -> change from associatedEntities + single
type to map
..
Patch Set 1:
Put it for review - still needs to be tested.
--
To view, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Switching to map from entity ids to entity types
..
Patch Set 1: I would prefer that you didn't submit this
Put it for review - still needs to be te
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding the ability to get async tasks by entity id
..
Patch Set 1: I would prefer that you didn't submit this
Put it for review - still needs to be tested
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: SPMAsyncTask -> change from associatedEntities + single
type to map
..
core: SPMAsyncTask -> change from associatedEntities + single type to map
Change-
Yair Zaslavsky has uploaded a new change for review.
Change subject: [WIP] core: Switching to map from entity ids to entity types
..
[WIP] core: Switching to map from entity ids to entity types
The following patch uses fnsplitte
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding the ability to get async tasks by entity id
..
core: Adding the ability to get async tasks by entity id
The following patch adds the ability to ge
Allon Mureinik has posted comments on this change.
Change subject: core: Check all attached VMs when updating shared disk boot flag
..
Patch Set 3: (1 inline comment)
File
b
Allon Mureinik has posted comments on this change.
Change subject: core: add the db-upgrade maven profile
..
Patch Set 3: Looks good to me, but someone else must approve
I completely misread what this patch was supposed to do.
Allon Mureinik has posted comments on this change.
Change subject: core: Check all attached VMs when updating shared disk boot flag
..
Patch Set 3: (1 inline comment)
File ba
Daniel Erez has posted comments on this change.
Change subject: webadmin: add data center to MoveOrCopyDiskModel
..
Patch Set 1: (11 inline comments)
File
frontend/webadmin/
Tal Nisan has posted comments on this change.
Change subject: core: Check all attached VMs when updating shared disk boot flag
..
Patch Set 3: (2 inline comments)
File backen
Gilad Chaplik has abandoned this change.
Change subject: core: remove unused code (7/15)
..
Patch Set 3: Abandoned
not relevant
--
To view, visit http://gerrit.ovirt.org/13209
To unsubscribe, visit http://gerrit.ovirt.org/sett
Maor Lipchuk has posted comments on this change.
Change subject: core: Re-ordering validations at create snapshot command.
..
Patch Set 2: (2 inline comments)
File
backend/m
Gilad Chaplik has abandoned this change.
Change subject: core: moving sla logic to sla package (6/15)
..
Patch Set 4: Abandoned
addressed in http://gerrit.ovirt.org/#/c/14580/
--
To view, visit http://gerrit.ovirt.org/13116
To
Gilad Chaplik has abandoned this change.
Change subject: core: removing org.apache.commons.lang dependency (5/15)
..
Patch Set 4: Abandoned
not relevant.
--
To view, visit http://gerrit.ovirt.org/13115
To unsubscribe, visit ht
Gilad Chaplik has abandoned this change.
Change subject: core: initial module commit (4/15)
..
Patch Set 4: Abandoned
addressed in http://gerrit.ovirt.org/#/c/14580/
--
To view, visit http://gerrit.ovirt.org/13114
To unsubscri
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated otopi for fully automated execution
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated otopi for fully automated execution
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment but looks
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated otopi for fully automated execution
..
Patch Set 2: (5 inline comments)
File packaging/setu
Allon Mureinik has submitted this change and it was merged.
Change subject: core: remove spec field in StorageServerConnections
..
core: remove spec field in StorageServerConnections
Remove unused spec field (member) in Storage
Allon Mureinik has posted comments on this change.
Change subject: core: remove spec field in StorageServerConnections
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14952
To unsu
Daniel Erez has posted comments on this change.
Change subject: frontend: refactor MoveOrCopyDisk and DisksAllocation
..
Patch Set 2: (8 inline comments)
File
frontend/webad
Allon Mureinik has posted comments on this change.
Change subject: core: remove spec field in StorageServerConnections
..
Patch Set 1: Looks good to me, approved
I wasn't involved in the original patch Alissa sited, but this fi
Eli Mesika has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 22: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13057
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: packaging: log rotate
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14961
To unsubscribe, visit http
Eli Mesika has posted comments on this change.
Change subject: (WIP) Adding caching capabilities to database access
..
Patch Set 5: (1 inline comment)
lots of comments on prev reviews are still not -answered
..
Tal Nisan has posted comments on this change.
Change subject: core: add destination sd to CopyImageVDSCommand log
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
..
Allon Mureinik has posted comments on this change.
Change subject: core: add destination sd to CopyImageVDSCommand log
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14986
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: core: Check all attached VMs when updating shared disk boot flag
..
Patch Set 3: I would prefer that you didn't submit this
(6 inline comments)
...
Eli Mesika has posted comments on this change.
Change subject: engine: change mVerbs to Set (2/N)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14406
To unsubscribe, visit http://gerrit.ov
Eli Mesika has posted comments on this change.
Change subject: gluster: Sync gluster service statuses
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14644
To unsubscrib
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: cleaning up ISO domain directory
..
packaging: setup: cleaning up ISO domain directory
Allow the admin to remove from ISO domain dire
Ofer Schreiber has posted comments on this change.
Change subject: packaging: setup: cleaning up ISO domain directory
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14984
To unsubscribe, vi
Liron Ar has uploaded a new change for review.
Change subject: core: add destination sd to CopyImageVDSCommand log
..
core: add destination sd to CopyImageVDSCommand log
When executing CopyImageVDSCommand, the destionation sd wa
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated otopi for fully automated execution
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
...
Omer Frenkel has posted comments on this change.
Change subject: core: remove vmType related logic
..
Patch Set 2:
still need more verification, also missing a query
--
To view, visit http://gerrit.ovirt.org/14963
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: engine: remove lazy-initialization from SearchObjects (3/N)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14616
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: engine: renamed InitQueryData to initQueryData (4/N)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14617
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: engine: rename QueryData2 to QueryData (5/N)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14618
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: engine: change mVerbs to Set (2/N)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14406
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: cleaning up ISO domain directory
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14984
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: cleaning up ISO domain directory
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14984
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: engine: remove lazy-initialization from SearchObjects (3/N)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: engine: renamed InitQueryData to initQueryData (4/N)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Allon Mureinik has posted comments on this change.
Change subject: engine: rename QueryData2 to QueryData (5/N)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14618
To
Allon Mureinik has posted comments on this change.
Change subject: engine: import java.util (6/N)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14619
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: engine: make QueryData immutable (7/N)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14620
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: engine: remove type attribute from QueryData (8/N)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/149
Itamar Heim has posted comments on this change.
Change subject: engine: increase blank template memory size
..
Patch Set 3:
agree - it should reduce confusion for anyone looking at this.
--
To view, visit http://gerrit.ovirt.o
Laszlo Hornyak has posted comments on this change.
Change subject: engine: increase blank template memory size
..
Patch Set 3:
Tal: Sure, let's Eli decide!
--
To view, visit http://gerrit.ovirt.org/14747
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated otopi for fully automated execution
..
Patch Set 2: (3 inline comments)
File packaging/set
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: cleaning up ISO domain directory
..
Patch Set 2:
> What do you think? can we split these?
Yes I think we can split here separating the iso
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: cleaning up ISO domain directory
..
Patch Set 2:
Hi,
I think unless absolutly require, group should not shared between plugins.
I know we have
Tal Nisan has posted comments on this change.
Change subject: core: Re-ordering validations at create snapshot command.
..
Patch Set 2: (1 inline comment)
File
backend/manag
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: allow interactive PKI cleanup
..
packaging: setup: allow interactive PKI cleanup
allow interactive PKI cleanup with engine-cleanup-2
Ofer Schreiber has posted comments on this change.
Change subject: packaging: setup: allow interactive PKI cleanup
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14732
To unsubsc
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: cleaning up ISO domain directory
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14984
To unsubscribe, visit http://gerri
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove spec field in StorageServerConnections
..
Patch Set 1: Looks good to me, but someone else must approve
Ok,
I guess it was probably removed, or not
Lior Vernia has posted comments on this change.
Change subject: webadmin: Added authentication fields to Provider popup
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/14758
To unsubscribe, visit http://gerri
Tal Nisan has posted comments on this change.
Change subject: engine: increase blank template memory size
..
Patch Set 3:
I think it should although the fact that it doesn't add much, I've stated my
reason above
--
To view, v
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated otopi for fully automated execution
..
packaging: Updated otopi for fully automated execution
This patch updates an otopi engine-setup plugin t
1 - 100 of 300 matches
Mail list logo
