Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: stricter FQDN validation
..
packaging: stricter FQDN validation
common_utils.getConfiguredIps now returns only Ips configured on
non loopback devi
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: modified validation of fqdn input during setup
..
packaging: modified validation of fqdn input during setup
validateFQDN now explicitly states tha
Hello Mark Huth,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14526
to review the following change.
Change subject: packaging: make validateFQDN case insensitive
..
packaging: make validateFQDN c
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fix enabling gluster hooks actions
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14515
To unsubscribe, visit htt
Gilad Chaplik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageDataCenterListModel class
..
Patch Set 1: (1 inline comment)
File
fr
Gilad Chaplik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageListModel class
..
Patch Set 1:
I disagree.
--
To view, visit http://gerrit.ovirt.org/14449
To unsubscribe, visit http://
Gilad Chaplik has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in frontend backup models
..
Patch Set 1: (1 inline comment)
File
frontend/web
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated Makefile to create dbutils folder
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: WIP core, restapi, webadmin: cloud-init [3/4] - backend
..
Patch Set 1: (1 inline comment)
File
backend/mana
Yair Zaslavsky has posted comments on this change.
Change subject: Modify error to info report after fencing and fixing print
..
Patch Set 4: Looks good to me, approved
Approved - please verify
--
To view, visit http://gerrit.
Michael Kublin has posted comments on this change.
Change subject: engine: Adding quartz configuration to standalone.xml
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14504
To un
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Adding quartz configuration to standalone.xml
..
engine: Adding quartz configuration to standalone.xml
In order to configure a quartz scheduler
Ofer Schreiber has posted comments on this change.
Change subject: notifier: perserve notifier.conf
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14519
To unsubscribe, visit http
Ofer Schreiber has submitted this change and it was merged.
Change subject: notifier: perserve notifier.conf
..
notifier: perserve notifier.conf
at the end there is no significant configuration modification, leaving
the file as
Tal Nisan has posted comments on this change.
Change subject: findbugs: Call to equals compare different types
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/modu
Tal Nisan has posted comments on this change.
Change subject: findbugs: Potentially dangerous use of non-short-circuit logic
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14503
To unsubscr
Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix field should be package protected warning in
uicommonweb project
..
Patch Set 1: (2 inline comments)
.
Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageDataCenterListModel class
..
Patch Set 1: (1 inline comment)
File
fronte
Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in StorageListModel class
..
Patch Set 1:
A matter of style, I prefer them separated one by one to avoid conflicts later
when merging a
Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix fingbugs error in frontend backup models
..
Patch Set 1: (1 inline comment)
File
frontend/webadmi
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.0.2
..
packaging: post ovirt-host-deploy-1.0.2
Change-Id: I6350a7b9a766d6926facf9d8252c6ef55ca062f4
Signed-off-by: Al
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post ovirt-host-deploy-1.0.2
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14524
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: ovirt-host-deploy-1.0.2
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14523
To unsubscribe, visit http
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.0.2
..
packaging: ovirt-host-deploy-1.0.2
Change-Id: I1bd545c7425c72fac45e42c849015096746792fd
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post ovirt-host-deploy-1.0.2
..
packaging: post ovirt-host-deploy-1.0.2
Change-Id: I6350a7b9a766d6926facf9d8252c6ef55ca062f4
Signed-off-by: Alon Bar-L
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: ovirt-host-deploy-1.0.2
..
packaging: ovirt-host-deploy-1.0.2
Change-Id: I1bd545c7425c72fac45e42c849015096746792fd
Signed-off-by: Alon Bar-Lev
---
M
Daniel Erez has posted comments on this change.
Change subject: findbugs: Method with Boolean return explicit null
..
Patch Set 4: (1 inline comment)
File
frontend/webadmin/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post otopi-1.0.2
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14522
To unsubscribe, visit http://gerr
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post otopi-1.0.2
..
packaging: post otopi-1.0.2
Change-Id: Id1c675eeb0a1d3bd43d6403a5d8cb81d779de6f3
Signed-off-by: Alon Bar-Lev
---
M Change
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: otopi-1.0.2
..
packaging: otopi-1.0.2
Change-Id: Ifdb304559d1571d5dfcd5bff40cbe9237860f21c
Signed-off-by: Alon Bar-Lev
---
M ChangeLog
M conf
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: otopi-1.0.2
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14521
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post otopi-1.0.2
..
packaging: post otopi-1.0.2
Change-Id: Id1c675eeb0a1d3bd43d6403a5d8cb81d779de6f3
Signed-off-by: Alon Bar-Lev
---
M ChangeLog
M co
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: otopi-1.0.2
..
packaging: otopi-1.0.2
Change-Id: Ifdb304559d1571d5dfcd5bff40cbe9237860f21c
Signed-off-by: Alon Bar-Lev
---
M ChangeLog
M configure.ac
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated Makefile to create dbutils folder
..
Patch Set 1: Looks good to me, but someone else must approve
I will fix that later... much to be fixed in
liron aravot has posted comments on this change.
Change subject: core: setStorage once in AddSanStorageDomainCommand
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Arik Hadas has uploaded a new change for review.
Change subject: core: lock the vds manager while calling hibernate verb
..
core: lock the vds manager while calling hibernate verb
It is needed to lock the vds manager so that no
Daniel Erez has posted comments on this change.
Change subject: findbugs: Call to equals compare different types
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/mo
Daniel Erez has posted comments on this change.
Change subject: findbugs: Potentially dangerous use of non-short-circuit logic
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14503
To unsubs
Daniel Erez has posted comments on this change.
Change subject: webadmin: vm->change cd, "Eject" is not localized
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14509
To unsubscribe, visit
Daniel Erez has submitted this change and it was merged.
Change subject: core: live migrate - log error on failure
..
core: live migrate - log error on failure
In case of shutting down the vm during snapshot
creation part of li
Daniel Erez has posted comments on this change.
Change subject: core: live migrate - log error on failure
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14440
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: core: ReplicateDisk - prevent rollback on engine restart
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14441
To unsubscribe, visit http://gerr
Itamar Heim has posted comments on this change.
Change subject: cleanup: desktops are always supported in search
..
Patch Set 1: (1 inline comment)
Commit Message
Line 5: Com
Daniel Erez has posted comments on this change.
Change subject: core: live migrate - log error on failure
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14440
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: perserve notifier.conf
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4224/
Build Number: 4224
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Alon Bar-Lev has uploaded a new change for review.
Change subject: notifier: perserve notifier.conf
..
notifier: perserve notifier.conf
at the end there is no significant configuration modification, leaving
the file as-is will e
Alissa Bonas has posted comments on this change.
Change subject: core: setStorage once in AddSanStorageDomainCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14518
To unsubscribe, visit http://gerrit.o
Alissa Bonas has uploaded a new change for review.
Change subject: core: setStorage once in AddSanStorageDomainCommand
..
core: setStorage once in AddSanStorageDomainCommand
Calling setStorage once in AddSanStorageDomainCommand
Alissa Bonas has uploaded a new change for review.
Change subject: core: fix typo in scheduler error message
..
core: fix typo in scheduler error message
Change-Id: I4f2f80002d26edefbca5aa43c124ebcb668127d8
Signed-off-by: Alissa
Alon Bar-Lev has abandoned this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 9: Abandoned
bug in gerrit? this already merged in tree, but in gerrit it is in submit
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: move to the new service infrastructure
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14378
To unsubsc
Yair Zaslavsky has submitted this change and it was merged.
Change subject: notifier: move to the new service infrastructure
..
notifier: move to the new service infrastructure
rename service to ovirt-engine-notifier to match o
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core:unlock_entity is not locating locked snapshots
..
core:unlock_entity is not locating locked snapshots
Adding handling of
1) -t snapshot flag to di
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: move to the new service infrastructure
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/14378
To unsubscribe, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: core:unlock_entity is not locating locked snapshots
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14494
To unsu
Alon Bar-Lev has restored this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 8: Restored
try to restore
--
To view, visit http://gerrit.ovirt.org/14448
To unsubscr
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: move to the new service infrastructure
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14378
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovi
Alon Bar-Lev has abandoned this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 8: Abandoned
bug in gerrit? this already merged in tree, but in gerryt it is in submit
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: move to the new service infrastructure
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14378
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/14448
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: Modify error to info report after fencing and fixing print
..
Patch Set 3: (1 inline comment)
sorry, was easier if i had provided the exact text.
Hope it will b
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4223/
Build Number: 4223
Build Status: Failure
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last Succes
Anonymous Coward has submitted this change and it was merged.
Change subject: notifier: use LocalConfig as configuration file
..
notifier: use LocalConfig as configuration file
gives the advantage of defaults and conf.d structu
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovi
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4222/
Build Number: 4222
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: handle port correctly
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14375
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: handle port correctly
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14375
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14448
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: use LocalConfig as configuration file
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14376
To unsubscr
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: remove NotificationConfigurator as superseded by
LocalConfig
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/144
Yair Zaslavsky has submitted this change and it was merged.
Change subject: notifier: switch to log4j
..
notifier: switch to log4j
for some reason no logs using current logger.
also fix log4j.xml as it complains about format.
Yair Zaslavsky has submitted this change and it was merged.
Change subject: notifier: handle port correctly
..
notifier: handle port correctly
1. separate between plain and ssl ports.
2. actually set plain port.
Change-Id: Ibc
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: switch to log4j
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14377
To unsubscribe, visit http://gerr
Yair Zaslavsky has submitted this change and it was merged.
Change subject: root: serve root customizable location resources
..
root: serve root customizable location resources
resources are hard coded within root's web.xml, wh
Yair Zaslavsky has posted comments on this change.
Change subject: core: config: provide expand string for configuration
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14447
To un
Yair Zaslavsky has submitted this change and it was merged.
Change subject: pki: move configuration from vdc_options to configuration files
..
pki: move configuration from vdc_options to configuration files
root application ser
Yair Zaslavsky has posted comments on this change.
Change subject: core: config: support sensitive keys
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14353
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: root: serve root customizable location resources
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14354
To unsubsc
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: config: split LocalConfig to allow code reuse
..
core: config: split LocalConfig to allow code reuse
EngineLocalConfig - for engine.
NotifierLoca
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: config: provide expand string for configuration
..
core: config: provide expand string for configuration
allow to expand strings such as "${ENGIN
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: config: support sensitive keys
..
core: config: support sensitive keys
do not print sensitive keys' value to log.
Change-Id: I8dc10fb3eeb1cc97a0
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: config: support optional properties
..
core: config: support optional properties
Change-Id: I61975ab2c6c5b72c7eb0fe85b1ccef9eb2ef8fd9
Signed-off-
Yair Zaslavsky has posted comments on this change.
Change subject: core: config: split LocalConfig to allow code reuse
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14374
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: core: config: support optional properties
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14446
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: pki: move configuration from vdc_options to configuration files
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has posted comments on this change.
Change subject: root: serve root customizable location resources
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/14354
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to configuration files
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to configuration files
..
Patch Set 11: Verified; No score
--
To view, visit http://gerrit.ovirt.org/14333
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: provide expand string for configuration
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14447
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: support optional properties
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14446
To unsubscribe, visit http://gerrit.ovirt.org/s
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: support sensitive keys
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14353
To unsubscribe, visit http://gerrit.ovirt.org/settin
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify error to info report after fencing and fixing print
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14495
To unsubscribe, visit http:/
Einav Cohen has posted comments on this change.
Change subject: engine: only supported models should use search paging
..
Patch Set 2:
indeed - I agree that this patch is better than nothing and I would like to see
it in the c
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: split LocalConfig to allow code reuse
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14374
To unsubscribe, visit http://gerrit.o
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4221/
Build Number: 4221
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Laszlo Hornyak has posted comments on this change.
Change subject: engine: replace some parameter classes with IdQueryParameters
..
Patch Set 3:
Michael?
--
To view, visit http://gerrit.ovirt.org/14260
To unsubscribe, visit ht
Laszlo Hornyak has posted comments on this change.
Change subject: engine: entity snapshot valiadation
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13694
To unsubscribe, visit h
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Fix enabling gluster hooks actions
..
webadmin: Fix enabling gluster hooks actions
'Enable' action was getting enable even though
the selected hook is a
1 - 100 of 368 matches
Mail list logo
