Asaf Shakarchi has posted comments on this change.
Change subject: userportal : User has insufficient permissions on url
/domain/domain_id/user
..
Patch Set 1: (3 inline comments)
..
Sharad Mishra has uploaded a new change for review.
Change subject: restapi: WIP: Add support for backup APIs.
..
restapi: WIP: Add support for backup APIs.
This just adds support for /api/vms/xxx/backup
We will also add support
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/892/
Build Number: 892
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
frontend: Fix findbugs method doesn't start with lower case
Fix findbugs method doesn't start
Tal Nisan has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14183
To u
Gilad Chaplik has posted comments on this change.
Change subject: engine: custom properties: allow '=' in regex
..
Patch Set 1: I would prefer that you didn't submit this
do not review it
--
To view, visit http://gerrit.ovirt.
Moti Asayag has posted comments on this change.
Change subject: findbugs: Method invokes inefficient Number constructor
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14128
To unsubscribe,
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: generic no items to display message
..
webadmin: generic no items to display message
- Changed the no XX to display message to a generic
no item
Einav Cohen has posted comments on this change.
Change subject: webadmin: generic no items to display message
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14150
To unsubscribe,
Einav Cohen has posted comments on this change.
Change subject: webadmin: generic no items to display message
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/14150
To unsubscribe, visit http://gerrit.ovirt.or
Ravi Nori has posted comments on this change.
Change subject: userportal : User has insufficient permissions on url
/domain/domain_id/user
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14185
To unsubscribe
Ravi Nori has uploaded a new change for review.
Change subject: userportal : User has insufficient permissions on url
/domain/domain_id/user
..
userportal : User has insufficient permissions on url /domain/domain_id/user
>From
Allon Mureinik has posted comments on this change.
Change subject: findbugs: use Boolean.valueOf instead of Boolean constructor
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14123
To unsub
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Method invokes inefficient Number constructor
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Alexander Wels has posted comments on this change.
Change subject: core: i18n splash screen.
..
Patch Set 5: (9 inline comments)
File
backend/manager/modules/root/src/main/j
Vojtech Szocs has posted comments on this change.
Change subject: userportal: prestarted VMs not updated
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14148
To unsubscribe, visit http://ge
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4090/
Build Number: 4090
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3895/
Build Number: 3895
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3916/
Build Number: 3916
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Laszlo Hornyak has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Omer Frenkel has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13398
To unsub
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (11)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13405
To un
Omer Frenkel has posted comments on this change.
Change subject: core: runVmCommand.canDoAction clean up (13)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13407
To un
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
..
Patch Set 9: Looks good to me, but someone else must approve
i will pray for this one
--
To view, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13397
To unsu
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
frontend: Fix findbugs method doesn't start with lower case
Fix findbugs method doesn't start with a
Omer Frenkel has posted comments on this change.
Change subject: core: runVmCommand.canDoAction clean-up (12)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13406
To un
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (10)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13404
To un
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated running taskcleaner utility
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14095
To unsubscribe, visit http://gerrit.ovirt.o
Maor Lipchuk has posted comments on this change.
Change subject: core: use local TX in AddVm flow
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13805
To unsubscribe, v
Gilad Chaplik has uploaded a new change for review.
Change subject: core: server fails to load on wrong custom property regex
..
core: server fails to load on wrong custom property regex
On server load we initialize custom prope
Laszlo Hornyak has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
..
Patch Set 1: (1 inline comment)
File
backend
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: custom properties: allow '=' in regex
..
engine: custom properties: allow '=' in regex
In custom properties sheet when regex contains '=', we cannot par
Oved Ourfali has posted comments on this change.
Change subject: findbugs: use Boolean.valueOf instead of Boolean constructor
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Omer Frenkel has posted comments on this change.
Change subject: core: unify validations for pools and run VM
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13696
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (4)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13400
To uns
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (8)
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13661
To uns
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (6)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13402
To uns
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (7)
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13660
To uns
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (5)
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13401
To unsubscribe, visit http:
Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (9)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13403
To uns
Omer Frenkel has posted comments on this change.
Change subject: core: unify validations for pools and run VM
..
Patch Set 10:
did you verify vms can still run?
please run also automation tests for this
--
To view, visit http:
Ohad Basan has posted comments on this change.
Change subject: core: disable unit test that fails as root
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14149
To unsubs
Roy Golan has posted comments on this change.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
..
Patch Set 1: (1 inline comment)
File
backend/mana
Laszlo Hornyak has posted comments on this change.
Change subject: engine: TmeoutBase - Improving memory footprint - continue
..
Patch Set 1: (1 inline comment)
Commit Messag
Laszlo Hornyak has posted comments on this change.
Change subject: engine: TimeoutBase does not have to be serialized
..
Patch Set 2: No score; Do not submit
after merging TimeoutBase caching, commands may actually need to be
Omer Frenkel has posted comments on this change.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
..
Patch Set 1: (1 inline comment)
File
backend/m
Einav Cohen has submitted this change and it was merged.
Change subject: core: disable unit test that fails as root
..
core: disable unit test that fails as root
- Disabled a unit test that fails when run as root
as root is alw
Omer Frenkel has posted comments on this change.
Change subject: core: Update VM status if host is not available
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13706
To
Omer Frenkel has posted comments on this change.
Change subject: core: runVmCommandParams: remove get/setInternalExecution
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove ObjectStreamSerializer default constructor
..
Patch Set 2: No score; Do not submit
after merging TimeoutBase caching, commands may actually need
Alexander Wels has posted comments on this change.
Change subject: core: disable unit test that fails as root
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14149
To unsubscribe, visit http://gerrit.ovirt.or
Eyal Edri has posted comments on this change.
Change subject: core: disable unit test that fails as root
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14149
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: split service to allow code reuse
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14154
To unsubscribe, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: split service to allow code reuse
..
Patch Set 4:
Move engine specific configuration out of service.
--
To view, visit http://gerrit.o
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remve command serialVersionUid fields
..
Patch Set 2: No score; Do not submit
after merging TimeoutBase caching, commands may actually need to be
seria
Alexander Wels has posted comments on this change.
Change subject: webadmin: User Event Notification dialog element IDs
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Einav Cohen has posted comments on this change.
Change subject: core: disable unit test that fails as root
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14149
To unsubscribe, vis
Alexander Wels has posted comments on this change.
Change subject: webadmin: generic no items to display message
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14150
To unsubscribe, visit http://gerrit.ovirt
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: guide link opens with scrollbar
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13996
To unsubscribe, visit http://gerri
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14183
To unsubs
Einav Cohen has posted comments on this change.
Change subject: core: disable unit test that fails as root
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/14149
To unsubscribe, visit http://gerrit.ovirt.org/s
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3896/
Build Number: 3896
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Vered Volansky has posted comments on this change.
Change subject: core: Upgrade DC should not log failure on update process.
..
Patch Set 1: (1 inline comment)
File
backend
Vojtech Szocs has posted comments on this change.
Change subject: core: i18n splash screen.
..
Patch Set 5: (9 inline comments)
File
backend/manager/modules/root/src/main/ja
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3915/
Build Number: 3915
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: move service out of fedora into own
directory
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit ht
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: rename service directory to services
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerri
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: move generated code out of main
source
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://ge
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3914/
Build Number: 3914
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Updated running taskcleaner utility
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14095
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4089/
Build Number: 4089
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Alon Bar-Lev has posted comments on this change.
Change subject: packaging - added check on firewall-cmd support
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14177
To
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 13: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Arik Hadas has uploaded a new change for review.
Change subject: : short summary under 50 chars
..
: short
summary under 50 chars
Longer description using lines' length under 72 chars.
With multiple paragraphs if necessary.
C
Arik Hadas has uploaded a new change for review.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
..
core: [cleanup] split execute method of CreateAllSnapshots
CreateAllSnapshotsFromVmCommand#executeVmC
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 13: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
frontend: Fix findbugs method doesn't start with lower case
Fix findbugs method doesn't start
Liron Ar has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 1: No score
After talk f2f, removing my -1...wanted to make sure that it will be checked.
--
To view,
Liron Ar has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Giving -1 just to make sure that my
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 12: (3 inline comments)
Thanks
Almost there... I think you agree that this is much si
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated running taskcleaner utility
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14095
To
Sandro Bonazzola has posted comments on this change.
Change subject: packaging - added check on firewall-cmd support
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14177
To unsubscribe, visit http://gerrit.o
Tomas Jelinek has submitted this change and it was merged.
Change subject: core,webadmin: Show Pools tab based on tree
..
core,webadmin: Show Pools tab based on tree
Tab Pools was shown only for System node when selected
in the
Tal Nisan has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14176
To unsubscribe, visit h
Tal Nisan has posted comments on this change.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14178
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 1: Looks good to me, but someone else must approve
Hope it's working now:) Thanks!
A side que
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: rename quota limit labels
..
webadmin: rename quota limit labels
Quota grace and threshold labels should be renamed to
hard and soft limit respectivel
Tomas Jelinek has posted comments on this change.
Change subject: core,webadmin: Show Pools tab based on tree
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14073
To unsubscribe, visit http
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
frontend: Fix findbugs method doesn't start with lower case
Fix findbugs method doesn't start with a
Libor Spevak has posted comments on this change.
Change subject: core,webadmin: Show Pools tab based on tree
..
Patch Set 5: Verified
Thanks, Gilad for the remark.
--
To view, visit http://gerrit.ovirt.org/14073
To unsubscribe
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Rewrote Setup Networks operation logic
..
webadmin: Rewrote Setup Networks operation logic
To extend the dragging capabilities in the Setup Net
Tomas Jelinek has posted comments on this change.
Change subject: core,webadmin: Show Pools tab based on tree
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14073
To unsubscribe,
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: hardware: fix power cpu detection
..
vdsm: hardware: fix power cpu detection
Change-Id: I02329d762b86dfcce7d9f3157d348253d071d7bc
Signed-off-by: Pradipta K
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
frontend: Fix findbugs method doesn't start with lower case
Fix findbugs method doesn't start
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix findbugs method doesn't start with lower case
..
frontend: Fix findbugs method doesn't start with lower case
Fix findbugs method doesn't start
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: hardware: fix power cpu detection
..
vdsm: hardware: fix power cpu detection
Change-Id: I02329d762b86dfcce7d9f3157d348253d071d7bc
Signed-off-by: Pr
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: remove unused roles_relations
..
engine: remove unused roles_relations
remove unused 'roles_relations'
- table and related stored procedures
-
Alona Kaplan has abandoned this change.
Change subject: engine: remove dual mode from VmInterfaceType (wip)
..
Patch Set 2: Abandoned
In the past there was a cleanup patch to remove the dual mode support-
http://gerrit.ovirt.o
1 - 100 of 248 matches
Mail list logo
