Moti Asayag has posted comments on this change.
Change subject: engine: Support 3.1 network topologies by AttachNetwork
..
Patch Set 4: (3 inline comments)
File
backend/mana
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3756/
Build Number: 3756
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3755/
Build Number: 3755
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Roy Golan has posted comments on this change.
Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and
RunVmCommandBase
..
Patch Set 3:
liked it. cleaner than what I did.
please verify
--
To view, visit ht
Roy Golan has posted comments on this change.
Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and
RunVmCommandBase
..
Patch Set 3: Looks good to me, approved
liked it. cleaner than what I did.
--
To vi
Yair Zaslavsky has uploaded a new change for review.
Change subject: tools: Fix notifier to safely handle MAIL_SERVER
..
tools: Fix notifier to safely handle MAIL_SERVER
Change-Id: Ica12831cbb0b1ccae3d1f93c5d67e3ef9e5ae024
signe
Gilad Chaplik has posted comments on this change.
Change subject: userportal: VM/Pool handling refactored
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10740
To unsubscribe, visit http://g
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: AddVmFromTemplate - remove redundant logic
..
webadmin: AddVmFromTemplate - remove redundant logic
Removing redundant logic from VmListModel -> onSave()
Daniel Erez has uploaded a new change for review.
Change subject: userportal: fix SD selection on clone VM from template
..
userportal: fix SD selection on clone VM from template
Fixing storage domain selection when creating a V
Mike Kolesnik has posted comments on this change.
Change subject: engine: Allow skipping management network validation
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11307
To unsubscribe, v
Mike Kolesnik has posted comments on this change.
Change subject: engine: Support 3.1 network topologies by AttachNetwork
..
Patch Set 4: (3 inline comments)
File
backend/ma
Liron Ar has posted comments on this change.
Change subject: core: wip: initVdsOnUp - reconstructs and host status.
..
Patch Set 5: (1 inline comment)
File
backend/manager/m
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: VmTemplate cleanup (3/3)
..
engine: VmTemplate cleanup (3/3)
Renamed constructor parameters:
- numOfSockets -> numSockets
- vmtGuid -> vmTemplateId
- n
Liron Ar has posted comments on this change.
Change subject: core: wip: initVdsOnUp - reconstructs and host status.
..
Patch Set 5: (2 inline comments)
File
backend/manager/
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: fix SD selection on clone VM from template
..
userportal: fix SD selection on clone VM from template
Fixing storage domain selection when crea
Daniel Erez has posted comments on this change.
Change subject: userportal: fix SD selection on clone VM from template
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13374
To unsu
Vered Volansky has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments)
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Fixing mailserver validation
..
tools: Fixing mailserver validation
This solves mail server validation -
In case MAIL_SERVER does not exist, a p
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Fixing mailserver validation
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13735
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Fixing mailserver validation
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13735
To unsubscribe, visit h
Moti Asayag has posted comments on this change.
Change subject: core: Added Provider class
..
Patch Set 15: (1 inline comment)
File
backend/manager/modules/common/src/main/j
Moti Asayag has posted comments on this change.
Change subject: core: Add providedBy field to Network
..
Patch Set 15: (1 inline comment)
File
backend/manager/modules/common
Moti Asayag has posted comments on this change.
Change subject: core: Added Provider class
..
Patch Set 15: (4 inline comments)
File
backend/manager/modules/common/src/main/
Moti Asayag has posted comments on this change.
Change subject: engine: Support 3.1 network topologies by AttachNetwork
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13722
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: engine: Support 3.1 network topologies by AttachNetwork
..
Patch Set 3: (1 inline comment)
File
backend/manag
Moti Asayag has posted comments on this change.
Change subject: engine: Host with no display network should not be selected to
run VMs
..
Patch Set 5: (5 inline comments)
Fi
Laszlo Hornyak has posted comments on this change.
Change subject: engine: entity snapshot valiadation
..
Patch Set 2: Verified
tested end to end for most use cases, I have also checked over the call
hierarchy and did not find
Laszlo Hornyak has posted comments on this change.
Change subject: engine: upgrade postgres jdbc
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13549
To unsubscribe, visit http://gerrit.ovi
liron aravot has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 2:
Changed to be description filled that can be filled by initiator, though i
prefer the stacktrace
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: reimplemented engine_firewalld
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13609
To unsub
Liron Ar has restored this change.
Change subject: core: wip: initVdsOnUp - reconstructs and host status.
..
Patch Set 4: Restored
--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/se
Liron Ar has abandoned this change.
Change subject: core: wip: initVdsOnUp - reconstructs and host status.
..
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/
Liron Ar has posted comments on this change.
Change subject: core: wip: initVdsOnUp - reconstructs and host status.
..
Patch Set 4: (2 inline comments)
File
backend/manager/
Liron Ar has posted comments on this change.
Change subject: core: wip: initVdsOnUp - avoid reconstructs when unneeded.
..
Patch Set 3: (2 inline comments)
File
backend/mana
Liron Ar has posted comments on this change.
Change subject: core: avoid logging in ERROR on cancelled event.
..
Patch Set 2:
Michael, as we agreed f2f - i added a description field, so that when
submitting event we might add
Liron Ar has restored this change.
Change subject: core: initVdsOnUp - eliminate unneeded reconstructs.
..
Patch Set 2: Restored
--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 3:
Modified name to z_ovirt-engine-proxy.conf
Added note of prefix in configuration.
--
To view, v
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
PHP - I never experienced a problem installing php module.
FreeIPA, Spacewalk - both suffers fro
Juan Hernandez has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
Some examples of applications that fail loading httpd if the modules are not
loaded: PHP, Free
Ravi Nori has posted comments on this change.
Change subject: tools: Fixing mailserver validation
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13735
To unsubscribe, v
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
> The admin selected to run oVirt Engine, otherwise we won't be talking about
> this, and oVirt
Alissa Bonas has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/13640
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
The admin selected to run oVirt Engine, otherwise we won't be talking about
this, and oVirt En
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
Fail apache load because of engine cannot be run, is something that is not well
behaved either,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update httpd conf on engine-upgrade
..
Patch Set 2: (1 inline comment)
File packaging/fedora/setup
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update httpd conf on engine-upgrade
..
Patch Set 2: (1 inline comment)
> Patch updated, requires http://gerrit.ovirt.org/13751 to be merged first.
You
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing
..
Patch Set 1:
OSError exception if this directory is missing. I overlooked that.
--
To view, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
I don't like to force load something admin selected not to.
If you want to explicitly load modul
Liron Ar has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 4: (3 inline comments)
File
backend/manager/modules/bll
Juan Hernandez has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
Combined with:
Error "The proxy module is required by oVirt Engine."
--
To view, vi
Juan Hernandez has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
Instead of this I would prefer to explicitly load the required modules inside
our .conf file,
Alissa Bonas has posted comments on this change.
Change subject: core: validate vfstype is not empty for Posix conn
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13760
To unsubscribe, visit http://gerrit.ov
Alissa Bonas has uploaded a new change for review.
Change subject: core: validate vfstype is not empty for Posix conn
..
core: validate vfstype is not empty for Posix conn
Add validation when adding a new Posix storage connectio
Juan Hernandez has posted comments on this change.
Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing
..
Patch Set 1:
Can you explain (in the commit message) why this is needed?
--
To view, visit http://ge
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: update httpd conf on engine-upgrade
..
Patch Set 2:
Patch updated, requires http://gerrit.ovirt.org/13751 to be merged first.
--
To view, visit ht
Ravi Nori has posted comments on this change.
Change subject: cli: Add brick operation fails from ovirt-shell(#923169)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13756
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing
..
Patch Set 1: Verified
Verified in CI
--
To view, visit http://gerrit.ovirt.org/13742
To unsubscribe, v
Ravi Nori has uploaded a new change for review.
Change subject: cli: Add brick operation fails from ovirt-shell(#923169)
..
cli: Add brick operation fails from ovirt-shell(#923169)
Duplicate bricks are send when --brick-brick op
Ohad Basan has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13751
To unsubscribe, visit http://gerrit.ovirt.
Ohad Basan has posted comments on this change.
Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13742
To unsubscribe, visit http://gerrit
Tal Nisan has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12249
To u
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 22: (1 inline comment)
File packaging/fed
Tal Nisan has posted comments on this change.
Change subject: core: Remove PerformImagesChecks from AddDisk
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12641
To unsubscribe, visit http:/
Omer Frenkel has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 4: Looks good to me, but someone else must approve
thanks, waiting for Liron to take a look as well
--
T
Ravi Nori has posted comments on this change.
Change subject: restapi : missing sync option for action vm import in
RSDL(#949881)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13755
To unsubscribe, visit h
Juan Hernandez has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 22: (1 inline comment)
File packaging/f
Ravi Nori has uploaded a new change for review.
Change subject: restapi : missing sync option for action vm import in
RSDL(#949881)
..
restapi : missing sync option for action vm import in RSDL(#949881)
No sync option in cli fo
Tal Nisan has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13640
To unsubscribe, visit ht
Ravi Nori has posted comments on this change.
Change subject: cli: unclear error message when using unsupported 2 levels
attribute(#949642)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13754
To unsubscrib
Ravi Nori has uploaded a new change for review.
Change subject: cli: unclear error message when using unsupported 2 levels
attribute(#949642)
..
cli: unclear error message when using unsupported 2 levels attribute(#949642)
uncl
Omer Frenkel has posted comments on this change.
Change subject: core: removing canRunVm helper compat method
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules
Daniel Erez has posted comments on this change.
Change subject: core: Remove unused command VmToUserCommand.
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13507
To uns
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2: Looks good to me, but someone else must approve
ok, I'll fix my upgrade patch
--
To view, vi
Einav Cohen has posted comments on this change.
Change subject: userportal: VM/Pool handling refactored
..
Patch Set 2:
Gilad - any chance that you can re-review this patch? thanks.
--
To view, visit http://gerrit.ovirt.org/10
Einav Cohen has posted comments on this change.
Change subject: webadmin: Enable column resizing in Network main tab
..
Patch Set 2:
Alona - any chance that you can re-review this patch? Thanks.
--
To view, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
Patch Set 2:
sandro, note that in your upgrade patch...
--
To view, visit http://gerrit.ovirt.org/13751
To un
Arik Hadas has posted comments on this change.
Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and
RunVmCommandBase
..
Patch Set 3: Looks good to me, but someone else must approve
(3 inline comments)
.
Daniel Erez has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13640
T
Omer Frenkel has posted comments on this change.
Change subject: engine: Compare and set instead of updateVdsDynamic in VM
scenarios
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13682
To
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: proxy: rename proxy httpd conf.d file
..
packaging: proxy: rename proxy httpd conf.d file
in rhel the mod_proxy_ajp is loaded at its own conf.d file n
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3753/
Build Number: 3753
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: proxy: add missing /console.vv
..
packaging: proxy: add missing /console.vv
Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0
Signed-off-
Juan Hernandez has posted comments on this change.
Change subject: packaging: proxy: add missing /console.vv
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous ack and verification.
--
To view, visi
Juan Hernandez has posted comments on this change.
Change subject: packaging: proxy: add missing /console.vv
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13750
To unsubscribe, visit http:
Alissa Bonas has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
..
Patch Set 7: Verified
minor reformatting
--
To view, visit http://gerrit.ovirt.org/13640
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: proxy: add missing /console.vv
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13750
To unsubscribe, visit http://gerrit.ovirt.org/s
Alissa Bonas has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
..
Patch Set 6: Verified
added an optimization in UI as suggested by Daniel (offline)
--
To view, visit http://
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: proxy: add missing /console.vv
..
packaging: proxy: add missing /console.vv
Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0
Signed-off-by: Alon B
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 22: (1 inline comment)
File packaging/fed
Tal Nisan has uploaded a new change for review.
Change subject: core: Add VDSM error message for local directory not found
..
core: Add VDSM error message for local directory not found
Change-Id: I4e54455b4e11fe01c7d587692cd11bb
Michael Kublin has posted comments on this change.
Change subject: engine: Compare and set instead of updateVdsDynamic in VM
scenarios
..
Patch Set 2: (1 inline comment)
Fil
Shireesh Anjal has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
..
Patch Set 22: Looks good to me, approved
(2 inline comments)
Fil
Shireesh Anjal has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
..
Patch Set 20: (1 inline comment)
File
backend/manager/modules/bl
Juan Hernandez has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 22: (1 inline comment)
File packaging/f
Omer Frenkel has posted comments on this change.
Change subject: db: add missing vdc_option for 3.3
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13748
To unsubscribe,
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3752/
Build Number: 3752
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: reimplemented engine_firewalld
..
Patch Set 2: Verified
the bug affect users running f18 with ovirt 3.2. If a new build will be done
for 3.2 branc
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Display correct error when adding new storage
..
webadmin: Display correct error when adding new storage
When adding a new Storage Domain (of NFS/
Tal Nisan has posted comments on this change.
Change subject: webadmin: Display correct error when adding new storage
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13681
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: db: add missing vdc_option for 3.3
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13748
To unsubscrib
1 - 100 of 261 matches
Mail list logo