[Engine-patches] Change in ovirt-engine[master]: engine: Support 3.1 network topologies by AttachNetwork

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Support 3.1 network topologies by AttachNetwork .. Patch Set 4: (3 inline comments) File backend/mana

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 3756 - Still Failing!

2013-04-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3756/ Build Number: 3756 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 3755 - Failure!

2013-04-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3755/ Build Number: 3755 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing perfromance issue between VdsRunTimeInfo and ...

2013-04-09 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and RunVmCommandBase .. Patch Set 3: liked it. cleaner than what I did. please verify -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing perfromance issue between VdsRunTimeInfo and ...

2013-04-09 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and RunVmCommandBase .. Patch Set 3: Looks good to me, approved liked it. cleaner than what I did. -- To vi

[Engine-patches] Change in ovirt-engine[master]: tools: Fix notifier to safely handle MAIL_SERVER

2013-04-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: tools: Fix notifier to safely handle MAIL_SERVER .. tools: Fix notifier to safely handle MAIL_SERVER Change-Id: Ica12831cbb0b1ccae3d1f93c5d67e3ef9e5ae024 signe

[Engine-patches] Change in ovirt-engine[master]: userportal: VM/Pool handling refactored

2013-04-09 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal: VM/Pool handling refactored .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10740 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: webadmin: AddVmFromTemplate - remove redundant logic

2013-04-09 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: AddVmFromTemplate - remove redundant logic .. webadmin: AddVmFromTemplate - remove redundant logic Removing redundant logic from VmListModel -> onSave()

[Engine-patches] Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template

2013-04-09 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: userportal: fix SD selection on clone VM from template .. userportal: fix SD selection on clone VM from template Fixing storage domain selection when creating a V

[Engine-patches] Change in ovirt-engine[master]: engine: Allow skipping management network validation

2013-04-09 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Allow skipping management network validation .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11307 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Support 3.1 network topologies by AttachNetwork

2013-04-09 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Support 3.1 network topologies by AttachNetwork .. Patch Set 4: (3 inline comments) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp - reconstructs and host status.

2013-04-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: wip: initVdsOnUp - reconstructs and host status. .. Patch Set 5: (1 inline comment) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: engine: VmTemplate cleanup (3/3)

2013-04-09 Thread lhornyak
Laszlo Hornyak has uploaded a new change for review. Change subject: engine: VmTemplate cleanup (3/3) .. engine: VmTemplate cleanup (3/3) Renamed constructor parameters: - numOfSockets -> numSockets - vmtGuid -> vmTemplateId - n

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp - reconstructs and host status.

2013-04-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: wip: initVdsOnUp - reconstructs and host status. .. Patch Set 5: (2 inline comments) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template

2013-04-09 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: userportal: fix SD selection on clone VM from template .. userportal: fix SD selection on clone VM from template Fixing storage domain selection when crea

[Engine-patches] Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template

2013-04-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: fix SD selection on clone VM from template .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13374 To unsu

[Engine-patches] Change in ovirt-engine[master]: engine: Do not add disk in snapshot preview

2013-04-09 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Do not add disk in snapshot preview .. Patch Set 4: I would prefer that you didn't submit this (3 inline comments)

[Engine-patches] Change in ovirt-engine[master]: tools: Fixing mailserver validation

2013-04-09 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing mailserver validation .. tools: Fixing mailserver validation This solves mail server validation - In case MAIL_SERVER does not exist, a p

[Engine-patches] Change in ovirt-engine[master]: tools: Fixing mailserver validation

2013-04-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Fixing mailserver validation .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: tools: Fixing mailserver validation

2013-04-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Fixing mailserver validation .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Added Provider class

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Added Provider class .. Patch Set 15: (1 inline comment) File backend/manager/modules/common/src/main/j

[Engine-patches] Change in ovirt-engine[master]: core: Add providedBy field to Network

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Add providedBy field to Network .. Patch Set 15: (1 inline comment) File backend/manager/modules/common

[Engine-patches] Change in ovirt-engine[master]: core: Added Provider class

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Added Provider class .. Patch Set 15: (4 inline comments) File backend/manager/modules/common/src/main/

[Engine-patches] Change in ovirt-engine[master]: engine: Support 3.1 network topologies by AttachNetwork

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Support 3.1 network topologies by AttachNetwork .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/13722 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Support 3.1 network topologies by AttachNetwork

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Support 3.1 network topologies by AttachNetwork .. Patch Set 3: (1 inline comment) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: engine: Host with no display network should not be selected ...

2013-04-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Host with no display network should not be selected to run VMs .. Patch Set 5: (5 inline comments) Fi

[Engine-patches] Change in ovirt-engine[master]: engine: entity snapshot valiadation

2013-04-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: entity snapshot valiadation .. Patch Set 2: Verified tested end to end for most use cases, I have also checked over the call hierarchy and did not find

[Engine-patches] Change in ovirt-engine[engine_3.2]: engine: upgrade postgres jdbc

2013-04-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: upgrade postgres jdbc .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13549 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-04-09 Thread liron . aravot
liron aravot has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 2: Changed to be description filled that can be filled by initiator, though i prefer the stacktrace

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: reimplemented engine_firewalld

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: reimplemented engine_firewalld .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13609 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp - reconstructs and host status.

2013-04-09 Thread laravot
Liron Ar has restored this change. Change subject: core: wip: initVdsOnUp - reconstructs and host status. .. Patch Set 4: Restored -- To view, visit http://gerrit.ovirt.org/13709 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp - reconstructs and host status.

2013-04-09 Thread laravot
Liron Ar has abandoned this change. Change subject: core: wip: initVdsOnUp - reconstructs and host status. .. Patch Set 4: Abandoned -- To view, visit http://gerrit.ovirt.org/13709 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp - reconstructs and host status.

2013-04-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: wip: initVdsOnUp - reconstructs and host status. .. Patch Set 4: (2 inline comments) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: core: wip: initVdsOnUp - avoid reconstructs when unneeded.

2013-04-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: wip: initVdsOnUp - avoid reconstructs when unneeded. .. Patch Set 3: (2 inline comments) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: core: avoid logging in ERROR on cancelled event.

2013-04-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: avoid logging in ERROR on cancelled event. .. Patch Set 2: Michael, as we agreed f2f - i added a description field, so that when submitting event we might add

[Engine-patches] Change in ovirt-engine[master]: core: initVdsOnUp - eliminate unneeded reconstructs.

2013-04-09 Thread laravot
Liron Ar has restored this change. Change subject: core: initVdsOnUp - eliminate unneeded reconstructs. .. Patch Set 2: Restored -- To view, visit http://gerrit.ovirt.org/13709 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 3: Modified name to z_ovirt-engine-proxy.conf Added note of prefix in configuration. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: PHP - I never experienced a problem installing php module. FreeIPA, Spacewalk - both suffers fro

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: Some examples of applications that fail loading httpd if the modules are not loaded: PHP, Free

[Engine-patches] Change in ovirt-engine[master]: tools: Fixing mailserver validation

2013-04-09 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: Fixing mailserver validation .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: > The admin selected to run oVirt Engine, otherwise we won't be talking about > this, and oVirt

[Engine-patches] Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains

2013-04-09 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: webadmin, core: enable edit Posix storage domains .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/13640 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: The admin selected to run oVirt Engine, otherwise we won't be talking about this, and oVirt En

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: Fail apache load because of engine cannot be run, is something that is not well behaved either,

[Engine-patches] Change in ovirt-engine[master]: packaging: update httpd conf on engine-upgrade

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: update httpd conf on engine-upgrade .. Patch Set 2: (1 inline comment) File packaging/fedora/setup

[Engine-patches] Change in ovirt-engine[master]: packaging: update httpd conf on engine-upgrade

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: update httpd conf on engine-upgrade .. Patch Set 2: (1 inline comment) > Patch updated, requires http://gerrit.ovirt.org/13751 to be merged first. You

[Engine-patches] Change in ovirt-engine[master]: packaging: do not fail if /var/tmp/ovirt-engine missing

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing .. Patch Set 1: OSError exception if this directory is missing. I overlooked that. -- To view, visit http

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: I don't like to force load something admin selected not to. If you want to explicitly load modul

[Engine-patches] Change in ovirt-engine[master]: engine: Do not add disk in snapshot preview

2013-04-09 Thread laravot
Liron Ar has posted comments on this change. Change subject: engine: Do not add disk in snapshot preview .. Patch Set 4: (3 inline comments) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: Combined with: Error "The proxy module is required by oVirt Engine." -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: Instead of this I would prefer to explicitly load the required modules inside our .conf file,

[Engine-patches] Change in ovirt-engine[master]: core: validate vfstype is not empty for Posix conn

2013-04-09 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: validate vfstype is not empty for Posix conn .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13760 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: validate vfstype is not empty for Posix conn

2013-04-09 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: validate vfstype is not empty for Posix conn .. core: validate vfstype is not empty for Posix conn Add validation when adding a new Posix storage connectio

[Engine-patches] Change in ovirt-engine[master]: packaging: do not fail if /var/tmp/ovirt-engine missing

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing .. Patch Set 1: Can you explain (in the commit message) why this is needed? -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: packaging: update httpd conf on engine-upgrade

2013-04-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: update httpd conf on engine-upgrade .. Patch Set 2: Patch updated, requires http://gerrit.ovirt.org/13751 to be merged first. -- To view, visit ht

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Add brick operation fails from ovirt-shell(#923169)

2013-04-09 Thread rnori
Ravi Nori has posted comments on this change. Change subject: cli: Add brick operation fails from ovirt-shell(#923169) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/13756 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: packaging: do not fail if /var/tmp/ovirt-engine missing

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing .. Patch Set 1: Verified Verified in CI -- To view, visit http://gerrit.ovirt.org/13742 To unsubscribe, v

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Add brick operation fails from ovirt-shell(#923169)

2013-04-09 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: cli: Add brick operation fails from ovirt-shell(#923169) .. cli: Add brick operation fails from ovirt-shell(#923169) Duplicate bricks are send when --brick-brick op

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread obasan
Ohad Basan has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/13751 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: packaging: do not fail if /var/tmp/ovirt-engine missing

2013-04-09 Thread obasan
Ohad Basan has posted comments on this change. Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13742 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Extract SD validations from ImagesHandler

2013-04-09 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Extract SD validations from ImagesHandler .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12249 To u

[Engine-patches] Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration .. Patch Set 22: (1 inline comment) File packaging/fed

[Engine-patches] Change in ovirt-engine[master]: core: Remove PerformImagesChecks from AddDisk

2013-04-09 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Remove PerformImagesChecks from AddDisk .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12641 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: engine: Do not add disk in snapshot preview

2013-04-09 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Do not add disk in snapshot preview .. Patch Set 4: Looks good to me, but someone else must approve thanks, waiting for Liron to take a look as well -- T

[Engine-patches] Change in ovirt-engine[master]: restapi : missing sync option for action vm import in RSDL(#...

2013-04-09 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : missing sync option for action vm import in RSDL(#949881) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13755 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration .. Patch Set 22: (1 inline comment) File packaging/f

[Engine-patches] Change in ovirt-engine[master]: restapi : missing sync option for action vm import in RSDL(#...

2013-04-09 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : missing sync option for action vm import in RSDL(#949881) .. restapi : missing sync option for action vm import in RSDL(#949881) No sync option in cli fo

[Engine-patches] Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains

2013-04-09 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin, core: enable edit Posix storage domains .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13640 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unclear error message when using unsupported 2 levels a...

2013-04-09 Thread rnori
Ravi Nori has posted comments on this change. Change subject: cli: unclear error message when using unsupported 2 levels attribute(#949642) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13754 To unsubscrib

[Engine-patches] Change in ovirt-engine-cli[master]: cli: unclear error message when using unsupported 2 levels a...

2013-04-09 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: cli: unclear error message when using unsupported 2 levels attribute(#949642) .. cli: unclear error message when using unsupported 2 levels attribute(#949642) uncl

[Engine-patches] Change in ovirt-engine[master]: core: removing canRunVm helper compat method

2013-04-09 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: removing canRunVm helper compat method .. Patch Set 3: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused command VmToUserCommand.

2013-04-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Remove unused command VmToUserCommand. .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13507 To uns

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: Looks good to me, but someone else must approve ok, I'll fix my upgrade patch -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: userportal: VM/Pool handling refactored

2013-04-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: VM/Pool handling refactored .. Patch Set 2: Gilad - any chance that you can re-review this patch? thanks. -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: webadmin: Enable column resizing in Network main tab

2013-04-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Enable column resizing in Network main tab .. Patch Set 2: Alona - any chance that you can re-review this patch? Thanks. -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: rename proxy httpd conf.d file .. Patch Set 2: sandro, note that in your upgrade patch... -- To view, visit http://gerrit.ovirt.org/13751 To un

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing perfromance issue between VdsRunTimeInfo and ...

2013-04-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: engine: Fixing perfromance issue between VdsRunTimeInfo and RunVmCommandBase .. Patch Set 3: Looks good to me, but someone else must approve (3 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains

2013-04-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin, core: enable edit Posix storage domains .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13640 T

[Engine-patches] Change in ovirt-engine[master]: engine: Compare and set instead of updateVdsDynamic in VM sc...

2013-04-09 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarios .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13682 To

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: proxy: rename proxy httpd conf.d file .. packaging: proxy: rename proxy httpd conf.d file in rhel the mod_proxy_ajp is loaded at its own conf.d file n

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 3753 - Still Failing!

2013-04-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3753/ Build Number: 3753 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv

2013-04-09 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: proxy: add missing /console.vv .. packaging: proxy: add missing /console.vv Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0 Signed-off-

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: proxy: add missing /console.vv .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous ack and verification. -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: proxy: add missing /console.vv .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13750 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains

2013-04-09 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: webadmin, core: enable edit Posix storage domains .. Patch Set 7: Verified minor reformatting -- To view, visit http://gerrit.ovirt.org/13640 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: proxy: add missing /console.vv .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/13750 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains

2013-04-09 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: webadmin, core: enable edit Posix storage domains .. Patch Set 6: Verified added an optimization in UI as suggested by Daniel (offline) -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: proxy: add missing /console.vv .. packaging: proxy: add missing /console.vv Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0 Signed-off-by: Alon B

[Engine-patches] Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration

2013-04-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration .. Patch Set 22: (1 inline comment) File packaging/fed

[Engine-patches] Change in ovirt-engine[master]: core: Add VDSM error message for local directory not found

2013-04-09 Thread tnisan
Tal Nisan has uploaded a new change for review. Change subject: core: Add VDSM error message for local directory not found .. core: Add VDSM error message for local directory not found Change-Id: I4e54455b4e11fe01c7d587692cd11bb

[Engine-patches] Change in ovirt-engine[master]: engine: Compare and set instead of updateVdsDynamic in VM sc...

2013-04-09 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarios .. Patch Set 2: (1 inline comment) Fil

[Engine-patches] Change in ovirt-engine[master]: engine: Enable gluster hook on cluster

2013-04-09 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Enable gluster hook on cluster .. Patch Set 22: Looks good to me, approved (2 inline comments) Fil

[Engine-patches] Change in ovirt-engine[master]: engine: Enable gluster hook on cluster

2013-04-09 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Enable gluster hook on cluster .. Patch Set 20: (1 inline comment) File backend/manager/modules/bl

[Engine-patches] Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration

2013-04-09 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: less intrusive method for httpd integration .. Patch Set 22: (1 inline comment) File packaging/f

[Engine-patches] Change in ovirt-engine[master]: db: add missing vdc_option for 3.3

2013-04-09 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: db: add missing vdc_option for 3.3 .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13748 To unsubscribe,

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 3752 - Still Failing!

2013-04-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3752/ Build Number: 3752 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[engine_3.2]: packaging: reimplemented engine_firewalld

2013-04-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: reimplemented engine_firewalld .. Patch Set 2: Verified the bug affect users running f18 with ovirt 3.2. If a new build will be done for 3.2 branc

[Engine-patches] Change in ovirt-engine[master]: webadmin: Display correct error when adding new storage

2013-04-09 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Display correct error when adding new storage .. webadmin: Display correct error when adding new storage When adding a new Storage Domain (of NFS/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Display correct error when adding new storage

2013-04-09 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: Display correct error when adding new storage .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13681 To unsub

[Engine-patches] Change in ovirt-engine[master]: db: add missing vdc_option for 3.3

2013-04-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: db: add missing vdc_option for 3.3 .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13748 To unsubscrib

  1   2   3   >