Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Added generic checking DB state before upgrade
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1:
Please verify.
--
To view, visit http://gerrit.ovirt.org/13628
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13628
To unsubscribe, visit http:/
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-service: do not allow execution as non-root
..
packaging: engine-service: do not allow execution as non-root
all downstream has a mea
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: do not allow execution as non-root
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/136
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-service: remove /usr/bin symlink
..
packaging: engine-service: remove /usr/bin symlink
The engine-service script is not a utility to
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: remove /usr/bin symlink
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13626
To unsub
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-service: add missing global
..
packaging: engine-service: add missing global
Change-Id: Id7df1b3c222c5de67e96423ef0fd686e9cf579b0
Sig
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: add missing global
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13587
To unsubscrib
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-service: remove /usr/bin symlink
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13626
To unsubscribe, vi
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: support setting attributes on generated files
..
packaging: support setting attributes on generated files
ensure generated scripts are execu
Juan Hernandez has posted comments on this change.
Change subject: packaging: support setting attributes on generated files
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13579
To
Juan Hernandez has posted comments on this change.
Change subject: packaging: support setting attributes on generated files
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13579
To
Sahina Bose has posted comments on this change.
Change subject: restapi: Refactored BackendGlusterBrickResource
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13120
To unsubscribe, visit http://gerrit.ovirt.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 20: Verified
Can we merge this?
--
To view, visit http://gerrit.ovirt.org/13318
To unsubscrib
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use simplified template when handling
ovirt-engine-proxy.conf.in
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/13313
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: major cleanup
..
Patch Set 1: (1 inline comment)
Hi,
Appreciate any review. This is the last large change I am planning to service,
I
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: do not allow execution as non-root
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13627
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove /usr/bin symlink
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13626
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: remove /usr/bin symlink
..
packaging: engine-service: remove /usr/bin symlink
The engine-service script is not a utility to be used by
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: major cleanup
..
packaging: engine-service: major cleanup
Last patch in series of engine-service, after all core issues merged
into ex
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine-service: do not allow execution as non-root
..
packaging: engine-service: do not allow execution as non-root
all downstream has a mean to execu
Alon Bar-Lev has posted comments on this change.
Change subject: doc: fix wrong setting for fake and development
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13623
To unsubscrib
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: fix wrong setting for fake and development
..
doc: fix wrong setting for fake and development
Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d
S
Alon Bar-Lev has uploaded a new change for review.
Change subject: doc: fix wrong setting for fake and development
..
doc: fix wrong setting for fake and development
Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d
Signed-of
Ravi Nori has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13622
To unsubscribe, visit ht
Ravi Nori has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13622
To unsubscribe, visit ht
Ravi Nori has uploaded a new change for review.
Change subject: engine : ovirt-node enter installing status when the install
fails
..
engine : ovirt-node enter installing status when the install fails
When ovirt-node installati
Alex Lourie has posted comments on this change.
Change subject: packaging: Added generic checking DB state before upgrade
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/12512
To unsubscribe, visit http://ger
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove unused command VmPoolToAdGroupBaseCommand
..
Patch Set 5:
I think I misunderstood something, from what I saw
RemoveAdGroupCommand is not extending t
Omer Frenkel has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/
Michal Skrivanek has posted comments on this change.
Change subject: agent: Send non-blocking uninstalled notification without python
..
Patch Set 1: (3 inline comments)
File
Gilad Chaplik has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/
Daniel Paikov has posted comments on this change.
Change subject: core : AddVmFromSnapshot - use device information from snapshot.
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/12452
To unsubscribe, visit h
Daniel Paikov has posted comments on this change.
Change subject: [wip] core: OvfReader - set IsManaged to true for managed
devices
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13370
To unsubscribe, visit
Daniel Paikov has posted comments on this change.
Change subject: core: AddVmFromSnapshot - avoid early end method run
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12267
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core[WIP]: Remove not used ExtendVolume.
..
Patch Set 4: I would prefer that you didn't submit this
You should also remove the references to extendVolume in Irs
Allon Mureinik has posted comments on this change.
Change subject: core: Remove not used powerDownVDSCommand.
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13514
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused command VmPoolToAdGroupBaseCommand
..
Patch Set 5: I would prefer that you didn't submit this
You should also remove VmPoolToAdElementParame
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused command VmToUserCommand.
..
Patch Set 5: Looks good to me, but someone else must approve
After removing this command, RemoveUserCommand is t
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3881/
Build Number: 3881
Build Status: Fixed
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last Success:
Michael Kublin has posted comments on this change.
Change subject: core: Locate data source in a loop
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10189
To unsubscribe, visit http://gerri
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove api's StrigUtils
..
core: Remove api's StrigUtils
This patch removes the class
org.ovirt.engine.api.common.util.StringUtils.
It only had
Allon Mureinik has posted comments on this change.
Change subject: core: Remove api's StrigUtils
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes. Merging based on Michael's +2.
--
To view, visit h
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3880/
Build Number: 3880
Build Status: Still Unstable
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last
Michael Kublin has posted comments on this change.
Change subject: engine: Replacing call to host by query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13616
To unsubscribe, visit http://gerrit.ovirt.org/s
Daniel Erez has posted comments on this change.
Change subject: webadmin: make storage type field non editable
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13586
To unsubscribe, visit htt
Michael Kublin has posted comments on this change.
Change subject: engine: Improving GetAsyncTasksByStoragePoolId query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13615
To unsubscribe, visit http://gerri
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing saveOrUpdate qmethod in AsyncTaskUtils
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13614
To unsubscribe, visit http://gerr
Michael Kublin has uploaded a new change for review.
Change subject: engine: Improving GetAsyncTasksByStoragePoolId query
..
engine: Improving GetAsyncTasksByStoragePoolId query
The following patch will simplify a query, we don'
Michael Kublin has uploaded a new change for review.
Change subject: engine: Fixing saveOrUpdate qmethod in AsyncTaskUtils
..
engine: Fixing saveOrUpdate qmethod in AsyncTaskUtils
The following patch should solve a bug, when asy
Michael Kublin has uploaded a new change for review.
Change subject: engine: Replacing call to host by query
..
engine: Replacing call to host by query
The following patch should replace a call to host by query during moving hos
Allon Mureinik has posted comments on this change.
Change subject: core: Remove api's StrigUtils
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
Merging based on Michael's +2.
--
To view, visit h
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Short comparison findbugs
..
webadmin: Short comparison findbugs
Fixed findbugs warnings in StorageGeneralModel.java:129
and StorageGeneralModel.j
Tal Nisan has posted comments on this change.
Change subject: webadmin: Short comparison findbugs
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13613
To unsubscribe, visit http:/
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
..
restapi : Creating template by specifing vm name, does not work (#91528
Michael Pasternak has posted comments on this change.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerr
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Short comparison findbugs
..
webadmin: Short comparison findbugs
Fixed findbugs warnings in StorageGeneralModel.java:129
and StorageGeneralModel.java:142
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3879/
Build Number: 3879
Build Status: Still Unstable
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last
Liron Ar has posted comments on this change.
Change subject: wip: core: remove as sync verb.
..
Patch Set 2:
INCOMPLETE - don't review yet.
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ov
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add an alert when adding a Domain to uninitialized
pool
..
webadmin: Add an alert when adding a Domain to uninitialized pool
When trying to add a
Tal Nisan has posted comments on this change.
Change subject: webadmin: Add an alert when adding a Domain to uninitialized
pool
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/135
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Added POSIX VFS validation & hint on storage create
..
webadmin: Added POSIX VFS validation & hint on storage create
Added a validation of special
Tal Nisan has posted comments on this change.
Change subject: webadmin: Added POSIX VFS validation & hint on storage create
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13521
To
Liron Ar has abandoned this change.
Change subject: wip: core: remove as sync verb.
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messag
Liron Ar has restored this change.
Change subject: wip: core: remove as sync verb.
..
Patch Set 1: Restored
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageT
Michael Pasternak has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
..
Patch Set 4:
Douglas,
you can't do such changes just like that, both rename and/or
meaning change of the ele
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: add missing global
..
Patch Set 1: Verified
verified in CI environment
--
To view, visit http://gerrit.ovirt.org/13587
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: support setting attributes on generated files
..
Patch Set 2: Verified
verified in CI environment
--
To view, visit http://gerrit.ovirt.org/13579
To u
Ohad Basan has posted comments on this change.
Change subject: packaging: engine-service: add missing global
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13587
To unsubscribe, visit http://gerrit.ovirt.org
Vinzenz Feenstra has uploaded a new change for review.
Change subject: agent: Send non-blocking uninstalled notification without python
..
agent: Send non-blocking uninstalled notification without python
Remove the inline python
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Provide snapshot name to audit log
..
core: Provide snapshot name to audit log
VM snapshot name not provided in the event log when a snapshot
is
Allon Mureinik has posted comments on this change.
Change subject: core: Provide snapshot name to audit log
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13431
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Provide snapshot name to audit log
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13431
To unsubscribe, visit http:/
Ohad Basan has posted comments on this change.
Change subject: packaging: support setting attributes on generated files
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Ohad Basan has posted comments on this change.
Change subject: packaging: support setting attributes on generated files
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13579
To unsubscribe, visit http://gerri
Douglas Schilling Landgraf has posted comments on this change.
Change subject: restapi: ProductInfo use ProductRPMVersion
..
Patch Set 4:
Hi Michael,
> this would be an api break, please keep using old
> VdcVersion
> and for t
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: use simplified template when handling
ovirt-engine-proxy.conf.in
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit
Liron Ar has abandoned this change.
Change subject: wip: core: remove as sync verb.
..
Patch Set 1: Abandoned
abandoned till further verification
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://ger
Liron Ar has posted comments on this change.
Change subject: wip: core: remove as sync verb.
..
Patch Set 1: Fails
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: less intrusive method for httpd integration
..
Patch Set 20: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Liron Ar has uploaded a new change for review.
Change subject: wip: core: remove as sync verb.
..
wip: core: remove as sync verb.
When performing DeleteImageGroup, the engine can treat the call as
synchronous call as afterwards
Tal Nisan has posted comments on this change.
Change subject: webadmin: make storage type field non editable
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13586
To uns
Daniel Erez has posted comments on this change.
Change subject: engine,webadmin: Provide snapshot name to audit log
..
Patch Set 3: (1 inline comment)
Commit Message
Line 3:
Oved Ourfali has posted comments on this change.
Change subject: core: Remove GetUsersByVmid
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13593
To unsubscribe, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3878/
Build Number: 3878
Build Status: Still Unstable
Triggered By: Started by an SCM change
-
Changes Since Last Success:
Allon Mureinik has posted comments on this change.
Change subject: engine,webadmin: Provide snapshot name to audit log
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13431
To unsubscribe, v
Juan Hernandez has posted comments on this change.
Change subject: packaging: reimplemented engine_firewalld
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13609
To uns
Allon Mureinik has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13327
To u
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: reimplemented engine_firewalld
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13609
To unsubscribe, visit http://gerrit.ovirt.o
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: reimplemented engine_firewalld
..
packaging: reimplemented engine_firewalld
Reimplemented using the firewall-cmd command
instead of the python API
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused GetUsersByVmidQuery
..
core: Remove unused GetUsersByVmidQuery
Remove the GetUsersByVmidQuery, which is not used anywhere in the co
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused GetUsersByVmidQuery
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.or
Alissa Bonas has posted comments on this change.
Change subject: core: Locate data source in a loop
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10189
To unsubscribe,
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove the unused GetNonOperationalVdsQuery
..
core: Remove the unused GetNonOperationalVdsQuery
Remove GetNonOperationalVdsQuery, since it is no
Allon Mureinik has posted comments on this change.
Change subject: core: Remove the unused GetNonOperationalVdsQuery
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerri
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetVdsByTypeQuery leftovers
..
core: Remove GetVdsByTypeQuery leftovers
Removed the VdcQueryType.GetVdsByType constant and the
GetVdsByTyp
Allon Mureinik has posted comments on this change.
Change subject: core: Remove GetVdsByTypeQuery leftovers
..
Patch Set 2: Verified; Looks good to me, approved
Rebasde, fixed mistake in commit message - no code changes.
--
To
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetVdsByHostQuery leftovers
..
core: Remove GetVdsByHostQuery leftovers
Removed the VdcQueryType.GetVdsByHost constant and the
GetVdsByHos
Allon Mureinik has posted comments on this change.
Change subject: core: Remove GetVdsByHostQuery leftovers
..
Patch Set 2: Verified; Looks good to me, approved
Rebasde, fixed mistake in commit message - no code changes.
--
To
1 - 100 of 297 matches
Mail list logo
