Michael Kublin has posted comments on this change.
Change subject: core: Treat "only in db" zombie tasks
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/bll
Mike Kolesnik has posted comments on this change.
Change subject: core: Refactor SetupNetworksVdsCommand
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/vdsb
Daniel Erez has abandoned this change.
Change subject: core: remove disks perms on storage domain destroy
..
Patch Set 2: Abandoned
revisit after well defining storage domain destruction.
--
To view, visit http://gerrit.ovirt.
ofri masad has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12049
To u
ofri masad has posted comments on this change.
Change subject: core: no quota refresh when vm stopped on WaitForLaunch status
..
Patch Set 1: (1 inline comment)
File
backend
ofri masad has posted comments on this change.
Change subject: core: sanity check for cluster's quota
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: Don't use commons collections clone method
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11594
To unsubscribe, visi
ofri masad has posted comments on this change.
Change subject: userportal: quota permissions show extended view wrongfully
..
Patch Set 1: (1 inline comment)
File
frontend/w
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add jxpath as commons-configuration dep
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12095
To
Yair Zaslavsky has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
..
Patch Set 1: (1 inline comment)
File back
Yair Zaslavsky has posted comments on this change.
Change subject: core: use slf4j-jdk14 1.5.6
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12110
To unsubscribe, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: engine: AsyncTaskManager - fix restart part 1 (DB)
..
Patch Set 1:
no need to update fixtures.xml?
--
To view, visit http://gerrit.ovirt.org/12129
To unsubscri
Moti Asayag has posted comments on this change.
Change subject: engine: minor CommandBase change for rename logging
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11981
To unsubscribe, visi
Michael Kublin has posted comments on this change.
Change subject: core: Remove image while VDSM returns not exist.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler.getAllStorageIdsForImageIds
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12131
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
Patch Set 2: Verified
Fixed grammar as per Tal's comments
--
To view, visit http://gerrit.ovirt.org/12125
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler.getAllStorageIdsForImageIds
..
core: ImagesHandler.getAllStorageIdsForImageIds
Extracted a method to get all the relevant storage domains I
Michael Kublin has posted comments on this change.
Change subject: engine: AsyncTaskManager - fix restart part 1 (Clean ups)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12130
To unsubscribe, visit http://
Michael Kublin has posted comments on this change.
Change subject: engine: AsyncTaskManager - fix restart part 1 (DB)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12129
To unsubscribe, visit http://gerrit.
Michael Kublin has posted comments on this change.
Change subject: engine: AsyncTaskManager - restart fix part 1 (Logic)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12128
To unsubscribe, visit http://gerr
Michael Kublin has uploaded a new change for review.
Change subject: engine: AsyncTaskManager - fix restart part 1 (DB)
..
engine: AsyncTaskManager - fix restart part 1 (DB)
The following patch contains a changes for DB schema w
Michael Kublin has uploaded a new change for review.
Change subject: engine: AsyncTaskManager - fix restart part 1 (Clean ups)
..
engine: AsyncTaskManager - fix restart part 1 (Clean ups)
The following patch contains a clean ups
Michael Kublin has uploaded a new change for review.
Change subject: engine: AsyncTaskManager - restart fix part 1 (Logic)
..
engine: AsyncTaskManager - restart fix part 1 (Logic)
The following fix should change a current behavi
Allon Mureinik has restored this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
Patch Set 1: Restored
Changed my mind.
This is a refactoring patch - it takes a bug that was hidden and lays it out
Allon Mureinik has abandoned this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
Patch Set 1: Abandoned
See inline comments.
The original code has a bug in this area.
Might as well fix it instead
Allon Mureinik has posted comments on this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
..
core: Cleanup VmPoolCommandBase#isVmFree
Cleaned up VmPoolCommandBase's isVmFree method to make it more rea
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, fixed grammer issues noted by Tal.
re: moving the code t
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VDSCommandBase method names
..
core: VDSCommandBase method names
Renamed VDSCommandBase's methods to adhere to proper Java conventions.
Change-I
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcCommandBase method names
..
core: VdcCommandBase method names
Renamed VdcCommandBase's methods to adhere to proper Java conventions.
Change-I
Allon Mureinik has submitted this change and it was merged.
Change subject: core: QueriesCommandBase method names
..
core: QueriesCommandBase method names
Renamed QueriesCommandBase's methods to adhere to proper Java
convention
Allon Mureinik has posted comments on this change.
Change subject: core: VdcCommandBase method names
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: QueriesCommandBase method names
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: VDSCommandBase method names
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal.
--
To view, visit http://gerrit.ovi
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix dal test logging configuration
..
core: Fix dal test logging configuration
Fix the logging configuration in the dal module's tests:
* Make su
Allon Mureinik has posted comments on this change.
Change subject: core: Fix dal test logging configuration
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, fixed typo Tal commented on.
+2 by Tal, +1 by Alissa.
--
Allon Mureinik has submitted this change and it was merged.
Change subject: core: PostgresDataTypeFactory logger
..
core: PostgresDataTypeFactory logger
Changed PostgresDataTypeFactory to use the standard
org.ovirt.engine.core.
Allon Mureinik has posted comments on this change.
Change subject: core: PostgresDataTypeFactory logger
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Tal, +1 by Alissa.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1:
@Liron - The idea is to be able to log effectively, as you mentioned.
There are two considerations her
Allon Mureinik has posted comments on this change.
Change subject: core: Fix dal test logging configuration
..
Patch Set 1: (1 inline comment)
File backend/manager/modules/da
Tal Nisan has submitted this change and it was merged.
Change subject: core: Update StorageDomainDynamic methods to fit Java standard
..
core: Update StorageDomainDynamic methods to fit Java standard
Change-Id: Iee809cf4a74fb2f
Tal Nisan has posted comments on this change.
Change subject: core: Update StorageDomainDynamic methods to fit Java standard
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12101
T
Tal Nisan has submitted this change and it was merged.
Change subject: core: Update StorageDomainStatic methods to fit Java standard
..
core: Update StorageDomainStatic methods to fit Java standard
Change-Id: I6dca95fb547e36a9f
Tal Nisan has posted comments on this change.
Change subject: core: Update StorageDomainStatic methods to fit Java standard
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12100
To
Tal Nisan has submitted this change and it was merged.
Change subject: core: Update StorageDomain methods to fit Java standard
..
core: Update StorageDomain methods to fit Java standard
Change-Id: Ifd096ac10871e23c7b3c805969c56
Tal Nisan has posted comments on this change.
Change subject: core: Update StorageDomain methods to fit Java standard
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12099
To unsub
Tal Nisan has posted comments on this change.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12124
To unsubscribe, visit http://gerr
Tal Nisan has posted comments on this change.
Change subject: core: DiskImage Hierarchy cleanup
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12051
To unsubscribe, visit http://gerrit.ovir
Tal Nisan has posted comments on this change.
Change subject: core: VDSCommandBase method names
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12118
To unsubscribe, visit http://gerrit.ovir
Tal Nisan has posted comments on this change.
Change subject: core: QueriesCommandBase method names
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12117
To unsubscribe, visit http://gerrit.
Tal Nisan has posted comments on this change.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
..
Patch Set 1: (1 inline comment)
Logic wise seems ok aside for the minor grammar comment, but I must say that I
don't rea
Tal Nisan has posted comments on this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
Patch Set 1: (1 inline comment)
File
backend/manager/modul
Tal Nisan has posted comments on this change.
Change subject: core: Fix dal test logging configuration
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Minor typo
.
Tal Nisan has posted comments on this change.
Change subject: core: PostgresDataTypeFactory logger
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12080
To unsubscribe, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: core: VdcCommandBase method names
..
Patch Set 3: Looks good to me, approved
Go janitors team! :)
--
To view, visit http://gerrit.ovirt.org/12113
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12125
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12124
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has uploaded a new change for review.
Change subject: core: VmPoolCommandBase: Direct domain validation
..
core: VmPoolCommandBase: Direct domain validation
Stopped using ImagesHandler to validate the storage doma
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup VmPoolCommandBase#isVmFree
..
core: Cleanup VmPoolCommandBase#isVmFree
Cleaned up VmPoolCommandBase's isVmFree method to make it more readable:
1
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: bridge: /proc/net/vlan may contain tabs
..
vdsm: bridge: /proc/net/vlan may contain tabs
Reference-Url: http://lists.ovirt.org/pipermail/users/2013
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: bridge: /proc/net/vlan may contain tabs
..
Patch Set 1: Verified; Looks good to me, approved
Verified by reporter.
--
To view, visit http://gerrit.ovirt.or
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: bridge: /proc/net/vlan may contain tabs
..
vdsm: bridge: /proc/net/vlan may contain tabs
Reference-Url: http://lists.ovirt.org/pipermail/users/2013-Februar
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: bridge: cleanup bridge/vlan message
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12122
To unsubscribe, vis
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: bridge: cleanup bridge/vlan message
..
vdsm: bridge: cleanup bridge/vlan message
Change-Id: Ic8778566a34808ac777510ab1c918c2cf92bae20
Signed-off-by
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: bridge: use \d in re
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12121
To unsubscribe, visit http://gerri
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: bridge: use \d in re
..
vdsm: bridge: use \d in re
Change-Id: Ic327281feb8368c3fe42c6eb6013cc5aff151ad4
Signed-off-by: Alon Bar-Lev
---
M src/plug
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: bridge: /proc/net/vlan may contain tabs
..
Patch Set 1: Verified; Looks good to me, approved
Verified by reporter.
--
To view, visit http://gerrit.ovirt.or
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: bridge: /proc/net/vlan may contain tabs
..
vdsm: bridge: /proc/net/vlan may contain tabs
Reference-Url: http://lists.ovirt.org/pipermail/users/2013
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: bridge: cleanup bridge/vlan message
..
vdsm: bridge: cleanup bridge/vlan message
Change-Id: Ic8778566a34808ac777510ab1c918c2cf92bae20
Signed-off-by: Alon B
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: bridge: /proc/net/vlan may contain tabs
..
vdsm: bridge: /proc/net/vlan may contain tabs
Reference-Url: http://lists.ovirt.org/pipermail/users/2013-Februar
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: bridge: use \d in re
..
vdsm: bridge: use \d in re
Change-Id: Ic327281feb8368c3fe42c6eb6013cc5aff151ad4
Signed-off-by: Alon Bar-Lev
---
M src/plugins/ovir
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
..
engine: Corrections to Event.equal to avoid confusions and unexpect
Asaf Shakarchi has posted comments on this change.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://
liron aravot has posted comments on this change.
Change subject: core: Remove image while VDSM returns not exist.
..
Patch Set 1: (3 inline comments)
File
backend/manager/mo
74 matches
Mail list logo
