Sharad Mishra has abandoned this change.
Change subject: core: WIP: Add suppoort for SSL in LDAP.
..
Patch Set 2: Abandoned
Authorization and authentication is being completely rewritten.
--
To view, visit http://gerrit.ovirt.
Ayal Baron has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 2: (3 inline comments)
File
backend
Allon Mureinik has posted comments on this change.
Change subject: core: clean up VDSGroup.equals()
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12061
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: VDSCommandBase method names
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12118
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: QueriesCommandBase method names
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/12117
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has posted comments on this change.
Change subject: core: VdcCommandBase method names
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12113
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has submitted this change and it was merged.
Change subject: core: AsyncTaskDAO proper newline logging
..
core: AsyncTaskDAO proper newline logging
Used the %n platform independent newline instead of the platform
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO proper newline logging
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12112
To unsubscribe, v
Asaf Shakarchi has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1:
I only see 'slf4j' in Fedora (no slf4j-log4j), I'd like to have the same slf4j
logging implementation
Allon Mureinik has uploaded a new change for review.
Change subject: core: VDSCommandBase method names
..
core: VDSCommandBase method names
Renamed VDSCommandBase's methods to adhere to proper Java conventions.
Change-Id: Iccff
Allon Mureinik has uploaded a new change for review.
Change subject: core: QueriesCommandBase method names
..
core: QueriesCommandBase method names
Renamed QueriesCommandBase's methods to adhere to proper Java
conventions.
Chan
Asaf Shakarchi has posted comments on this change.
Change subject: core: AsyncTaskDAO proper newline logging
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12112
To unsubscribe, visit http:
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin,userportal: gwt-maven-plugin POM cleanup
..
webadmin,userportal: gwt-maven-plugin POM cleanup
This patch eliminates some duplicities in WebAdm
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin,userportal: gwt-maven-plugin POM cleanup
..
Patch Set 2: Verified; Looks good to me, approved
Thanks Vojtech.
--
To view, visit http://gerrit.ovirt.or
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: introducing German (de) - part 2
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12116
To unsubscribe, visit http://gerrit
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: introducing German (de)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12115
To unsubscribe, visit http://gerrit.ovirt.or
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: introducing German (de)
..
webadmin, userportal: introducing German (de)
With this patch, the German (de) locale will be available for displ
Allon Mureinik has posted comments on this change.
Change subject: core: VdcCommandBase method names
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12113
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO proper newline logging
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12112
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has uploaded a new change for review.
Change subject: core: VdcCommandBase method names
..
core: VdcCommandBase method names
Renamed VdcCommand's methods to adhere to proper Java conventions.
Change-Id: I8bc15801
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO proper newline logging
..
core: AsyncTaskDAO proper newline logging
Used the %n platform independent newline instead of the platform
specifi
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3531/
Build Number: 3531
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12111
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: Update StorageDomain methods to fit Java standard
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12099
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: Update StorageDomainStatic methods to fit Java standard
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12100
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: Update StorageDomainDynamic methods to fit Java standard
..
Patch Set 1: Looks good to me, approved
I'd squash all three patches in this chain (StorageDom
Allon Mureinik has posted comments on this change.
Change subject: core: Update StorageDomainStatic methods to fit Java standard
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Update StorageDomain methods to fit Java standard
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused action type enums.
..
Patch Set 1: Looks good to me, approved
(2 inline comments)
I'd squash removing the params classes in to this patch,
Allon Mureinik has posted comments on this change.
Change subject: core: Remove image while VDSM returns not exist.
..
Patch Set 1: Looks good to me, but someone else must approve
(6 inline comments)
Please fix the grammer iss
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 8: I would prefer that you didn't submit this
code looks fine to me.
please correct
Allon Mureinik has uploaded a new change for review.
Change subject: core: use slf4j-jdk14 1.5.6
..
core: use slf4j-jdk14 1.5.6
Downgraded slf4j-jdk14 to be compatible with log4j 1.2.16 that we use in
the project.
Change-Id: I0
Alon Bar-Lev has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 4: (1 inline comment)
File
fronten
Einav Cohen has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 7:
vojtech - can you please do the final review for this patch (and make sure that
everything tha
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Non-plugin automatic invocation of console session
..
Patch Set 4: (1 inline comment)
File
fronte
Alexander Wels has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 7:
Okay not sure what happened here, I pushed the other patch and this patch was
made as well?
Alexander Wels has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 6: Verified
Turns out to be a small change without the logout disabling stuff.
--
To view, vis
Vojtech Szocs has posted comments on this change.
Change subject: userportal: fix memory leaks
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11975
To unsubscribe, visi
Vojtech Szocs has posted comments on this change.
Change subject: userportal: stop basic list provider on extended tab.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Hello Vojtech Szocs,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/12104
to review the following change.
Change subject: userportal: stop basic list provider on extended tab.
..
userportal: stop b
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Fix memory leaks
..
Patch Set 7: Looks good to me, but someone else must approve
Alex found out that there's still a memory leak related to
UserPort
Alissa Bonas has posted comments on this change.
Change subject: core: PostgresDataTypeFactory logger
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12080
To unsubscrib
Alissa Bonas has posted comments on this change.
Change subject: core: Fix dal test logging configuration
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12081
To unsubs
Alissa Bonas has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1: Looks good to me, but someone else must approve
It will be a good idea, following Liron's comment, to ad
Laszlo Hornyak has posted comments on this change.
Change subject: engine: Version cleanup
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/compat/src/test/ja
Laszlo Hornyak has posted comments on this change.
Change subject: engine: minor CommandBase change for rename logging
..
Patch Set 2:
rewritten for the merged version of Eli's patch, please review
--
To view, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: ovirt:failed to create engine db because of locale
..
Patch Set 1: (1 inline comment)
File backend/manager/
Allon Mureinik has posted comments on this change.
Change subject: core: Make explicit version of maven ear plugin
..
Patch Set 3: Looks good to me, approved
@Juan - do you want me to merge this?
--
To view, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: Make explicit version of maven war plugin
..
Patch Set 3: Looks good to me, approved
@Juan - do you want me to merge this?
--
To view, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: Make antrun plugin version explicit
..
Patch Set 3: Looks good to me, approved
@Juan - do you want me to merge this?
--
To view, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Don't use commons collections clone method
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11594
Allon Mureinik has posted comments on this change.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, vi
liron aravot has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1: (2 inline comments)
File backend/manager/modules/da
Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
liron aravot has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Allon Mureinik has posted comments on this change.
Change subject: code: Replace slf4j-nop with slf4j-log4j
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12082
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Fix dal test logging configuration
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12081
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: PostgresDataTypeFactory logger
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12080
To unsubscribe, visit http://gerrit.ovirt.org/sett
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3530/
Build Number: 3530
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,317
-
Changes
Doron Fediuck has posted comments on this change.
Change subject: engine: add qouta mode check in consume storage
..
Patch Set 2: (1 inline comment)
File
backend/manager/mod
Ravi Nori has posted comments on this change.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12103
To unsubscribe, visit http://
Ravi Nori has uploaded a new change for review.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
..
tools : taskcleaner.sh utility returns always 0 as return code
taskcleaner.sh always returns exit
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix NPE on Jboss startup
..
restapi: Fix NPE on Jboss startup
Fixed an NPE on Jboss startup caused by trying to get the wrong key from
the stats ma
Tal Nisan has posted comments on this change.
Change subject: restapi: Fix NPE on Jboss startup
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12102
To unsubscribe, visit http://g
Tal Nisan has posted comments on this change.
Change subject: core: Update StorageDomainDynamic methods to fit Java standard
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12101
To unsubscribe, visit http://
Tal Nisan has posted comments on this change.
Change subject: core: Update StorageDomainStatic methods to fit Java standard
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12100
To unsubscribe, visit http://g
Selvasundaram has posted comments on this change.
Change subject: engine: Get gluster hooks query
..
Patch Set 9: (8 inline comments)
File backend/manager/dbscripts/gluster_h
Tal Nisan has posted comments on this change.
Change subject: core: Update StorageDomain methods to fit Java standard
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12099
To unsubscribe, visit http://gerrit.
Tal Nisan has uploaded a new change for review.
Change subject: restapi: Fix NPE on Jboss startup
..
restapi: Fix NPE on Jboss startup
Fixed an NPE on Jboss startup caused by trying to get the wrong key from
the stats map, the n
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: set up Proxy property to SPICE
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
.
Tal Nisan has uploaded a new change for review.
Change subject: core: Update StorageDomainDynamic methods to fit Java standard
..
core: Update StorageDomainDynamic methods to fit Java standard
Change-Id: Iee809cf4a74fb2f87686748
Michal Skrivanek has posted comments on this change.
Change subject: core: Added SpiceProxyDefault property to vdc_options
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Tomas Jelinek has posted comments on this change.
Change subject: webadmin,userportal: set up Proxy property to SPICE
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12093
To unsubscribe, visit http://gerrit.
Tomas Jelinek has posted comments on this change.
Change subject: tools: Added SpiceProxyDefault property to vdc_options
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12092
To unsubscribe, visit http://gerr
Tomas Jelinek has posted comments on this change.
Change subject: core: Added SpiceProxyDefault property to vdc_options
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/12091
To unsubscribe, visit http://gerri
Tomas Jelinek has posted comments on this change.
Change subject: core: Added SpiceProxyDefault property to vdc_options
..
Patch Set 2: (1 inline comment)
File backend/manage
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: move to template oriented concept
..
codegen: move to template oriented concept
Change-Id: I999f64d74f09a813d16ec5877efa8a4949db18c2
Signed
Michael Pasternak has posted comments on this change.
Change subject: codegen: move to template oriented concept
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12097
To unsubscrib
Juan Hernandez has posted comments on this change.
Change subject: core: Make explicit version of maven ear plugin
..
Patch Set 3: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/11684
To unsubscribe, visit http://
Juan Hernandez has posted comments on this change.
Change subject: core: Maven plugin to generate JBoss modules
..
Patch Set 2: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/12072
To unsubscribe, visit http://ger
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 3: Verified
Added some missing dependencies.
--
To view, visit http://gerrit.ovirt.org/11686
To uns
Juan Hernandez has posted comments on this change.
Change subject: core: Create artifact for PostgreSQL module
..
Patch Set 3: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/11685
To unsubscribe, visit http://gerr
Juan Hernandez has posted comments on this change.
Change subject: core: Make explicit version of maven war plugin
..
Patch Set 3: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/11683
To unsubscribe, visit http://
Juan Hernandez has posted comments on this change.
Change subject: core: Make antrun plugin version explicit
..
Patch Set 3: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/11682
To unsubscribe, visit http://gerrit
Juan Hernandez has posted comments on this change.
Change subject: core: Don't use commons collections clone method
..
Patch Set 4: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/11594
To unsubscribe, visit http:/
Juan Hernandez has posted comments on this change.
Change subject: tools: Use JBoss modules instead of class path
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12096
To unsubscribe, visit http://gerrit.ovir
Juan Hernandez has posted comments on this change.
Change subject: core: Add jxpath as commons-configuration dep
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12095
To unsubscribe, visit http://gerrit.ovirt
Juan Hernandez has posted comments on this change.
Change subject: core: Add JBoss modules for libraries
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/12094
To unsubscribe, visit http://gerrit.ovirt.org/set
Juan Hernandez has uploaded a new change for review.
Change subject: tools: Use JBoss modules instead of class path
..
tools: Use JBoss modules instead of class path
Currently in order to run the tools we build the class path us
Juan Hernandez has uploaded a new change for review.
Change subject: core: Add JBoss modules for libraries
..
core: Add JBoss modules for libraries
This patch creates JBoss modules for the common, compat, dal, utils and
searchba
Juan Hernandez has uploaded a new change for review.
Change subject: core: Add jxpath as commons-configuration dep
..
core: Add jxpath as commons-configuration dep
The commons-configuration module provided by JBoss AS doesn't in
Michal Skrivanek has posted comments on this change.
Change subject: core: Added SpiceProxy property to vdc_options
..
Patch Set 2: (1 inline comment)
File backend/manager/db
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3529/
Build Number: 3529
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,316
-
Changes
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow importing ISO domain on setup, exports.d
support
..
Patch Set 7: Verified
rebased, verified.
--
To view, visit http://gerrit.ovirt.org/1155
94 matches
Mail list logo
