Alon Bar-Lev has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1:
Roy, I don't understand the question, this is not belongs to tools... no?
--
To view, visit http:/
Frank Kobzik has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/10770
To unsubscribe, visit http://gerr
Roy Golan has posted comments on this change.
Change subject: core: add mapping for internalVdsmTimoutError
..
Patch Set 3:
not merging yet due to dependency on VDSM patch otherwise the exception output
is useless
--
To view,
Roy Golan has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1:
just a thought - is it worth keeping encryptionutils outside so it can be
updated independently? the
Frank Kobzik has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
..
Patch Set 6:
(There will be (at least) one more patchset in a while.)
--
To view, visit http://gerrit.
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2857/
Build Number: 2857
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-manage-domains: Adding man page
..
engine-manage-domains: Adding man page
Fix change I26e69ce141 engine-manage-domains.8
Change-Id: Icd979479d4
Yair Zaslavsky has posted comments on this change.
Change subject: engine-manage-domains: Adding man page
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11665
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: core: Custom Materialized Views should be...
..
Patch Set 1: (1 inline comment)
By the way, maybe we would like to add a function of
createcustommaterializedv
Yair Zaslavsky has posted comments on this change.
Change subject: core: Custom Materialized Views should be...
..
Patch Set 1:
Looks good, I would like Allon to take a second look
--
To view, visit http://gerrit.ovirt.org/11
Yair Zaslavsky has posted comments on this change.
Change subject: core: Custom Materialized Views should be...
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11669
To
Yair Zaslavsky has posted comments on this change.
Change subject: Hosts from another data center displayed when...
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11541
To unsubscribe, visi
Kanagaraj M has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11391
To uns
Moti Asayag has uploaded a new change for review.
Change subject: core: Add login action group to NetworkUser role
..
core: Add login action group to NetworkUser role
For the sake of consistency with the other predefined roles,
Moti Asayag has uploaded a new change for review.
Change subject: api: slave interfaces are being overridden
..
api: slave interfaces are being overridden
When the client provides a bond with its slaves, the slaves are
being rel
Tal Nisan has uploaded a new change for review.
Change subject: core: Eliminated use of StringHelper.EqOp
..
core: Eliminated use of StringHelper.EqOp
Removed the method StringHelper.EqOp, it was used mainly in searchbackend
mod
Eli Mesika has uploaded a new change for review.
Change subject: core: Custom Materialized Views should be...
..
core: Custom Materialized Views should be...
Custom Materialized Views should be treated differently from
regular
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed DoubleCompat class
..
core: Removed DoubleCompat class
Change-Id: Ia5f3cb48bf49064de543c9478bbb2b445055bbb0
Signed-off-by: Tal Nisan
---
D
backend/m
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
..
core: Streamline RemoveExternalEvent canDoAction()
Streamlined and cleaned up RemoveExternalEvent
Allon Mureinik has posted comments on this change.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes
--
To view, visit http://gerri
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed classes DateTimeStyles, CultureInfo,
TimeFormatValidation
..
core: Removed classes DateTimeStyles, CultureInfo, TimeFormatValidation
Removed the clas
Tal Nisan has posted comments on this change.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
..
Patch Set 2: Looks good to me, approved
I forgive you for rebasing ;)
--
To view, visit http://gerrit.ovirt.or
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed the LongCompat class
..
core: Removed the LongCompat class
Removed the LongCompat class and replaced all calls in Long.parse with
catching NumberForma
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Don't use EqOp on constants in commons
..
core: Don't use EqOp on constants in commons
This patch removes the usage on StringHelper.EqOp for stri
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Don't check equality in BE setters
..
core: Don't check equality in BE setters
Some old business entities used the change-check idiom in their se
Allon Mureinik has posted comments on this change.
Change subject: core: Don't check equality in BE setters
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Don't use EqOp on constants in commons
..
Patch Set 4: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ovi
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove domains member from storage_pool
..
core: Remove domains member from storage_pool
Removed the private member "domains" from the storage_po
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove userGroup member from tags
..
core: Remove userGroup member from tags
Removed the private member "userGroup" from the tags class. This
mem
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DEFAULT_PRESTARTED_VMS constant as static
..
core: DEFAULT_PRESTARTED_VMS constant as static
Changed the DEFAULT_PRESTARTED_VMS constant in vm_po
Allon Mureinik has submitted this change and it was merged.
Change subject: core: HOST_DEFAULT_SPM_PRIORITY constant as static
..
core: HOST_DEFAULT_SPM_PRIORITY constant as static
Changed the HOST_DEFAULT_SPM_PRIORITY constant
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmPayload: efficient map iteration
..
core: VmPayload: efficient map iteration
Replaced a keySet() iteration with a more efficient entrySet()
ite
Allon Mureinik has posted comments on this change.
Change subject: core: Remove domains member from storage_pool
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Remove userGroup member from tags
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: VmPayload: efficient map iteration
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: HOST_DEFAULT_SPM_PRIORITY constant as static
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: DEFAULT_PRESTARTED_VMS constant as static
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
..
Patch Set 2: Verified
Replaced equals with == as discussed in previous patchset.
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
..
Patch Set 1: (1 inline comment)
File
backend/manager
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Clean up RemoveStoragePool.canDoAction
..
core: Clean up RemoveStoragePool.canDoAction
General Java cleanup to RemoveStorageDomain.canDoAction()
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up RemoveStoragePool.canDoAction
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerrit.ovi
Alissa Bonas has posted comments on this change.
Change subject: core: Removed NumberStyles class
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11663
To unsubscribe, v
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine-manage-domains: Adding man page
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/116
Alon Bar-Lev has posted comments on this change.
Change subject: engine-manage-domains: Adding man page
..
Patch Set 4:
Yair,
Next time, please CC juan and optionally me on packaging patches.
Thanks!
--
To view, visit http:/
Alon Bar-Lev has posted comments on this change.
Change subject: engine-manage-domains: Adding man page
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11665
To unsubscribe, visit http://gerrit.ovirt.org/sett
Tal Nisan has posted comments on this change.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
..
Patch Set 1: (1 inline comment)
File
backend/
Alissa Bonas has posted comments on this change.
Change subject: core: Removed deprecated StringTokenizerCompat class
..
Patch Set 1: I would prefer that you didn't submit this
looks like you missed removing reference to delete
Alon Bar-Lev has uploaded a new change for review.
Change subject: engine-manage-domains: Adding man page
..
engine-manage-domains: Adding man page
Fix change I26e69ce141 engine-manage-domains.8
Change-Id: Icd979479d40c0cdae1db
Alissa Bonas has posted comments on this change.
Change subject: core: Removed MatchCollection class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11664
To unsubscribe
Alissa Bonas has posted comments on this change.
Change subject: core: Removed NumberStyles class
..
Patch Set 1: I would prefer that you didn't submit this
Marking -1 just to be on safe side (the code in the patch is completel
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed MatchCollection class
..
core: Removed MatchCollection class
Removed the class MatchCollection from the compat module, also
removed the methods using
Alissa Bonas has posted comments on this change.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
..
Patch Set 1: (1 inline comment)
File
backe
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed NumberStyles class
..
core: Removed NumberStyles class
Removed the class NumberStyles from the compat module, also
removed the methods using it, all o
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed deprecated StringTokenizerCompat class
..
core: Removed deprecated StringTokenizerCompat class
Removed the deprecated StringTokenizerCompat class and
Tal Nisan has posted comments on this change.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
..
Patch Set 1: (2 inline comments)
File
backend
Alissa Bonas has posted comments on this change.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
..
Patch Set 1: (6 inline comments)
File
back
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed deprecated StringBuilderCompat class
..
core: Removed deprecated StringBuilderCompat class
Remove the deprecated StringBuilderCompat class and replace
Ayal Baron has posted comments on this change.
Change subject: engine: Removal of code related to importing SAN storage domains
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Tal Nisan has uploaded a new change for review.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
..
core: Removed unnecessary calls to StringFormat & StringHelper
Replaced calls to StringFormat.form
Maor Lipchuk has restored this change.
Change subject: core: Use validate instead using space checker
..
Patch Set 2: Restored
Restore to send a patch which will replace it.
--
To view, visit http://gerrit.ovirt.org/11588
To u
Maor Lipchuk has posted comments on this change.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove domains member from storage_pool
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11642
To u
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove userGroup member from tags
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11643
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: core: DEFAULT_PRESTARTED_VMS constant as static
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11646
To
Maor Lipchuk has posted comments on this change.
Change subject: core: HOST_DEFAULT_SPM_PRIORITY constant as static
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11645
Maor Lipchuk has posted comments on this change.
Change subject: core: VmPayload: efficient map iteration
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11644
To unsubs
Maor Lipchuk has posted comments on this change.
Change subject: core: Change CommandBase validate method to accept multiple
results
..
Patch Set 1: (1 inline comment)
File
Tal Nisan has uploaded a new change for review.
Change subject: core: Remove deprecated DictionaryEntry from compat
..
core: Remove deprecated DictionaryEntry from compat
Removed the deprecated class DictionaryEntry from compat,
Eli Mesika has posted comments on this change.
Change subject: Hosts from another data center displayed when...
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/11541
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
core: removal unneeded boolean and finally block from recovery command.
When
Maor Lipchuk has posted comments on this change.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1162
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: use return value instead of a shared boolean in recovery
..
core: use return value instead of a shared boolean in recovery
This patch adds the use
Maor Lipchuk has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11619
To unsub
Liron Aravot has posted comments on this change.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebased, +1 fro
Liron Aravot has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
+1 from Allon, no changes
Liron Aravot has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 3: (1 inline comment)
File
backe
Liron Aravot has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 3: (1 inline comment)
File
backe
Daniel Erez has posted comments on this change.
Change subject: webadmin: Non-VM networks not being detached from cluster
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11654
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 3: (1 inline comment)
File
bac
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3420/
Build Number: 3420
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 4,182
-
Changes Since La
Maor Lipchuk has posted comments on this change.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1162
Allon Mureinik has posted comments on this change.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http:
Omer Frenkel has posted comments on this change.
Change subject: core: add mapping for internalVdsmTimoutError
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10357
To unsubscribe, visit htt
Liron Aravot has posted comments on this change.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11620
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: core: use return value instead of a shared boolean in recovery
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11619
To unsubscribe, visit http
Liron Aravot has restored this change.
Change subject: core: use return value instead of a shared boolean
..
Patch Set 1: Restored
verified, further changes done after rebase.
--
To view, visit http://gerrit.ovirt.org/11619
To
Liron Aravot has restored this change.
Change subject: core: removal unneeded boolean and finally block from recovery
command.
..
Patch Set 1: Restored
verified, further changes done after rebase.
--
To view, visit http://ger
Maor Lipchuk has posted comments on this change.
Change subject: core: prevent master version update on storage pool update
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11657
To unsubscri
Liron Aravot has uploaded a new change for review.
Change subject: core: prevent master version update on storage pool update
..
core: prevent master version update on storage pool update
When updating storage pool the update ma
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11558
T
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1:
My question is minor - giving +1
--
To view, visit http://gerrit.ovirt.org/11558
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1: (1 inline comment)
File pom.xml
Line 198:
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix multiple domains to support useDnsLookup flag
..
core: Fix multiple domains to support useDnsLookup flag
Even if useDnsLookup flag is set to
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix multiple domains to support useDnsLookup flag
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11655
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Find bugs fix at manage-domains
..
core: Find bugs fix at manage-domains
Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b0
Signed-off-by: Yair
Yair Zaslavsky has posted comments on this change.
Change subject: core: Find bugs fix at manage-domains
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11653
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Find bugs fix at manage-domains
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11653
To unsubscribe, visit
Michael Kublin has submitted this change and it was merged.
Change subject: core: executing squartz job immediately
..
core: executing squartz job immediately
This patch adds an option in the SchedulerUtil API to execute
schedu
Michael Kublin has submitted this change and it was merged.
Change subject: core: start 'prestarted VMs' immediately after update
..
core: start 'prestarted VMs' immediately after update
This patch solves a bug in which after i
1 - 100 of 320 matches
Mail list logo
