Dhandapani Gopal has posted comments on this change.
Change subject: engine: Import Cluster Error message needs clarity (#883542)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10430
To unsubscribe, visit ht
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Import Cluster Error message needs clarity (#883542)
..
Patch Set 1: (1 inline comment)
Incorporated review comment.
liron aravot has posted comments on this change.
Change subject: core: Adding support for completion service for ThreadPoolUtil
..
Patch Set 1: (1 inline comment)
File
backe
liron aravot has posted comments on this change.
Change subject: core: Adding support for completion service for ThreadPoolUtil
..
Patch Set 1: (1 inline comment)
File
backe
liron aravot has posted comments on this change.
Change subject: core: Adding support for completion service for ThreadPoolUtil
..
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
..
Moti Asayag has uploaded a new change for review.
Change subject: engine: Improve network queries bu reducing joins
..
engine: Improve network queries bu reducing joins
By extending the vm_interface_view with additional two
colu
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
webadmin: Disks sub-tab under Storage main-tab
Adding 'Disks' sub-tab under Storage main-tab
(applicable
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10322
To uns
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
Patch Set 3: (2 inline comments)
File
frontend/webadmin/mod
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: new VM - locked template disks warning
..
webadmin: new VM - locked template disks warning
New VM dialog,
when selecting a template with locked
Daniel Erez has posted comments on this change.
Change subject: webadmin: new VM - locked template disks warning
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10411
To u
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Allow remove of a VM without removing its disks
..
webadmin: Allow remove of a VM without removing its disks
When removing a VM, give the user the
Daniel Erez has posted comments on this change.
Change subject: webadmin: Allow remove of a VM without removing its disks
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10376
To unsubscrib
Tal Nisan has posted comments on this change.
Change subject: webadmin: Allow remove of a VM without removing its disks
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/10376
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding support for completion service for ThreadPoolUtil
..
Patch Set 1: (3 inline comments)
File
ba
Alon Bar-Lev has submitted this change and it was merged.
Change subject: tune: tuned: do not fail if no virtual host profile
..
tune: tuned: do not fail if no virtual host profile
RHEL-6.2 [at least] does not have this profile
Alon Bar-Lev has posted comments on this change.
Change subject: tune: tuned: do not fail if no virtual host profile
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10444
To unsubs
Alon Bar-Lev has uploaded a new change for review.
Change subject: tune: tuned: do not fail if no virtual host profile
..
tune: tuned: do not fail if no virtual host profile
RHEL-6.2 [at least] does not have this profile.
Chang
Moti Asayag has posted comments on this change.
Change subject: engine: Port mirroring setting requires a network
..
Patch Set 1: (1 inline comment)
File backend/manager/modu
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: pki: pep8
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10443
To unsubscribe, visit http://gerrit.ovirt.org
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: pki: pep8
..
vdsm: pki: pep8
Change-Id: I94b30b27b22b5c4c00c1ff7a3df9a7ff04302306
Signed-off-by: Alon Bar-Lev
---
M src/plugins/ovirt-host-deploy/
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: pki: pep8
..
vdsm: pki: pep8
Change-Id: I94b30b27b22b5c4c00c1ff7a3df9a7ff04302306
Signed-off-by: Alon Bar-Lev
---
M src/plugins/ovirt-host-deploy/vdsm/pki
Moti Asayag has posted comments on this change.
Change subject: restapi: Adding Network Linking
..
Patch Set 11: (1 inline comment)
Commit Message
Line 7: restapi: Adding Net
Moti Asayag has posted comments on this change.
Change subject: restapi: Adding Network Linking
..
Patch Set 11: (2 inline comments)
File
backend/manager/modules/restapi/jax
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/
Moti Asayag has posted comments on this change.
Change subject: engine: Port mirroring setting requires a network
..
Patch Set 1: (1 inline comment)
Please add unit-tests for VmNicValidator which is currently around 100%
cover
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper clenups, Use formatter.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10138
To unsubscribe, visit http://ge
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(12).
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10136
To unsubscribe, visi
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(13).
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10137
To unsubscribe, visi
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(11).
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10135
To unsubscribe, visi
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(9).
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10133
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(8).
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10132
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: webadmin: Allow remove of a VM without removing its disks
..
Patch Set 1: (8 inline comments)
File
backend/mana
Sharad Mishra has posted comments on this change.
Change subject: core: removed obsolete classes vm_template_image_map_id and
vm_template_image_map.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10404
To u
Moti Asayag has posted comments on this change.
Change subject: core: Adding support for completion service for ThreadPoolUtil
..
Patch Set 1: (3 inline comments)
File
backe
Daniel Erez has posted comments on this change.
Change subject: webadmin: Allow remove of a VM without removing its disks
..
Patch Set 5: (1 inline comment)
File
frontend/we
Sharad Mishra has posted comments on this change.
Change subject: core: renamed AdUser to LdapUser.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_map.java to EventMap.java
..
Patch Set 3:
Thanks for the comments, Tal. We need another patch to clean those up.
--
To view, visit http://ge
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed bookmarks.java to Bookmark.java
..
Patch Set 5:
I agree with your comments. There is more to cleaup :-)
But lets keep them separate.
--
To view, v
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_notification_methods.java to
EventNotificationMethod.java
..
Patch Set 2: (2 inline comments)
..
Alona Kaplan has posted comments on this change.
Change subject: restapi: Activate/Deactivate vnic should use edit
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10358
To unsubscribe, visit http://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: restapi: Adding Network Linking
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/10165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alona Kaplan has posted comments on this change.
Change subject: engine: Port mirroring setting requires a network
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10442
To unsubscribe, visit http://gerrit.ovi
Alona Kaplan has posted comments on this change.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10441
To unsubscribe, v
Alona Kaplan has uploaded a new change for review.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
restapi: Vnic's network update when portMirroring is set behaves wrong
If port mirrori
Alona Kaplan has uploaded a new change for review.
Change subject: engine: Port mirroring setting requires a network
..
engine: Port mirroring setting requires a network
A canDoAction should be thrown if on the vnic there is no
Liron Aravot has uploaded a new change for review.
Change subject: core: audit log on error during GetVms\Templates from export
domain
..
core: audit log on error during GetVms\Templates from export domain
This patch adds an au
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Adding support for completion service for ThreadPoolUtil
..
core: Adding support for completion service for ThreadPoolUtil
Completion service (java.util.
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 10:
You mean the whitespace changes, which probably happened when I saved the file?
Do
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 10:
What about the other comments?
(e.g. NoItemsLabel.java/WebAdmin.css)
--
To view, visi
Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/b
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage helper to fetch (related to BZ882825)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10141
To unsubscribe, visit http://gerr
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10140
To unsubscribe, visit http://gerrit.ovirt.org/sett
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper clenups, Use formatter.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10138
To unsubscribe, visit http://gerrit.ovirt.org/
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(13).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10137
To unsubscribe, visit http://gerrit
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(10).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10134
To unsubscribe, visit http://gerrit
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper cleanup, use one log declaration.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10139
To unsub
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(11).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10135
To unsubscribe, visit http://gerrit
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(12).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10136
To unsubscribe, visit http://gerrit
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(8).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10132
To unsubscribe, visit http://gerrit.
Moti Asayag has posted comments on this change.
Change subject: core:StorageHelper clenups, Use formatter.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10138
To unsub
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(6).
..
Patch Set 4: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(9).
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10133
To unsubscribe, visit http://gerrit.
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(7).
..
core:StorageHelper Cleanup, method name standard(7).
Change method name disconnectStorageFromDoma
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(7).
..
Patch Set 4: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(4).
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10129
To unsub
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(6).
..
core:StorageHelper Cleanup, method name standard(6).
Change method name connectStorageToDomainByV
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(4).
..
core:StorageHelper Cleanup, method name standard(4).
Change method name RunConnectionStorageToDom
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(2).
..
Patch Set 4: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(4).
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10128
To unsub
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(4).
..
core:StorageHelper Cleanup, method name standard(4).
Change method name RunConnectionStorageToDom
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(3).
..
core:StorageHelper Cleanup, method name standard(3).
Change method name runForSingleConnectionInH
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(3).
..
Patch Set 4: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper cleanup,Remove unused method.
..
core:StorageHelper cleanup,Remove unused method.
Remove unused method.
Change-Id: Ibeb4d32a82c78b4a2
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper cleanup,Remove unused method.
..
Patch Set 4: Verified; Looks good to me, approved
Acked by Allon
--
To view, visit http://gerrit.ovirt.org/10
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(2).
..
core:StorageHelper Cleanup, method name standard(2).
Change method name DisconnectStorageFromDoma
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:StorageHelper Cleanup, method name standard(1).
..
core:StorageHelper Cleanup, method name standard(1).
Change method name ConnectStorageToDomainByS
Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(1).
..
Patch Set 4: Verified; Looks good to me, approved
Acked by Tal and Allon
--
To view, visit http://gerrit.
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2981/
Build Number: 2981
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,747
-
Changes Since
Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage helper to fetch (related to BZ882825)
..
Patch Set 3: (1 inline comment)
File
backend/mana
Omer Frenkel has posted comments on this change.
Change subject: engine: Import Cluster Error message needs clarity (#883542)
..
Patch Set 1: (1 inline comment)
File
backend
Yair Zaslavsky has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix tests for Fast Quota Cache
..
core: Fix tests for Fast Quota Cache
Fix failing tests for Fast Quota Caching.
Change-Id: Ic08d357ab48ba3399b40
Gilad Chaplik has posted comments on this change.
Change subject: core: Fix tests for Fast Quota Cache
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10438
To unsubscribe, visit h
Liron Aravot has posted comments on this change.
Change subject: core : BLL changes for Multi-Tier fencing
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/b
ofri masad has posted comments on this change.
Change subject: core: Fix tests for Fast Quota Cache
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yair Zaslavsky has posted comments on this change.
Change subject: Adding HostSubTab to UI for Hardware information
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10115
To unsubs
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Adding HostSubTab to UI for Hardware information
..
Adding HostSubTab to UI for Hardware information
Hardware information tab is shown under host's sub
Yair Zaslavsky has posted comments on this change.
Change subject: Adding hardware information to vds object
..
Patch Set 24: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, v
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Adding hardware information to vds object
..
Adding hardware information to vds object
This patch adds hardware parameters to vdsStatic table and map t
Yair Zaslavsky has submitted this change and it was merged.
Change subject: Adding host hardware fields to vds_dynamic table
..
Adding host hardware fields to vds_dynamic table
adding 6 new vars to vds_dynamic
Feature wiki pag
Yair Zaslavsky has posted comments on this change.
Change subject: Adding host hardware fields to vds_dynamic table
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10114
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix tests for Fast Quota Cache
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10438
To unsubscribe, visit http://ger
ofri masad has uploaded a new change for review.
Change subject: core: Fix tests for Fast Quota Cache
..
core: Fix tests for Fast Quota Cache
Fix failing tests for Fast Quota Caching.
Change-Id: Ic08d357ab48ba3399b4071a39b81710
Tal Nisan has posted comments on this change.
Change subject: core: Rename ad_groups class to LdapGroup
..
Patch Set 5: Looks good to me, approved
There's a point in what you say, but I was just afraid that the rest will be
fo
Moti Asayag has posted comments on this change.
Change subject: core: Rename ad_groups class to LdapGroup
..
Patch Set 5:
Tal, why not to split it into a series of patches ?
Easier to review, verify and merge that way.
If you
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 10:
I amended the commit message between patch set 9 and 10. Also I had a
discussion w
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 10:
But patch-set10 seems identical to 9
(I've added some comments on 9..)
--
To view, vi
Michael Pasternak has posted comments on this change.
Change subject: cli: typo in help update manual #890368
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10437
To unsubscribe,
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: typo in help update manual #890368
..
cli: typo in help update manual #890368
https://bugzilla.redhat.com/show_bug.cgi?id=890368
Change-Id: I4
1 - 100 of 257 matches
Mail list logo
