[Engine-patches] Change in ovirt-engine[master]: engine, restapi: Move IdQueryParameters to a common package

2012-12-17 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine, restapi: Move IdQueryParameters to a common package .. Patch Set 2: Looks good to me, but someone else must approve Looks good from backend side -- To v

[Engine-patches] Change in ovirt-engine[master]: engine, restapi: Move IdQueryParameters to a common package

2012-12-17 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine, restapi: Move IdQueryParameters to a common package .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10163 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Add UserVmManager to VM PowerUsers on upgrade (#883365...

2012-12-17 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: core: Add UserVmManager to VM PowerUsers on upgrade (#883365) .. core: Add UserVmManager to VM PowerUsers on upgrade (#883365) https://bugzilla.redhat.com/883365

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 2717 - Fixed!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2717/ Build Number: 2717 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,660 - Change

[Engine-patches] Change in ovirt-engine[master]: core: OvfDataUpdater - removal of update/remove OVF vdsm cal...

2012-12-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls .. Patch Set 23: Allon, you're correct - will be moved to the earlier patch in the next push -- To

[Engine-patches] [oVirt Jenkins] ovirt_engine_create_update_db - Build # 3399 - Fixed!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/ Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/3399/ Build Number: 3399 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,660 - Ch

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 3660 - Fixed!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine/ Build: http://jenkins.ovirt.org/job/ovirt_engine/3660/ Build Number: 3660 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: - Changes

[Engine-patches] Change in ovirt-engine[master]: core: Added "scan" to disks resource to import clones

2012-12-17 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: core: Added "scan" to disks resource to import clones .. Patch Set 3: Do not submit api: both design and implementation are incorrect, please setup a meeting

[Engine-patches] Change in ovirt-engine[master]: fix upgrade number due to duplicate

2012-12-17 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: fix upgrade number due to duplicate .. fix upgrade number due to duplicate Change-Id: I39f1831f919fb80fcc4e269aff4ea78715a6262e Signed-off-by: Oved Our

[Engine-patches] Change in ovirt-engine[master]: fix upgrade number due to duplicate

2012-12-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: fix upgrade number due to duplicate .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10182 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: fix upgrade number due to duplicate

2012-12-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: fix upgrade number due to duplicate .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/10182 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: fix upgrade number due to duplicate

2012-12-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: fix upgrade number due to duplicate .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10182 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: fix upgrade number due to duplicate

2012-12-17 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: fix upgrade number due to duplicate .. fix upgrade number due to duplicate Change-Id: I39f1831f919fb80fcc4e269aff4ea78715a6262e Signed-off-by: Oved Ourfali ---

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 2386 - Still Failing!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2386/ Build Number: 2386 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 3659 - Still Failing!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine/ Build: http://jenkins.ovirt.org/job/ovirt_engine/3659/ Build Number: 3659 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5

2012-12-17 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: core: Upgrade PowerMock to 1.5 .. core: Upgrade PowerMock to 1.5 Upgraded PowerMock to 1.5 in order to support a future move to Java 7. This change

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5

2012-12-17 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: core: Upgrade PowerMock to 1.5 .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10179 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5

2012-12-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Upgrade PowerMock to 1.5 .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/10179 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 2939 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/2939/ Build Number: 2939 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,657 - Changes Since

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 2808 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/2808/ Build Number: 2808 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,657 - Changes Since La

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 2914 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2914/ Build Number: 2914 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,657 - Changes Sinc

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 2385 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/2385/ Build Number: 2385 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt_engine_create_update_db - Build # 3398 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/ Build: http://jenkins.ovirt.org/job/ovirt_engine_create_update_db/3398/ Build Number: 3398 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,657 -

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3015 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3015/ Build Number: 3015 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,657 - Changes Since

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 2716 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/2716/ Build Number: 2716 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,657 - Chan

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 3658 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine/ Build: http://jenkins.ovirt.org/job/ovirt_engine/3658/ Build Number: 3658 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: - Chang

[Engine-patches] Change in ovirt-engine[master]: core: ImportVm test cleanup: VM name generation

2012-12-17 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: ImportVm test cleanup: VM name generation .. Patch Set 11: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9619 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core+ui: add HA events to notification service

2012-12-17 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: core+ui: add HA events to notification service .. core+ui: add HA events to notification service Previous patch introduced two new events to the HA VM. T

[Engine-patches] Change in ovirt-engine[master]: core+ui: add HA events to notification service

2012-12-17 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core+ui: add HA events to notification service .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10162 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: core+ui: add HA events to notification service

2012-12-17 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core+ui: add HA events to notification service .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10162 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine: Changed "Host" to "Server"

2012-12-17 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: Changed "Host" to "Server" .. engine: Changed "Host" to "Server" Changed existing "Host" to "Server" in Add Gluster Server related sources, since

[Engine-patches] Change in ovirt-engine[master]: engine: Changed "Host" to "Server"

2012-12-17 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Changed "Host" to "Server" .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9821 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: change gracefully shutdown message (#854218)

2012-12-17 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: change gracefully shutdown message (#854218) .. Patch Set 2: yes it was approved by Miki as well -- To view, visit http://gerrit.ovirt.org/9706 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5

2012-12-17 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: core: Upgrade PowerMock to 1.5 .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10179 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: change gracefully shutdown message (#854218)

2012-12-17 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: change gracefully shutdown message (#854218) .. Patch Set 2: in the BZ miki phrased it differently, is that synced? -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding force option to remove host

2012-12-17 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Adding force option to remove host .. webadmin: Adding force option to remove host 'Remove Forcefully' checkbox will be shown while removing a host from

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5

2012-12-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Upgrade PowerMock to 1.5 .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/10179 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5

2012-12-17 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Upgrade PowerMock to 1.5 .. core: Upgrade PowerMock to 1.5 Upgraded PowerMock to 1.5 in order to support a future move to Java 7. Change-Id: Ia3799efcc8

[Engine-patches] Change in ovirt-engine[master]: WIP webadmin: Changes for CPU Thread Handling (5/5)

2012-12-17 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: WIP webadmin: Changes for CPU Thread Handling (5/5) .. Patch Set 2: This commit adds a popup warning when the count-threads-as-cores option is turned off (and wa

[Engine-patches] Change in ovirt-engine[master]: engine: Changed "Host" to "Server"

2012-12-17 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Changed "Host" to "Server" .. Patch Set 4: Verified Rebased -- To view, visit http://gerrit.ovirt.org/9821 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3014 - Fixed!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3014/ Build Number: 3014 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,656 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: Adding host bios fields to vdsStatic table

2012-12-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Adding host bios fields to vdsStatic table .. Patch Set 1: (1 inline comment) File backend/manager/dbscripts/cr

[Engine-patches] Change in ovirt-engine[master]: core: ImportVm test cleanup: VM name generation

2012-12-17 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: ImportVm test cleanup: VM name generation .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9619 To u

[Engine-patches] Change in ovirt-engine[master]: webadmin: correlation ID should not be localized

2012-12-17 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin: correlation ID should not be localized .. webadmin: correlation ID should not be localized When using non-English localization, 'Configure Local

[Engine-patches] Change in ovirt-engine[master]: webadmin: correlation ID should not be localized

2012-12-17 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: correlation ID should not be localized .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10176 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: correlation ID should not be localized

2012-12-17 Thread abaron
Ayal Baron has posted comments on this change. Change subject: webadmin: correlation ID should not be localized .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10176 To

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added the ability to define a 'no items' message.

2012-12-17 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Added the ability to define a 'no items' message. .. Patch Set 9: Looks good to me, but someone else must approve (8 inline comments) Looks good. Some i

[Engine-patches] Change in ovirt-engine[master]: core: Rename ad_groups class to LdapGroup

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Rename ad_groups class to LdapGroup .. Patch Set 5: Verified rebased -- To view, visit http://gerrit.ovirt.org/9835 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: webadmin: correlation ID should not be localized

2012-12-17 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: correlation ID should not be localized .. webadmin: correlation ID should not be localized When using non-English localization, 'Configure Local Storage

[Engine-patches] Change in ovirt-engine[master]: webadmin: Added the ability to define a 'no items' message.

2012-12-17 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Added the ability to define a 'no items' message. .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/9830 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-host-deploy[master]: doc: minor cleanups

2012-12-17 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: minor cleanups .. doc: minor cleanups Change-Id: Ic623c9d644287c1ca1cbe8260f78b35f80e04f87 Signed-off-by: Alon Bar-Lev --- M ChangeLog M README M R

[Engine-patches] Change in ovirt-host-deploy[master]: doc: minor cleanups

2012-12-17 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: doc: minor cleanups .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10175 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-host-deploy[master]: doc: minor cleanups

2012-12-17 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: doc: minor cleanups .. doc: minor cleanups Change-Id: Ic623c9d644287c1ca1cbe8260f78b35f80e04f87 Signed-off-by: Alon Bar-Lev --- M ChangeLog M README M README.en

[Engine-patches] Change in ovirt-engine[master]: API: [RFE] Add PM Proxy Preferences

2012-12-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: API: [RFE] Add PM Proxy Preferences .. Patch Set 4: (2 inline comments) File backend/manager/modules/restapi/i

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3013 - Failure!

2012-12-17 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3013/ Build Number: 3013 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,655 - Changes Since

[Engine-patches] Change in ovirt-engine[master]: core+ui: add HA events to notification service

2012-12-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core+ui: add HA events to notification service .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10162 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: WIP core: Add DB columns for CPU Overcommit (1/5)

2012-12-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: WIP core: Add DB columns for CPU Overcommit (1/5) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10166 To

[Engine-patches] Change in ovirt-engine[master]: core: Add scan domain query (revised)

2012-12-17 Thread ricky . hopper
Ricky Hopper has abandoned this change. Change subject: core: Add scan domain query (revised) .. Patch Set 2: Abandoned Superseded by change -- To view, visit http://gerrit.ovirt.org/8219 To

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(12).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(12). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(11).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(11). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(10).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(10). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(9).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(9). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(8).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(8). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: webadmin: [es_ES] heading "Virtual size" is truncated in Spa...

2012-12-17 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) .. webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379)

[Engine-patches] Change in ovirt-engine[master]: webadmin: [es_ES] heading "Virtual size" is truncated in Spa...

2012-12-17 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper clenups, Use formatter.

2012-12-17 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core:StorageHelper clenups, Use formatter. .. Patch Set 3: (1 inline comment) File backend/manager/modules/bl

[Engine-patches] Change in ovirt-engine[master]: core: introducing OvfAutoUpdate

2012-12-17 Thread liron . aravot
liron aravot has posted comments on this change. Change subject: core: introducing OvfAutoUpdate .. Patch Set 18: (6 inline comments) File backend/manager/dbscripts/vms_sp.sq

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(7).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(7). .. Patch Set 3: should change commit message header to differentiate this patch from http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(7).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(7). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(6).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(6). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(4).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(4). .. Patch Set 3: even though i like smaller separate patches. In this case I prefer if you merged the two "(

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(4).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(4). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(3).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(3). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(2).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(2). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper Cleanup, method name standard(1).

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper Cleanup, method name standard(1). .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper clenups, Use formatter.

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper clenups, Use formatter. .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10138 To uns

[Engine-patches] Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log

2012-12-17 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: engine-manage-domains should not write passwd to log .. tools: engine-manage-domains should not write passwd to log Running "engine-manage-domai

[Engine-patches] Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log

2012-12-17 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: engine-manage-domains should not write passwd to log .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10157

[Engine-patches] Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log

2012-12-17 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: engine-manage-domains should not write passwd to log .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/10157 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: userportal: Quota Monitors - userportal

2012-12-17 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: userportal: Quota Monitors - userportal .. Patch Set 3: VMs are already being fetched in the user portal tiday, so no change here. As for consumption data, this

[Engine-patches] Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log

2012-12-17 Thread rnori
Ravi Nori has posted comments on this change. Change subject: tools: engine-manage-domains should not write passwd to log .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/10157 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log

2012-12-17 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: engine-manage-domains should not write passwd to log .. Patch Set 3: Looks good to me, approved Cancelling -1 TWS red mark does not appear at code now.

[Engine-patches] Change in ovirt-engine[master]: userportal: Fix NPE in VM list models

2012-12-17 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: userportal: Fix NPE in VM list models .. userportal: Fix NPE in VM list models Change-Id: Ib9968567971141bf3e0b95c2220ec403555fafbd Signed-off-by: Vojtech Szocs

[Engine-patches] Change in ovirt-engine[master]: core: add clear message for live snapshot fail

2012-12-17 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: add clear message for live snapshot fail .. core: add clear message for live snapshot fail Add a new, clear message when live snaphot fails for a host whic

[Engine-patches] Change in ovirt-engine[master]: core:StorageHelper cleanup, code clean

2012-12-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:StorageHelper cleanup, code clean .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10140 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: userportal: Quota Monitors - userportal

2012-12-17 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal: Quota Monitors - userportal .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) minor comment about the quota functionalit

[Engine-patches] Change in ovirt-engine[master]: core: introducing OvfAutoUpdate

2012-12-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: introducing OvfAutoUpdate .. Patch Set 20: (29 inline comments) File backend/manager/dbscripts/storages

[Engine-patches] Change in ovirt-engine[master]: core: Quota Monitors - backend

2012-12-17 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: Quota Monitors - backend .. Patch Set 3: it seems that there is no paging in the userPortal, so it's not you problem for now. stays -1 :-) -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: [WIP] core, webadmin, restapi: Add CPU overcommitment

2012-12-17 Thread gpadgett
Greg Padgett has abandoned this change. Change subject: [WIP] core, webadmin, restapi: Add CPU overcommitment .. Patch Set 1: Abandoned Split into separate patches: http://gerrit.ovirt.org/10166 http://gerrit.ovirt.org/10167 h

[Engine-patches] Change in ovirt-engine[master]: WIP restapi: Add fields for CPU Overcommit (4/5)

2012-12-17 Thread gpadgett
Greg Padgett has uploaded a new change for review. Change subject: WIP restapi: Add fields for CPU Overcommit (4/5) .. WIP restapi: Add fields for CPU Overcommit (4/5) This patch series adds support for CPU Overcommitment based

[Engine-patches] Change in ovirt-engine[master]: WIP webadmin: Changes for CPU Overcommit (5/5)

2012-12-17 Thread gpadgett
Greg Padgett has uploaded a new change for review. Change subject: WIP webadmin: Changes for CPU Overcommit (5/5) .. WIP webadmin: Changes for CPU Overcommit (5/5) This patch series adds support for CPU Overcommitment based on c

[Engine-patches] Change in ovirt-engine[master]: WIP core: Add DB columns for CPU Overcommit (1/5)

2012-12-17 Thread gpadgett
Greg Padgett has uploaded a new change for review. Change subject: WIP core: Add DB columns for CPU Overcommit (1/5) .. WIP core: Add DB columns for CPU Overcommit (1/5) This patch series adds support for CPU Overcommitment base

[Engine-patches] Change in ovirt-engine[master]: WIP core: VdsSelector changes for CPU Overcommit (3/5)

2012-12-17 Thread gpadgett
Greg Padgett has uploaded a new change for review. Change subject: WIP core: VdsSelector changes for CPU Overcommit (3/5) .. WIP core: VdsSelector changes for CPU Overcommit (3/5) This patch series adds support for CPU Overcommi

[Engine-patches] Change in ovirt-engine[master]: WIP core: Logic for CPU Overcommit fields (2/5)

2012-12-17 Thread gpadgett
Greg Padgett has uploaded a new change for review. Change subject: WIP core: Logic for CPU Overcommit fields (2/5) .. WIP core: Logic for CPU Overcommit fields (2/5) This patch series adds support for CPU Overcommitment based on

[Engine-patches] Change in ovirt-engine[master]: core: add NetworkLinking to UpdateVmTemplateInterfaceCommand

2012-12-17 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: core: add NetworkLinking to UpdateVmTemplateInterfaceCommand .. core: add NetworkLinking to UpdateVmTemplateInterfaceCommand - canDoAction- If "UnlinkingSupporte

[Engine-patches] Change in ovirt-engine[master]: restapi: Adding Network Linking

2012-12-17 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: restapi: Adding Network Linking .. restapi: Adding Network Linking - Adding new properties under VM NIC: * plugged * link_state ("up"/ "down") - Deprecating

[Engine-patches] Change in ovirt-engine[master]: webadmin: Quota Monitors - webadmin

2012-12-17 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Quota Monitors - webadmin .. Patch Set 3: (1 inline comment) minor comment, please upload a new patch

[Engine-patches] Change in ovirt-engine[master]: core: Quota Monitors - backend

2012-12-17 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: Quota Monitors - backend .. Patch Set 3: I would prefer that you didn't submit this (12 inline comments) I will tell you one thing, the query should conta

[Engine-patches] Change in ovirt-engine[master]: core: expand getVdsGroup to return VDSGroup of a VmTemplate.

2012-12-17 Thread alkaplan
Alona Kaplan has abandoned this change. Change subject: core: expand getVdsGroup to return VDSGroup of a VmTemplate. .. Patch Set 1: Abandoned squashed into http://gerrit.ovirt.org/#/c/9565/ -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: [WIP] engine: User queries improvements

2012-12-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] engine: User queries improvements .. Patch Set 6: (1 inline comment) File backend/manager/dbscripts/creat

  1   2   3   4   >