Daniel Erez has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Liron Aravot has posted comments on this change.
Change subject: core : WIP : Preview snapshot - NPE after engine crash
..
Patch Set 4: (1 inline comment)
File
backend/manag
Michael Kublin has posted comments on this change.
Change subject: core : WIP : Preview snapshot - NPE after engine crash
..
Patch Set 4: (1 inline comment)
File
backend/man
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fix attach/detach message
..
core: Fix attach/detach message
Fix VAR__ACTION__ATTACH_ACTION_TO: action substitution was faulty, and
now is "attac
Michael Kublin has posted comments on this change.
Change subject: core: Fix attach/detach message
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9072
To unsubscribe, visit http:/
Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
..
Patch Set 4: (2 inline comments)
Some minor comments inside.
Vered Volansky has posted comments on this change.
Change subject: core: Fix attach/detach message
..
Patch Set 3: (1 inline comment)
File
frontend/webadmin/modules/userport
Vered Volansky has posted comments on this change.
Change subject: core: Fix attach/detach message
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vered Volansky has posted comments on this change.
Change subject: core: Fix attach/detach message
..
Patch Set 4:
The only difference from previous patch is in
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/
Daniel Erez has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit http://gerrit.ovirt.o
Vered Volansky has posted comments on this change.
Change subject: core : WIP : Preview snapshot - NPE after engine crash
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Daniel Erez has posted comments on this change.
Change subject: webadmin & engine: Add validation for snapshot description
length
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 1:
Ravi, have you checked the code does not have any references to these? (i.e -
the logic
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 1: Looks good to me, but someone else must approve
Looked at all changes - looks good.
--
To view, visit http://gerr
Einav Cohen has posted comments on this change.
Change subject: webadmin: Messages text fixes
..
Patch Set 1:
Yair - please review core changes: AuthenticationResult.java
Alona/Derez - please review the rest (text changes).
Tha
Einav Cohen has uploaded a new change for review.
Change subject: webadmin: Messages text fixes
..
webadmin: Messages text fixes
In this patch, some fixes were made to some of the messages:
- Network engine is mandatory, it can
Sharad Mishra has posted comments on this change.
Change subject: core: import cleanup in AlertDirector.java
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9093
To unsubscribe, visit http://gerrit.ovirt.org/
Sharad Mishra has posted comments on this change.
Change subject: core: fix imports in MoveImageGroupVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9094
To unsubscribe, visit http://gerrit.ovirt.o
Alon Bar-Lev has posted comments on this change.
Change subject: core: fix imports in MoveImageGroupVDSCommand
..
Patch Set 1:
Why you are at this, why not also fix the asynctasks? :)
--
To view, visit http://gerrit.ovirt.org/
Sharad Mishra has uploaded a new change for review.
Change subject: core: fix imports in MoveImageGroupVDSCommand
..
core: fix imports in MoveImageGroupVDSCommand
Change-Id: Ia313b6343d1e554476662dfc604d59d672088401
Signed-off-b
Sharad Mishra has uploaded a new change for review.
Change subject: core: import cleanup in AlertDirector.java
..
core: import cleanup in AlertDirector.java
Use fully qualified imports.
Change-Id: If0c2a9f699b4b5e9227aeb9b6ef10
Moti Asayag has posted comments on this change.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
Patch Set 2: (1 inline comment)
File
backend/manager/mo
Eli Mesika has submitted this change and it was merged.
Change subject: core: Don't use PostgreSQL UUID extension
..
core: Don't use PostgreSQL UUID extension
Replace the uuid_generate_v1 function from the uuid-ossp extension w
Eli Mesika has posted comments on this change.
Change subject: core: Don't use PostgreSQL UUID extension
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8955
To unsubscribe, visit http://gerrit.ovirt.org/sett
Eli Mesika has posted comments on this change.
Change subject: core: Don't use PostgreSQL UUID extension
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8955
To unsubscribe, visit http://ger
Sharad Mishra has posted comments on this change.
Change subject: core: clarify conditional expression in checkImageValidity
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
..
Patch Set 2: (1 inline comment)
..
Sharad Mishra has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
Patch Set 1:
Are we removing the instances of v2.2? Then why move even 3.1 versions to
deprecated list
Liron Aravot has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: (1 inline comment)
File
backend/
Ravi Nori has uploaded a new change for review.
Change subject: tools: engine-config need to remove all ver 2.2 values
..
tools: engine-config need to remove all ver 2.2 values
Remove deprecated config keys from engine-config
E
Ravi Nori has uploaded a new change for review.
Change subject: restapi: VM-runtime-only information presented after VM goes
down (#869682)
..
restapi: VM-runtime-only information presented after VM goes down (#869682)
VM-runti
Michael Kublin has posted comments on this change.
Change subject: core: WIP: verify iscsi lun connection when adding lun disk
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.
Michael Kublin has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/
Greg Padgett has uploaded a new change for review.
Change subject: core: clarify conditional expression in checkImageValidity
..
core: clarify conditional expression in checkImageValidity
Add indentation and parenthesis to impro
Juan Hernandez has posted comments on this change.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
..
Patch Set 1: (3 inline comments)
.
Sharad Mishra has posted comments on this change.
Change subject: core: Fix attach/detach message
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
One minor comment
..
Eli Mesika has uploaded a new change for review.
Change subject: core:PCI addresses are deleted when VM...(#873581)
..
core:PCI addresses are deleted when VM...(#873581)
PCI addresses are deleted when VM Template is imported
Wh
Sharad Mishra has posted comments on this change.
Change subject: engine: Re-run vm on other host if vm creation fail
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/908
Ohad Basan has uploaded a new change for review.
Change subject: Core: logging an error message when bootstrapPackage directory
is missing
..
Core: logging an error message when bootstrapPackage directory is missing
This patch
Alex Lourie has posted comments on this change.
Change subject: core: Generate UUIDs from engine
..
Patch Set 3:
Not really my area.
Setup code looks good.
--
To view, visit http://gerrit.ovirt.org/8990
To unsubscribe, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: core: WIP - libosinfo - introduce libosinfo service
..
Patch Set 4: I would prefer that you didn't submit this
(11 inline comments)
...
Arik Hadas has uploaded a new change for review.
Change subject: engine: Re-run vm on other host if vm creation fail
..
engine: Re-run vm on other host if vm creation fail
When an error with error code different than 'Done' or '
Daniel Erez has submitted this change and it was merged.
Change subject: core: SEAT - call startPollingAsyncTasks on revert
..
core: SEAT - call startPollingAsyncTasks on revert
Calling startPollingAsyncTasks on internalEndWith
Daniel Erez has posted comments on this change.
Change subject: core: SEAT - call startPollingAsyncTasks on revert
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9040
To
Daniel Erez has posted comments on this change.
Change subject: core: SEAT - call startPollingAsyncTasks on revert
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: localize number of VMs for Hosts Load
..
webadmin: localize number of VMs for Hosts Load
In the Hosts grid (both in Hosts main tab and Hosts sub
Einav Cohen has posted comments on this change.
Change subject: webadmin: localize number of VMs for Hosts Load
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9082
To unsubscribe,
Einav Cohen has posted comments on this change.
Change subject: webadmin: localize number of VMs for Hosts Load
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9082
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: core: prevent clone VM while disk is locked
..
core: prevent clone VM while disk is locked
* Preventing clone VM from snapshot
when one of the disks are
Daniel Erez has posted comments on this change.
Change subject: core: prevent clone VM while disk is locked
..
Patch Set 6: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9031
To unsubsc
Roy Golan has abandoned this change.
Change subject: core: Libosinfo service Xml loading impl
..
Patch Set 4: Abandoned
merged and rebased the whole topic
--
To view, visit http://gerrit.ovirt.org/8473
To unsubscribe, visit ht
Roy Golan has abandoned this change.
Change subject: core: WIP libosifno remove umodifiable map usage and make the
getter null safe
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9058
To unsubscribe, visit
Roy Golan has abandoned this change.
Change subject: core: WIP make libosinfo serializable
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-
Itamar Heim has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
.
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo make the libosinfo exposed for debug
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9060
To unsubscribe, visit http://gerrit.ovirt.or
Roy Golan has abandoned this change.
Change subject: core: WIP - libosinfo - fix getos() getter
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo - generate independent classes instead of
inner
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9045
To unsubscribe, visit http://ger
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo - introdce OS info generated sources to GWT
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9046
To unsubscribe, visit http://gerrit.o
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo - add OsHelper class
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo add GWT changes for libosinfo-types
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9050
To unsubscribe, visit http://gerrit.ovirt.org
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo add/refactor DataProvider
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has abandoned this change.
Change subject: core: WIP - libosinfo revert to VmOsType instead of string
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9052
To unsubscribe, visit http://gerrit.ovirt.
Roy Golan has abandoned this change.
Change subject: core: WIP - libosinfo refactor DataProvider to work with
VmOsType
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9053
To unsubscribe, visit http://gerri
Roy Golan has abandoned this change.
Change subject: core: WIP - libosinfo refactor VmHandler to use cpu arch
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9054
To unsubscribe, visit http://gerrit.ovirt.or
Roy Golan has abandoned this change.
Change subject: core: WIP - libosinfo - another addition to libos service - use
safe getters
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9064
To unsubscribe, visit h
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo fix euals ignore case on resource chech
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9066
To unsubscribe, visit http://gerrit.ovirt
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo - some changes for CpuArch
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has abandoned this change.
Change subject: core: WIP libosinfo add CpuArch UI field
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Roy Golan has abandoned this change.
Change subject: core: WIP - libosinfo - remove old dbscript
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.ovirt.org/9069
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Continue reduce usage of getCurrentVdsId()
..
engine: Continue reduce usage of getCurrentVdsId()
Reduced usage of getCurrentVdsId() and removed
Michael Kublin has posted comments on this change.
Change subject: engine: Continue reduce usage of getCurrentVdsId()
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9026
To unsubs
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Continue preparation for removing a global lock at SPM
calls
..
engine: Continue preparation for removing a global lock at SPM calls
Removed u
Michael Kublin has posted comments on this change.
Change subject: engine: Continue preparation for removing a global lock at SPM
calls
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Preparation for removing a global lock on spm calls at
engine side
..
engine: Preparation for removing a global lock on spm calls at engine sid
Michael Kublin has posted comments on this change.
Change subject: engine: Preparation for removing a global lock on spm calls at
engine side
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Michael Kublin has posted comments on this change.
Change subject: engine: Continue reduce usage of getCurrentVdsId()
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/9026
Michael Kublin has posted comments on this change.
Change subject: engine: Continue reduce usage of getCurrentVdsId()
..
Patch Set 2: (2 inline comments)
File
backend/manage
Michael Kublin has posted comments on this change.
Change subject: engine: Continue preparation for removing a global lock at SPM
calls
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Michael Kublin has posted comments on this change.
Change subject: engine: Preparation for removing a global lock on spm calls at
engine side
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Maor Lipchuk has posted comments on this change.
Change subject: core: Add validation for locked template
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bl
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Continue preparation for removing a global lock at SPM
calls
..
Patch Set 2: Looks good to me, approved
Ayal,
The host name is used for logging.
I don'
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools : engine-manage-domains location option no longer valid
..
tools : engine-manage-domains location option no longer valid
In command line paramete
Yair Zaslavsky has posted comments on this change.
Change subject: tools : engine-manage-domains location option no longer valid
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8963
To unsubscribe, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: tools : engine-manage-domains location option no longer valid
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8963
To unsub
Sharad Mishra has posted comments on this change.
Change subject: engine: Continue reduce usage of getCurrentVdsId()
..
Patch Set 2: (2 inline comments)
File
backend/manager
Sharad Mishra has posted comments on this change.
Change subject: core: compensate on wrong object lead to NPE
..
Patch Set 3: (2 inline comments)
Commit Message
Line 6:
Lin
Alex Lourie has posted comments on this change.
Change subject: core: Don't use PostgreSQL UUID extension
..
Patch Set 4: Looks good to me, but someone else must approve
ack on the code.
Looks really good.
--
To view, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: prevent clone VM while disk is locked
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Execute wasn't called after creating
SaveNetworkConfigAction
..
webadmin: Execute wasn't called after creating SaveNetworkConfigAction
- It is
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Execute wasn't called after creating
SaveNetworkConfigAction
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://ger
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Removed unnecessary 'continue' statements
..
engine: Removed unnecessary 'continue' statements
Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff
Sig
Ayal Baron has posted comments on this change.
Change subject: engine: Continue reduace usage of getCurrentVdsId()
..
Patch Set 1: (1 inline comment)
Need to explain why the validation is not required.
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Preporation for removing a global lock on spm calls at
engine side
..
Patch Set 1:
Looks good to me (please follow Ayal's comments regarding the patch)
Ayal Baron has posted comments on this change.
Change subject: engine: Continue preporation for removing a global lock at SPM
calls
..
Patch Set 1:
I'd like to understand why the name comparison was in there to begin with.
--
Daniel Erez has posted comments on this change.
Change subject: webadmin: Execute wasn't called after creating
SaveNetworkConfigAction
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9081
T
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Preporation for removing a global lock on spm calls at
engine side
..
Patch Set 1: (2 inline comments)
Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Gluster Volume Profile Info Query
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8646
To
Shahar Havivi has posted comments on this change.
Change subject: webadmin: localize number of VMs for Clusters and Hosts
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9082
To unsubscribe, visit http://gerr
Shahar Havivi has uploaded a new change for review.
Change subject: webadmin: localize number of VMs for Clusters and Hosts
..
webadmin: localize number of VMs for Clusters and Hosts
Change-Id: I0c9e1a6115bf7a3ab7a8a018015335c6d
Ayal Baron has posted comments on this change.
Change subject: engine: Preporation for removing a global lock on spm calls at
engine side
..
Patch Set 1: Looks good to me, but someone else must approve
Commit message could be
1 - 100 of 214 matches
Mail list logo
