[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2012-11-02 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tools: Better API error handling .. Patch Set 2: Looks good to me, but someone else must approve I don't mean to log the password. I means a log can hint that pas

[Engine-patches] Change in ovirt-engine[master]: packaging: misc cleanups related to pgpass

2012-11-02 Thread Alon Bar-Lev
Alon Bar-Lev has abandoned this change. Change subject: packaging: misc cleanups related to pgpass .. Patch Set 2: Abandoned All that was left is style changes. Done this to help while alex was absent. Seems that nobody cares

[Engine-patches] Change in ovirt-engine[master]: packaging: Use configuration to generate paths

2012-11-02 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Use configuration to generate paths .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8297 To u

[Engine-patches] Change in ovirt-engine[master]: engine: Support loading a VM snapshot when conf is not avail...

2012-11-02 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: engine: Support loading a VM snapshot when conf is not available. .. engine: Support loading a VM snapshot when conf is not available. Enhance GetVmConfi

[Engine-patches] Change in ovirt-engine[master]: engine: Support loading a VM snapshot when conf is not avail...

2012-11-02 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: Support loading a VM snapshot when conf is not available. .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8

[Engine-patches] Change in ovirt-engine[master]: engine: cannot unpause VM started in paused mode

2012-11-02 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: engine: cannot unpause VM started in paused mode .. engine: cannot unpause VM started in paused mode Have 2 clusters, in each have one host. In one of this clus

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix regression for statelessVM. .. core: Fix regression for statelessVM. Stateless VM cpuld not run since the parameter command was set in the pare

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix regression for statelessVM. .. Patch Set 2: Verified; Looks good to me, approved Acked by derez -- To view, visit http://gerrit.ovirt.org/8992 To unsub

[Engine-patches] Change in ovirt-engine[master]: engine: Support loading a VM snapshot when conf is not avail...

2012-11-02 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Support loading a VM snapshot when conf is not available. .. Patch Set 1: Verified; Looks good to me, approved (1 inline comment) small formatter style,

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: Fix regression for statelessVM. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8992 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: Fix regression for statelessVM. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8992 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fix regression for statelessVM. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8992 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: engine: Support loading a VM snapshot when conf is not avail...

2012-11-02 Thread asaf
Asaf Shakarchi has posted comments on this change. Change subject: engine: Support loading a VM snapshot when conf is not available. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8981 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: core: Fix regression for statelessVM. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8992 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: packaging: Bump package version to 3.2.0

2012-11-02 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: packaging: Bump package version to 3.2.0 .. packaging: Bump package version to 3.2.0 This pach changes the version number in the POMs and in the spec of the RP

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated VDC utilities to accept alternative binar...

2012-11-02 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated VDC utilities to accept alternative binary .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: engine: Get Volume Advanced Details Query

2012-11-02 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Volume Advanced Details Query .. Patch Set 24: (1 inline comment) Incorporated review comments. .

[Engine-patches] Change in ovirt-engine[master]: core: Generate UUIDs from engine

2012-11-02 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Generate UUIDs from engine .. Patch Set 2: Verified Added a "isNullOrEmpty" method to the NGuid and use it instead of "id == null". This is convient, saf

[Engine-patches] Change in ovirt-engine[master]: core: Fix regression for statelessVM.

2012-11-02 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Fix regression for statelessVM. .. core: Fix regression for statelessVM. Stateless VM cpuld not run since the parameter command was set in the parent param

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Volume Profile Info Query

2012-11-02 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Get Gluster Volume Profile Info Query .. Patch Set 1: (2 inline comments) Couple of minor comments in-line. ...

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2012-11-02 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: tools: Better API error handling .. Patch Set 2: (2 inline comments) File src/engine-iso-uploader.py Line

[Engine-patches] Change in ovirt-engine[master]: packaging: Added version dependency for dbscripts package

2012-11-02 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Added version dependency for dbscripts package .. packaging: Added version dependency for dbscripts package Change-Id: Ie71b7a6cc43534fc577e

[Engine-patches] Change in ovirt-engine[master]: packaging: Added version dependency for dbscripts package

2012-11-02 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Added version dependency for dbscripts package .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8991 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: packaging: Added version dependency for dbscripts package

2012-11-02 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: Added version dependency for dbscripts package .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8991 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: packaging: Added version dependency for dbscripts package

2012-11-02 Thread alourie
Alex Lourie has uploaded a new change for review. Change subject: packaging: Added version dependency for dbscripts package .. packaging: Added version dependency for dbscripts package Change-Id: Ie71b7a6cc43534fc577e498ab1dd2e4

[Engine-patches] Change in ovirt-engine[master]: core: Generate UUIDs from engine

2012-11-02 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Generate UUIDs from engine .. core: Generate UUIDs from engine We used to generate UUIDs used as primary keys of entities in the database. This patch cha

[Engine-patches] Change in ovirt-log-collector[master]: tools: Fix locale issue (BZ858918)

2012-11-02 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: tools: Fix locale issue (BZ858918) .. Patch Set 2: Re: ...MD5 is relevant to the original bug md5sum --check on i18n systems doesn't report 'OK' -- To view,

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2012-11-02 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: tools: Better API error handling .. Patch Set 2: Re: Logging passwords... Logging passwords is a bad idea. IIRC there are certain govt. security standards t

[Engine-patches] Change in ovirt-engine[master]: core: Don't use PostgreSQL UUID extension

2012-11-02 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Don't use PostgreSQL UUID extension .. Patch Set 3: Rebased and replaced the uuid_generate_v1 function with the one suggested by Eli (with some minor for

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2012-11-02 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: tools: Better API error handling .. Patch Set 2: Verified; I would prefer that you didn't submit this (4 inline comments) if the password is wrong, can also log i