Allon Mureinik has posted comments on this change.
Change subject: core: removed unused fqn from VdsSelector
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Allon Mureinik has posted comments on this change.
Change subject: core: log should be final in VdsSelector
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8403
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: camel-case methods in VdsSelector
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8402
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: break down spaghetti-code in VdsSelector
..
Patch Set 1:
not entirely convinced this is more readable
I'll have to think about it for a while
--
To view
Allon Mureinik has posted comments on this change.
Change subject: core: VdsSelector cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused code from VdsSelector
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Eli Mesika has posted comments on this change.
Change subject: core: search for disks on specific domains
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8385
To unsubscribe, visit http://ge
Yair Zaslavsky has posted comments on this change.
Change subject: core: VmPayload serialVersionUID should be final
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8405
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Reduce host connection timeout
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8410
To unsubscri
Juan Hernandez has uploaded a new change for review.
Change subject: core: Reduce host connection timeout
..
core: Reduce host connection timeout
The timeout that we currently use to connect to hosts is by default very
large, as
Amador Pahim has posted comments on this change.
Change subject: core: correcting max memory for scheduling VMs field
..
Patch Set 1:
Ok. I got it. Let me argue a bit... without "guest_overhead", the "Max free
Memory for sched
Greg Padgett has posted comments on this change.
Change subject: core,webadmin: Failure to reconnect authenticated iSCSI LUNs
..
Patch Set 2: (4 inline comments)
Thanks Allon and Doron, further comments inline.
...
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 10: (3 inline comments)
More comments.
File
backen
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 10: (1 inline comment)
File backend/manager/dbscript
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Adding "Select All" checkbox header to CellTable
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8282
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: core: Tar cleanup
..
Patch Set 3:
Thanks!
If you still feel like the closure of stream should be modified, feel free to
do this... My view is my personal view..
Alon Bar-Lev has posted comments on this change.
Change subject: core: Tar cleanup
..
Patch Set 3:
I prefer to leave this as-is, the comment is there to say that this is
intentional... well, comment was actually for Juan :)
-
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 9: (13 inline comments)
Incorporated Yair and Moti review comments. One in-line reply for Yair's
comme
Alon Bar-Lev has posted comments on this change.
Change subject: core: Tar cleanup
..
Patch Set 3:
Again
There is no point in fixing the main() it is just for manual testing, never
actually executed. And As I wrote I inte
Shireesh Anjal has posted comments on this change.
Change subject: bootstrap: allow customize bridge name for standard sequence
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Tomas Jelinek has abandoned this change.
Change subject: restapi: VM created from template -> "Bad volume specification"
..
Patch Set 1: Abandoned
http://gerrit.ovirt.org/8092 is a better solution for this
--
To view, visit ht
21 matches
Mail list logo
