Michael Pasternak has posted comments on this change.
Change subject: restapi: Size Missing From Add Vm-Pool Metadata
..
Patch Set 1: I would prefer that you didn't submit this
please add 'size' to update signature as well.
--
Michael Pasternak has posted comments on this change.
Change subject: restapi: Make Gluster Actions Lowercase
..
Patch Set 1: I would prefer that you didn't submit this
please update RSDL meta accordingly.
--
To view, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: remove MAC address from vds unique id
..
Patch Set 8: (1 inline comment)
File
backend/manager/m
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 2: (1 inline comment)
Responses to Selvasundaram comment in-line.
.
Yair Zaslavsky has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: 4.9.6 vdsm version is considered as 3.0 instead of
3.1 (#856507)
..
Patch Set 4: Looks good to me, approved
Looks good.
Many thanks for your help wit
Keith Robertson has posted comments on this change.
Change subject: packaging: Updated UI prompts in wizard
..
Patch Set 2: (5 inline comments)
File packaging/fedora/setup/ou
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Include 'unattached' domains in domains for search view
..
core: Include 'unattached' domains in domains for search view
Join unattached domains
Asaf Shakarchi has posted comments on this change.
Change subject: core: Include 'unattached' domains in domains for search view
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/831
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Fixed error msg when adding a VM disk in diff pool.
..
core: Fixed error msg when adding a VM disk in diff pool.
When creating a new disk for a V
Asaf Shakarchi has posted comments on this change.
Change subject: core: Fixed error msg when adding a VM disk in diff pool.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8319
To
Asaf Shakarchi has posted comments on this change.
Change subject: core: Fixed error msg when adding a VM disk in diff pool.
..
Patch Set 1: (1 inline comment)
Commit Message
Daniel Erez has posted comments on this change.
Change subject: core: Fixed error msg when adding a VM disk in diff pool.
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Please add the BZ number to the commit mes
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: remove MAC address from vds unique id
..
Patch Set 8:
Manual rebase
--
To view, visit http://gerrit.ovirt.org/8125
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 7:
Rebase
--
To view, visit http://gerrit.ovirt.org/8124
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use yum API
..
Patch Set 9:
Manual rebase, need to verify.
--
To view, visit http://gerrit.ovirt.org/8221
To unsubscribe, visit http://gerrit.ovirt.or
Barak Azulay has posted comments on this change.
Change subject: packaging: use yum API
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8221
To unsubscribe, visit http:/
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: Fixed error msg when adding a VM disk in diff pool.
..
core: Fixed error msg when adding a VM disk in diff pool.
When creating a new disk for a VM, speci
Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Resizable table columns
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5243
To unsubscribe, visit http:
Daniel Erez has posted comments on this change.
Change subject: webadmin: Resizable columns in main tab grids
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8199
To unsubscribe, visit http:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fix possible null exception in BooleanRenderer
..
webadmin: fix possible null exception in BooleanRenderer
Probelm:
* there was a possibility of
Daniel Erez has posted comments on this change.
Change subject: webadmin: fix possible null exception in BooleanRenderer
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8252
To uns
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: RSDL missing method for removing VM from storage
domain #858618
..
restapi: RSDL missing method for removing VM from storage domain #858618
https:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Snapshots sub-tab - Disks tab modifications
..
webadmin: Snapshots sub-tab - Disks tab modifications
* Renamed 'Name' column to 'Alias'.
* Added
Daniel Erez has posted comments on this change.
Change subject: webadmin: Snapshots sub-tab - Disks tab modifications
..
Patch Set 2: Verified; Looks good to me, approved
rebased, approved by Tal Nisan
--
To view, visit http:/
Daniel Erez has posted comments on this change.
Change subject: webadmin: Snapshots sub-tab - Disks tab modifications
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8279
To unsubs
Daniel Erez has posted comments on this change.
Change subject: core: Include 'unattached' domains in domains for search view
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8315
To unsubscr
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2508/
Build Number: 2508
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,169
-
Changes Since
Daniel Erez has abandoned this change.
Change subject: Revert "engine:Validate maximum number of hosts in DC.(#771699)"
..
Patch Set 1: Abandoned
already merged
--
To view, visit http://gerrit.ovirt.org/8314
To unsubscribe, vi
Daniel Erez has submitted this change and it was merged.
Change subject: Revert "engine:Validate maximum number of hosts in DC.(#771699)"
..
Revert "engine:Validate maximum number of hosts in DC.(#771699)"
This reverts commit b
Daniel Erez has posted comments on this change.
Change subject: Revert "engine:Validate maximum number of hosts in DC.(#771699)"
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/831
Daniel Erez has uploaded a new change for review.
Change subject: Revert "engine:Validate maximum number of hosts in DC.(#771699)"
..
Revert "engine:Validate maximum number of hosts in DC.(#771699)"
This reverts commit bdd780193
Allon Mureinik has posted comments on this change.
Change subject: core: Include 'unattached' domains in domains for search view
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2507/
Build Number: 2507
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,168
-
Chang
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: Include 'unattached' domains in domains for search view
..
core: Include 'unattached' domains in domains for search view
Join unattached domains in the '
Daniel Erez has reverted this change.
Change subject: Revert "engine:Validate maximum number of hosts in DC.(#771699)"
..
Patch Set 16: Reverted
This patchset was reverted in change: I34a6d053b1bf3ce1f441f906c4872624e28ed850
-
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix HotPlugDiskToVm command test
..
core: Fix HotPlugDiskToVm command test
Change-Id: I3b881c2328d8cf10f6d7bd831f426d437d9b749d
Signed-off-by: Tal Nis
Tal Nisan has posted comments on this change.
Change subject: core: Fix HotPlugDiskToVm command test
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Asaf Shakarchi has posted comments on this change.
Change subject: core: Fix HotPlugDiskToVm command test
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8313
To unsubscribe, visit http://ge
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2506/
Build Number: 2506
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,167
-
Chang
Allon Mureinik has posted comments on this change.
Change subject: core: Fix HotPlugDiskToVm command test
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8313
To unsubsc
Tal Nisan has uploaded a new change for review.
Change subject: core: Fix HotPlugDiskToVm command test
..
core: Fix HotPlugDiskToVm command test
Change-Id: I3b881c2328d8cf10f6d7bd831f426d437d9b749d
Signed-off-by: Tal Nisan
---
Daniel Erez has posted comments on this change.
Change subject: webadmin: 4.9.6 vdsm version is considered as 3.0 instead of
3.1 (#856507)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/83
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/2515/
Build Number: 2515
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,166
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2505/
Build Number: 2505
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,166
-
Changes Sin
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Display the single status of domains in main tab.
..
webadmin: Display the single status of domains in main tab.
Create a new view (storage_d
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Display the single status of domains in main tab.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8258
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Forbid attaching a locked disk to a VM
..
core: Forbid attaching a locked disk to a VM
- Forbid attaching a locked disk to a VM.
- Replaced messa
Asaf Shakarchi has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8167
To unsubscribe,
Alona Kaplan has abandoned this change.
Change subject: webadmin: VM main tab shouldn't have horizontal scroll bar
..
Patch Set 1: Abandoned
Was pushed by mistake
--
To view, visit http://gerrit.ovirt.org/8310
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8167
To unsubscribe, visit http:/
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: 4.9.6 vdsm version is considered as 3.0 instead of
3.1 (#856507)
..
webadmin: 4.9.6 vdsm version is considered as 3.0 instead of 3.1 (#856507)
https:/
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: VM main tab shouldn't have horizontal scroll bar
..
webadmin: VM main tab shouldn't have horizontal scroll bar
https://bugzilla.redhat.com/855705
VM m
Allon Mureinik has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8167
To u
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: added missing b.e. to common.gwt.xml
..
webadmin: added missing b.e. to common.gwt.xml
Added missing business entities classes to Common.gwt.xml
Einav Cohen has posted comments on this change.
Change subject: webadmin: added missing b.e. to common.gwt.xml
..
Patch Set 2: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org/8309
To uns
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
core: Disabling plug disks command during snapshoting (#80)
Lock the VM entity when t
Tal Nisan has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 4: Looks good to me, approved
Rebase
--
To view, visit http://gerrit.ovirt.org/8298
To
Tal Nisan has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8298
To unsubscribe, visit http://
Michael Kublin has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8298
To uns
Tal Nisan has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8298
To unsubscribe, visit http://
Daniel Erez has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8298
To unsubs
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added storage pool name to VDS non operational log
(#854210)
..
core: Added storage pool name to VDS non operational log (#854210)
Added storage pool
Tal Nisan has posted comments on this change.
Change subject: core: Added storage pool name to VDS non operational log
(#854210)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8306
To unsubscribe, visit htt
Daniel Erez has posted comments on this change.
Change subject: webadmin: added missing b.e. to common.gwt.xml
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8309
To unsubscribe, visit http://gerrit.ovirt.or
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: added missing b.e. to common.gwt.xml
..
webadmin: added missing b.e. to common.gwt.xml
Added missing business entities classes to Common.gwt.xml:
Busine
Michael Kublin has posted comments on this change.
Change subject: core: Added storage pool name to VDS non operational log
(#854210)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8306
To
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated UI prompts in wizard
..
packaging: Updated UI prompts in wizard
Change-Id: Iad3fd914c62669f67f134f269f6f6a8d08a5c8c5
Signed-off-by: Alex Lourie
Allon Mureinik has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM
..
Patch Set 6: (1 inline comment)
File
backend/manager/modul
Tal Nisan has uploaded a new change for review.
Change subject: core: Added storage pool name to VDS non operational log
(#854210)
..
core: Added storage pool name to VDS non operational log (#854210)
Added storage pool name to
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Display the single status of domains in main tab.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8258
Daniel Erez has posted comments on this change.
Change subject: webadmin: Adjust mac address field size
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8300
To unsubscribe, visit http://gerr
Daniel Erez has posted comments on this change.
Change subject: webadmin: Display the single status of domains in main tab.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8258
To unsubscrib
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: ordering getAllFromVms
..
core: ordering getAllFromVms
This patch sets an ascending order to getAllFromVms
stored procedure.
This ordering matc
Yair Zaslavsky has posted comments on this change.
Change subject: core: ordering getAllFromVms
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8274
To unsubscribe, visit http://g
Ayal Baron has posted comments on this change.
Change subject: core: ChangeVdsCluster - keep vds_spm_id within the same DC
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: order collections at updateAllInTransaction
..
core: order collections at updateAllInTransaction
This patch sorts all collections at UpdateAllInT
Yair Zaslavsky has posted comments on this change.
Change subject: core: order collections at updateAllInTransaction
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8273
To unsubsc
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Introducing Business Entity comparators
..
core: Introducing Business Entity comparators
Introducing helper classes for basic logic of
Business E
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing Business Entity comparators
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8290
To unsubscribe
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing Business Entity comparators
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8290
To unsubscribe
Michael Kublin has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
...
Michael Kublin has posted comments on this change.
Change subject: core: ordering getAllFromVms
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8274
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: ordering getAllFromVms
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8274
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit htt
Allon Mureinik has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: ordering getAllFromVms
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
...
Michael Kublin has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
..
Patch Set 5:
Let's sum it up...
setup should only use new location.
so the issue is upgrade only
Tal Nisan has posted comments on this change.
Change subject: webadmin: Snapshots sub-tab - Disks tab modifications
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8279
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Using editable combo for volume option key
..
Patch Set 2: Looks good to me, approved
(2 inline comments)
acked (one minor comment- change while rebas
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
..
Patch Set 5: (3 inline comments)
File packagin
Daniel Erez has submitted this change and it was merged.
Change subject: core: avoid NullPointerException in SpmStartVDSCommand
..
core: avoid NullPointerException in SpmStartVDSCommand
When the getSpmStatus command fails we ca
Daniel Erez has posted comments on this change.
Change subject: core: avoid NullPointerException in SpmStartVDSCommand
..
Patch Set 6: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/8072
Daniel Erez has posted comments on this change.
Change subject: core: avoid NullPointerException in SpmStartVDSCommand
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8072
To unsubscribe, vi
Juan Hernandez has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Alex Lourie has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8135
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core: Disabling plug disks command during snapshoting (#80)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: "Fully configured" message for guide me dialogs
(#850439)
..
webadmin: "Fully configured" message for guide me dialogs (#850439)
http://bugzill
Alexey Chub has posted comments on this change.
Change subject: webadmin: "Fully configured" message for guide me dialogs
(#850439)
..
Patch Set 3: Looks good to me, approved
Rebased
--
To view, visit http://gerrit.ovirt.org/
1 - 100 of 185 matches
Mail list logo