[Engine-patches] Change in ovirt-engine[master]: core: fix NPE is Challenger

2012-09-08 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: core: fix NPE is Challenger .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7850 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add notification to quota resize (#848289)

2012-09-08 Thread omasad
ofri masad has uploaded a new change for review. Change subject: webadmin: Add notification to quota resize (#848289) .. webadmin: Add notification to quota resize (#848289) https://bugzilla.redhat.com/848289 This patch continu

[Engine-patches] Change in ovirt-engine[master]: core: fix NPE in canDoAction at AttachDisk.

2012-09-08 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix NPE in canDoAction at AttachDisk. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7848 To un

[Engine-patches] Change in ovirt-engine[master]: core: Change Network Error Msg (#850854)

2012-09-08 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Change Network Error Msg (#850854) .. Patch Set 1: The issue itself was solved in previous commit: http://gerrit.ovirt.org/#/c/7550/ This patch changes the

[Engine-patches] Change in ovirt-engine[master]: core: formated -> formatted

2012-09-08 Thread oourfali
Oved Ourfali has submitted this change and it was merged. Change subject: core: formated -> formatted .. core: formated -> formatted Spelling correction in message. Change-Id: I4d02a9650a3e79e12f2d7f18fb81c0f22ef53eed Signed-o

[Engine-patches] Change in ovirt-engine[master]: core: formated -> formatted

2012-09-08 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: formated -> formatted .. Patch Set 2: Verified; Looks good to me, approved Rebased. -- To view, visit http://gerrit.ovirt.org/7775 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: Replaced getDiskImageDao with getDiskImageDAO

2012-09-08 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Replaced getDiskImageDao with getDiskImageDAO .. Patch Set 1: I agree with kolesnik on this. The convention suggested by kolesnik makes it easier to read a

[Engine-patches] Change in ovirt-engine[master]: core: Replaced getDiskImageDao with getDiskImageDAO

2012-09-08 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Replaced getDiskImageDao with getDiskImageDAO .. Patch Set 1: I am with Yair on this one, I think CamelCase is easier to read if only the 1st letter is ca

[Engine-patches] Change in ovirt-engine[master]: core: Incorrect syntax for String.format

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Incorrect syntax for String.format .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7852 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: fix corner case of random number (Long.MIN_VALUE) in R...

2012-09-08 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. .. core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. Thi

[Engine-patches] Change in ovirt-engine[master]: core: fix corner case of random number (Long.MIN_VALUE) in R...

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: fix corner case of random number (Long.MIN_VALUE) in R...

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/78

[Engine-patches] Change in ovirt-engine[master]: core: fix NPE in canDoAction at AttachDisk.

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix NPE in canDoAction at AttachDisk. .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7848 To un

[Engine-patches] Change in ovirt-engine[master]: core: Replaced getDiskImageDao with getDiskImageDAO

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Replaced getDiskImageDao with getDiskImageDAO .. Patch Set 1: Actually, I would prefer it to and with XXXDao. Mike - what is your input on this - we had t

[Engine-patches] Change in ovirt-engine[master]: core: fix NPE is Challenger

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix NPE is Challenger .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7850 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: formated -> formatted

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: formated -> formatted .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7775 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: [WIP] engine: Import Gluster Cluster

2012-09-08 Thread dgopal
Dhandapani Gopal has abandoned this change. Change subject: [WIP] engine: Import Gluster Cluster .. Patch Set 5: Abandoned Splitted the import cluster feature into 2 patches. Submitted other patches http://gerrit.ovirt.org/#/c

[Engine-patches] Change in ovirt-engine[master]: core: Refactored roles to RolesEntity.

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Refactored roles to RolesEntity. .. Patch Set 1: Just a reminder to rename RoleEntity to Role -- To view, visit http://gerrit.ovirt.org/7229 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core: Added final to member variables.

2012-09-08 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Added final to member variables. .. core: Added final to member variables. These varibles should only be initialized from within the constructor.

[Engine-patches] Change in ovirt-engine[master]: core: Added final to member variables.

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Added final to member variables. .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7189 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Added final to member variables.

2012-09-08 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Added final to member variables. .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7189 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Servers query

2012-09-08 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Gluster Servers query .. Patch Set 6: (8 inline comments) Incorporated review comments. File