[Engine-patches] Change in ovirt-engine[master]: core: Incorrect syntax for String.format

2012-09-07 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: Incorrect syntax for String.format .. core: Incorrect syntax for String.format Changed from '%s%s' to '%2$s' Change-Id: I18a62074802f87957e57bbc2307f8d8

[Engine-patches] Change in ovirt-engine[master]: core: fix corner case of random number (Long.MIN_VALUE) in R...

2012-09-07 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. .. core: fix corner case of random number (Long.MIN_VALUE) in RandomUtils. This code ge

[Engine-patches] Change in ovirt-engine[master]: core: fix NPE is Challenger

2012-09-07 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: fix NPE is Challenger .. core: fix NPE is Challenger Calling executeBasicAuthentication() with null httpSession can lead to NPE. Change-Id: I545a2b0b1251

[Engine-patches] Change in ovirt-engine[master]: core: fix NPE in canDoAction at AttachDisk.

2012-09-07 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: fix NPE in canDoAction at AttachDisk. .. core: fix NPE in canDoAction at AttachDisk. If disk is null, then the method should return instead of proceeding

[Engine-patches] Change in ovirt-engine[master]: packaging: Add posixfs DC type to engine-setup. (BZ#853972)

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Add posixfs DC type to engine-setup. (BZ#853972) .. Patch Set 1: Looks good to me, but someone else must approve Eli, if you think that the database

[Engine-patches] Change in ovirt-engine[master]: utils: ssh: test of invalid command workaround for fedora

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: utils: ssh: test of invalid command workaround for fedora .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: utils: do not fail if using external sshd

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: utils: do not fail if using external sshd .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7751 To unsu

[Engine-patches] Change in ovirt-engine[master]: bootstrap: introduce soft timeouts for operations

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: bootstrap: introduce soft timeouts for operations .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7734

[Engine-patches] Change in ovirt-engine[master]: core: Replaced getDiskImageDao with getDiskImageDAO

2012-09-07 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: Replaced getDiskImageDao with getDiskImageDAO .. core: Replaced getDiskImageDao with getDiskImageDAO This should help fix Jenkins warning - "VERY confusi

[Engine-patches] Change in ovirt-engine[master]: bootstrap: reduce verbosity of errors in event log (#853962)

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: bootstrap: reduce verbosity of errors in event log (#853962) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: engine: Added new column 'sshKeyFingerprint' in the vds_stat...

2012-09-07 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Added new column 'sshKeyFingerprint' in the vds_static table .. Patch Set 5: Exposed sshKeyFingerprint in VDS view. -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated allinone plugin for new security mode

2012-09-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated allinone plugin for new security mode .. packaging: Updated allinone plugin for new security mode Change-Id: I0cec49b25fedba3994b845

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated allinone plugin for new security mode

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated allinone plugin for new security mode .. Patch Set 3: Verified; Looks good to me, approved Merging based on previous acks and verification.

[Engine-patches] Change in ovirt-engine[master]: packaging: Updated allinone plugin for new security mode

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Updated allinone plugin for new security mode .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7719 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: pki: use PKCS#12 format to store keys

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: pki: use PKCS#12 format to store keys .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6883 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: packaging: moving .pgpass to a common location

2012-09-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: moving .pgpass to a common location .. packaging: moving .pgpass to a common location Change-Id: I2dece89583f3066fbd7d3ccd68cdbd14d94cf12a S

[Engine-patches] Change in ovirt-engine[master]: packaging: moving .pgpass to a common location

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: moving .pgpass to a common location .. Patch Set 9: Verified; Looks good to me, approved Merging based on previous acks and verifications. -- To vie

[Engine-patches] Change in ovirt-engine[master]: packaging: moving .pgpass to a common location

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: moving .pgpass to a common location .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7665 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: cleanup: remove void statement from cert.conf

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: cleanup: remove void statement from cert.conf .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6882 To

[Engine-patches] Change in ovirt-engine[master]: packaging: updated storage format in AIO host creation.

2012-09-07 Thread juan . hernandez
Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated storage format in AIO host creation. .. packaging: updated storage format in AIO host creation. Change-Id: I768fddbb387cc31c941c3fdc

[Engine-patches] Change in ovirt-engine[master]: packaging: updated storage format in AIO host creation.

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: updated storage format in AIO host creation. .. Patch Set 2: Verified; Looks good to me, approved Merging based on previous acks and verification. -

[Engine-patches] Change in ovirt-engine[master]: packaging: updated storage format in AIO host creation.

2012-09-07 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: updated storage format in AIO host creation. .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6199 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Servers query

2012-09-07 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Get Gluster Servers query .. Patch Set 6: (8 inline comments) File backend/manager/modules/bll/src

[Engine-patches] Change in ovirt-engine[master]: webadmin: Import gluster cluster

2012-09-07 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Import gluster cluster .. Patch Set 6: Rebased with updated engine patch, please review it. -- To view, visit http://gerrit.ovirt.org/7261 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: Get Gluster Servers query

2012-09-07 Thread dgopal
Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Gluster Servers query .. Patch Set 5: (10 inline comments) Incorporated review comments. Fil

[Engine-patches] Change in ovirt-engine[master]: engine: Peer probe gluster servers on bootstrap

2012-09-07 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Peer probe gluster servers on bootstrap .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7243

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding GlusterStatus to enum translator

2012-09-07 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Adding GlusterStatus to enum translator .. webadmin: Adding GlusterStatus to enum translator GlusterVolumeStatus and GlusterBricksStatus are refactored

[Engine-patches] Change in ovirt-engine[master]: engine: Peer probe gluster servers on bootstrap

2012-09-07 Thread sesubram
Selvasundaram has posted comments on this change. Change subject: engine: Peer probe gluster servers on bootstrap .. Patch Set 10: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: change gracefully shutdown message (#854218)

2012-09-07 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: core: change gracefully shutdown message (#854218) .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7

[Engine-patches] Change in ovirt-engine[master]: webadmin: improve edit vm dialog - vcpu editing (#854942)

2012-09-07 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: improve edit vm dialog - vcpu editing (#854942) .. webadmin: improve edit vm dialog - vcpu editing (#854942) https://bugzilla.redhat.com/854942 Two c

[Engine-patches] Change in ovirt-engine[master]: engine: Peer probe gluster servers on bootstrap

2012-09-07 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Peer probe gluster servers on bootstrap .. Patch Set 10: (1 inline comment) One minor comment in-line.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disable MTU support in 3.0 (#854496)

2012-09-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Disable MTU support in 3.0 (#854496) .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/7814 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Host pinning is ignored on Template creatio...

2012-09-07 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: engine,webadmin: Host pinning is ignored on Template creation (#845570) .. engine,webadmin: Host pinning is ignored on Template creation (#845570) http

[Engine-patches] Change in ovirt-engine[master]: engine, webadmin: Host pinning is ignored on Template creatio...

2012-09-07 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: engine,webadmin: Host pinning is ignored on Template creation (#845570) .. Patch Set 2: Verified; Looks good to me, approved rebased, verified -- To view, visi