oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_unit_tests/1376/ : FAILURE
--
To view
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: minor canDoActionMesage simplification
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_clean_install/1540/ : FAILURE
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup AddBondCommand
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_clean_install/1538/ : SUCCESS
--
To view, v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_clean_install/1536/ : SUCCESS
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup LoginBaseCommand
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_clean_install/1537/ : SUCCESS
--
To view,
ofri masad has posted comments on this change.
Change subject: engine: Prevent move to empty quota (#845070)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/
ofri masad has posted comments on this change.
Change subject: core: Fix quota messages (#838589)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7747
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: do not fail if using external sshd
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_find_bugs/1293/ : FAILURE
--
To vi
Ayal Baron has posted comments on this change.
Change subject: core: do not remove DC if more than one domain (#806952)
..
Patch Set 7: (1 inline comment)
Minor text comment inside.
Maor Lipchuk has uploaded a new change for review.
Change subject: core[WIP]:Lost tasks will become unknown in engine.
..
core[WIP]:Lost tasks will become unknown in engine.
When VDSM looses tasks, engine should be more fault to
Maor Lipchuk has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7756
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Import VM should not be blocked when collapse
..
core:Import VM should not be blocked when collapse
Import VM with disks to block device domain, will not be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: ssh: test of invalid command workaround for fedora
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_clean_install/1
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: DirectLUN - confirmation dialog for SD LUN (#848067)
..
webadmin: DirectLUN - confirmation dialog for SD LUN (#848067)
https://bugzilla.redhat.com/84806
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove deprecated StringHelper in InstallerMessages.
..
core: Remove deprecated StringHelper in InstallerMessages.
Replaced StringHelper with String
Moti Asayag has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in InstallerMessages.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7270
To u
Moti Asayag has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in InstallerMessages.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7270
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Use engine.conf for local configuration
..
Patch Set 2:
Juan, what about of splitting between common parameters and service specific?
Not that I have
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add engine-java-launcher script
..
Patch Set 5:
juan, in order to complete the java home usage, this one needs to be rebased
and cleaned up, right?
--
To
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove deprecated StringHelper in
AddExistingSANStorageDomainCommand.
..
core: Remove deprecated StringHelper in AddExistingSANStorageDomainCommand.
Moti Asayag has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddExistingSANStorageDomainCommand.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup ActivateVdsCommand
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7740
To unsubscribe, v
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in InstallerMessages.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7270
To unsubscribe, visit http://g
Sharad Mishra has posted comments on this change.
Change subject: core: Remove deprecated StringHelper in
AddExistingSANStorageDomainCommand.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7239
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: utils: do not fail if using external sshd
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7751
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: test of invalid command workaround for fedora
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7752
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: test of invalid command workaround for fedora
..
Patch Set 2:
Update parent.
--
To view, visit http://gerrit.ovirt.org/7752
To unsubscribe, visit htt
Alon Bar-Lev has posted comments on this change.
Change subject: utils: do not fail if using external sshd
..
Patch Set 2:
Update parent.
--
To view, visit http://gerrit.ovirt.org/7751
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh: test of invalid command workaround for fedora
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7752
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: utils: do not fail if using external sshd
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7751
To unsubscribe, visit http://gerrit.ovirt.org/se
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: node id: consider bonding MAC addresses as well
..
Patch Set 2:
Barak we should merge this to sync with already merged vdsm behaviour.
--
To view, vis
Alon Bar-Lev has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
..
Patch Set 10:
rebase manually.
make VdsInstallerSSHTest use PKCS#12 with ability to override.
--
To view, visit http://
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: remove void statement from cert.conf
..
Patch Set 8:
rebase.
--
To view, visit http://gerrit.ovirt.org/6882
To unsubscribe, visit http://gerrit.ovirt.or
Sharad Mishra has abandoned this change.
Change subject: core: Remove deprecated StringHelper in
GetAllChildVlanInterfacesQuery.
..
Patch Set 1: Abandoned
not required
--
To view, visit http://gerrit.ovirt.org/7277
To unsubsc
Alon Bar-Lev has uploaded a new change for review.
Change subject: utils: do not fail if using external sshd
..
utils: do not fail if using external sshd
Change-Id: I4c09754e0722592198754418b71319b227cbb9b8
Signed-off-by: Alon B
Alon Bar-Lev has uploaded a new change for review.
Change subject: utils: ssh: test of invalid command workaround for fedora
..
utils: ssh: test of invalid command workaround for fedora
Due to fedora bug#676841, invalid command
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup LoginBaseCommand
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_unit_tests/1360/ : FAILURE
http://jenkins.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce soft timeouts for operations
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7734
To unsubscribe, visit http://gerrit.ovir
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup LoginBaseCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7738
To unsubscribe, vis
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7739
To unsubscr
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup ActivateVdsCommand
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.
Doron Fediuck has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7500
To unsubscribe, visit http://ger
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup AddBondCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7741
To unsubscribe, visit
Sharad Mishra has posted comments on this change.
Change subject: core: minor canDoActionMesage simplification
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Just a minor change to commit me
Doron Fediuck has posted comments on this change.
Change subject: engine: Prevent move to empty quota (#845070)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modul
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup AdddSANStorageDomainCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7737
To unsub
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup AdddSANStorageDomainCommand
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_unit_tests/1359/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: UI: No search string when Dashboard selected (#844902)
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_unit_tests/1358/ :
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: [SetupNetworks] discontinuous arrows (#851496)
..
webadmin: [SetupNetworks] discontinuous arrows (#851496)
https://bugzilla.redhat.com/851496
Discon
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
core:Initialize host name for CDA message(BZ846771)
https://bugzilla.redhat.com/show_bug.cgi?id=84
Maor Lipchuk has posted comments on this change.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
Patch Set 3: Verified; Looks good to me, approved
Acked by tnisan
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Refactor VDS calls to a method (BZ846771)
..
core:Refactor VDS calls to a method (BZ846771)
related to https://bugzilla.redhat.com/show_bug.cgi?id=8
Maor Lipchuk has posted comments on this change.
Change subject: core:Refactor VDS calls to a method (BZ846771)
..
Patch Set 2: Verified; Looks good to me, approved
Acked by tnisan
--
To view, visit http://gerrit.ovirt.org/774
ofri masad has uploaded a new change for review.
Change subject: core: Fix quota messages (#838589)
..
core: Fix quota messages (#838589)
https://bugzilla.redhat.com/838589
The messages for quota-about-to-exceed, quota-in-grace
Maor Lipchuk has posted comments on this change.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7743
To unsubscribe, visit http://gerrit.ov
Tal Nisan has posted comments on this change.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7743
To unsubscribe, visit h
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: ESC key causes error msg
..
webadmin: ESC key causes error msg
In some cases pressing escape key causes an
error with status code 0.
we will i
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: ESC key causes error msg
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: ESC key causes error msg
..
Patch Set 1: Looks good to me, approved
If I understand correctly, the non-standard HTTP response status code zero (0)
typ
Liron Aravot has abandoned this change.
Change subject: asd
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/7744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Cha
Liron Aravot has uploaded a new change for review.
Change subject: core: fix of job messages that uses SnapshotName object
(#844283)
..
core: fix of job messages that uses SnapshotName object (#844283)
https://bugzilla.redhat.c
Liron Aravot has uploaded a new change for review.
Change subject: asd
..
asd
Change-Id: I203a50e541458bdeb6cee0a694537c22fb65c0c9
Signed-off-by: Liron Aravot
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/co
Omer Frenkel has posted comments on this change.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated allinone plugin for new security mode
..
Patch Set 2: Verified
Using ca_file from the engine.
--
To view, visit http://gerrit.ovirt.org/7719
To
Maor Lipchuk has posted comments on this change.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7743
To unsubscribe, visit http://gerrit.ov
Maor Lipchuk has posted comments on this change.
Change subject: core:Refactor VDS calls to a method (BZ846771)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7742
To unsubscribe, visit http://gerrit.ovirt.o
Tal Nisan has posted comments on this change.
Change subject: core:Refactor VDS calls to a method (BZ846771)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7742
To unsubscribe, visit http:/
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Initialize host name for CDA message(BZ846771)
..
core:Initialize host name for CDA message(BZ846771)
https://bugzilla.redhat.com/show_bug.cgi?id=846771
th
Maor Lipchuk has uploaded a new change for review.
Change subject: core:Refactor VDS calls to a method (BZ846771)
..
core:Refactor VDS calls to a method (BZ846771)
related to https://bugzilla.redhat.com/show_bug.cgi?id=846771
T
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Prevent move to empty quota (#845070)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_unit_tests/1357/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: ESC key causes error msg
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_unit_tests/1356/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: removing access protocols and acl in create volume
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_unit_tests/13
Shahar Havivi has posted comments on this change.
Change subject: UI: No search string when Dashboard selected (#844902)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7709
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: UI: No search string when Dashboard selected (#844902)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_find_bugs/1276/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Refactoring Cluster General tab models
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_find_bugs/1274/ : SUCCES
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Refactoring Cluster General tab models
..
Patch Set 2:
Currently hiding/showing the policy and volume details are controlled by
Application Mode.
You a
Michael Pasternak has posted comments on this change.
Change subject: restapi: Template Nics Missing Metadata
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7676
To unsubscribe, visit http:
ofri masad has posted comments on this change.
Change subject: engine: Prevent move to empty quota (#845070)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7736
To unsubscribe, visit http://gerrit.ovirt.org/
Ori Liel has posted comments on this change.
Change subject: restapi: Template Nics Missing Metadata
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/restapi
Shahar Havivi has posted comments on this change.
Change subject: UI: prevent browser right click conext menu (#836066)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7716
To unsubscribe, visit http://gerrit
ofri masad has uploaded a new change for review.
Change subject: engine: Prevent move to empty quota (#845070)
..
engine: Prevent move to empty quota (#845070)
https://bugzilla.redhat.com/845070
When a user was moving a disk to
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: ESC key causes error msg
..
webadmin: ESC key causes error msg
In some cases pressing escape key causes an
error with status code 0.
we will ignore th
Kanagaraj M has posted comments on this change.
Change subject: restapi: removing access protocols and acl in create volume
..
Patch Set 7: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/6410
To unsub
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: introduce soft timeouts for operations
..
bootstrap: introduce soft timeouts for operations
The only place non default ssh timeout was enforced is whe
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: max query parameter doesnt work as expected on
sub-collections #854173
..
restapi: max query parameter doesnt work as expected on sub-collections #
Eli Mesika has submitted this change and it was merged.
Change subject: core: rhevm-upgrade: encrypt vds_static pm_pass..
..
core: rhevm-upgrade: encrypt vds_static pm_pass..
rhevm-upgrade: encrypt vds_static pm_password field
Eli Mesika has posted comments on this change.
Change subject: core: rhevm-upgrade: encrypt vds_static pm_pass..
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7704
To unsubscribe
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add validation for create/edit pool (#849426)
..
Patch Set 2: I would prefer that you didn't submit this
(8 inline comments)
.
Eyal Edri has posted comments on this change.
Change subject: tools: Use standard colors in the shell output (no bz)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7660
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 3: (4 inline comments)
Incorporated comments.
File
backe
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Edit pool hangs when the pool has no VMs (#852297)
..
Patch Set 6: Looks good to me, but someone else must approve
(3 inline comments)
minor comments,
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Cant add correlation id to HostTags #849398
..
restapi: Cant add correlation id to HostTags #849398
https://bugzilla.redhat.com/show_bug.cg
Michael Pasternak has posted comments on this change.
Change subject: restapi: Cant add correlation id to HostTags #849398
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7729
To u
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: subcollection are not listed not shown #854047
..
cli: subcollection are not listed not shown #854047
https://bugzilla.redhat.com/show_bug.cgi?
Michael Pasternak has posted comments on this change.
Change subject: cli: subcollection are not listed not shown #854047
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7726
To un
Tal Nisan has submitted this change and it was merged.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
..
core: Allow to attach V1 and V2 data domains to a DC 3.1
In this patch:
* display domains V1 and
Tal Nisan has posted comments on this change.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7445
To unsub
Tal Nisan has posted comments on this change.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7445
To unsub
Ori Liel has posted comments on this change.
Change subject: restapi: Cant add correlation id to HostTags #849398
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7729
To
Ori Liel has posted comments on this change.
Change subject: cli: subcollection are not listed not shown #854047
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7726
To
1 - 100 of 177 matches
Mail list logo
